[plasmashell] [Bug 422672] New System Monitor widgets: "Apply" button doesn't work as expected after I add or remove a sensor
https://bugs.kde.org/show_bug.cgi?id=422672 Nate Graham changed: What|Removed |Added Version Fixed In||5.21.3 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 422672] New System Monitor widgets: "Apply" button doesn't work as expected after I add or remove a sensor
https://bugs.kde.org/show_bug.cgi?id=422672 David Edmundson changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/libksysguard/commit/0c0e |ma/libksysguard/commit/ace8 |4af86c9cf4b91f219399c3465fe |d824a5d2b9793c1d8c59d019100 |272036891 |5fb38e4e9 --- Comment #9 from David Edmundson --- Git commit ace8d824a5d2b9793c1d8c59d0191005fb38e4e9 by David Edmundson. Committed on 11/03/2021 at 14:25. Pushed by davidedmundson into branch 'Plasma/5.21'. Avoid emitting configurationChanged during save The system montior widgets have a 3 way-sync between it's own internal saving mechanism and external cfg properties purely for the apply button. This leads to us calling load just after save when values sync, and because JS can't compare arrays easily this leads to us emitting the config has changes again immediately. (cherry picked from commit 0c0e4af86c9cf4b91f219399c3465fe272036891) M +28 -11 faces/ConfigSensors.qml https://invent.kde.org/plasma/libksysguard/commit/ace8d824a5d2b9793c1d8c59d0191005fb38e4e9 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 422672] New System Monitor widgets: "Apply" button doesn't work as expected after I add or remove a sensor
https://bugs.kde.org/show_bug.cgi?id=422672 David Edmundson changed: What|Removed |Added Latest Commit||https://invent.kde.org/plas ||ma/libksysguard/commit/0c0e ||4af86c9cf4b91f219399c3465fe ||272036891 Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #8 from David Edmundson --- Git commit 0c0e4af86c9cf4b91f219399c3465fe272036891 by David Edmundson. Committed on 11/03/2021 at 14:05. Pushed by davidedmundson into branch 'master'. Avoid emitting configurationChanged during save The system montior widgets have a 3 way-sync between it's own internal saving mechanism and external cfg properties purely for the apply button. This leads to us calling load just after save when values sync, and because JS can't compare arrays easily this leads to us emitting the config has changes again immediately. M +28 -11 faces/ConfigSensors.qml https://invent.kde.org/plasma/libksysguard/commit/0c0e4af86c9cf4b91f219399c3465fe272036891 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 422672] New System Monitor widgets: "Apply" button doesn't work as expected after I add or remove a sensor
https://bugs.kde.org/show_bug.cgi?id=422672 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #7 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/libksysguard/-/merge_requests/137 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 422672] New System Monitor widgets: "Apply" button doesn't work as expected after I add or remove a sensor
https://bugs.kde.org/show_bug.cgi?id=422672 --- Comment #6 from David Edmundson --- As it is an array ``` cfg_totalSensors = controller.totalSensors; ``` always triggers a change even though the contents of each array is the same. As a relatively quick fix we can guard all of these in some sort of array comparison function -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 422672] New System Monitor widgets: "Apply" button doesn't work as expected after I add or remove a sensor
https://bugs.kde.org/show_bug.cgi?id=422672 --- Comment #5 from David Edmundson --- This was introduced in ``` reset the page when reloaded when the dialog gets closed the page parent changes to null as well when the active config pages is switched. when this appen, reload the config ``` problem is it's also applying on save. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 422672] New System Monitor widgets: "Apply" button doesn't work as expected after I add or remove a sensor
https://bugs.kde.org/show_bug.cgi?id=422672
--- Comment #4 from David Edmundson ---
Indeed. Clicking apply a second time "fixes" it, but that's not ideal.
It appears we call save
that ends up in
function onLowPrioritySensorIdsChanged() {
Qt.callLater(root.loadConfig);
}
(or one of the matching function)
That calls load
That emits configurationChanged
--
You are receiving this mail because:
You are watching all bug changes.
[plasmashell] [Bug 422672] New System Monitor widgets: "Apply" button doesn't work as expected after I add or remove a sensor
https://bugs.kde.org/show_bug.cgi?id=422672 David Edmundson changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 CC||[email protected] -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 422672] New System Monitor widgets: "Apply" button doesn't work as expected after I add or remove a sensor
https://bugs.kde.org/show_bug.cgi?id=422672 --- Comment #3 from Patrick Silva --- it's still reproducible. Operating System: Arch Linux KDE Plasma Version: 5.21.0 KDE Frameworks Version: 5.79.0 Qt Version: 5.15.2 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 422672] New System Monitor widgets: "Apply" button doesn't work as expected after I add or remove a sensor
https://bugs.kde.org/show_bug.cgi?id=422672 wincak changed: What|Removed |Added CC||[email protected] --- Comment #2 from wincak --- I cannot reproduce the described behaviour. After clicking on "Apply" in the dialog (step 6.), changes are saved. However there seems to be a related bug. The apply button behaves in this way: 1. - 5. The same 6. Click on the widget to open it's pop-up (widget is in tray). Changes are already applied. 7. Click on another section on the left side: apply/discard dialog shows up. Click "Cancel". 8. Click on the "Apply" button again: the button goes inactive. 9. Click on another left side section again. The apply/discard dialog does not show up anymore. This happens every time. Tested right after upgrading to 5.21. Operating System: KDE neon 5.21 KDE Plasma Version: 5.21.0 KDE Frameworks Version: 5.79.0 Qt Version: 5.15.2 Kernel Version: 5.4.0-65-generic OS Type: 64-bit Graphics Platform: X11 Processors: 4 × Intel® Core™ i7-3520M CPU @ 2.90GHz Memory: 7,5 GiB of RAM Graphics Processor: Mesa DRI Intel® HD Graphics 4000 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 422672] New System Monitor widgets: "Apply" button doesn't work as expected after I add or remove a sensor
https://bugs.kde.org/show_bug.cgi?id=422672 Patrick Silva changed: What|Removed |Added Version|5.19.90 |5.20.90 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 422672] New System Monitor widgets: "Apply" button doesn't work as expected after I add or remove a sensor
https://bugs.kde.org/show_bug.cgi?id=422672 Patrick Silva changed: What|Removed |Added Version|5.19.0 |5.19.90 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 422672] New System Monitor widgets: "Apply" button doesn't work as expected after I add or remove a sensor
https://bugs.kde.org/show_bug.cgi?id=422672 JanKusanagi changed: What|Removed |Added CC||[email protected] --- Comment #1 from JanKusanagi --- Can reproduce, quite constantly, on Plasma 5.19.1. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 422672] New System Monitor widgets: "Apply" button doesn't work as expected after I add or remove a sensor
https://bugs.kde.org/show_bug.cgi?id=422672 Nate Graham changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 422672] New System Monitor widgets: "Apply" button doesn't work as expected after I add or remove a sensor
https://bugs.kde.org/show_bug.cgi?id=422672 Patrick Silva changed: What|Removed |Added Version|master |5.19.0 -- You are receiving this mail because: You are watching all bug changes.
