[plasmashell] [Bug 433138] Since update to 5.21, system tray icons on a very thin panel are smaller

2022-01-19 Thread Frank Steinmetzger
https://bugs.kde.org/show_bug.cgi?id=433138

--- Comment #31 from Frank Steinmetzger  ---
Created attachment 145651
  --> https://bugs.kde.org/attachment.cgi?id=145651=edit
Whoopsie, forgot the screenshot.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 433138] Since update to 5.21, system tray icons on a very thin panel are smaller

2022-01-19 Thread Frank Steinmetzger
https://bugs.kde.org/show_bug.cgi?id=433138

--- Comment #30 from Frank Steinmetzger  ---
(In reply to veggero from comment #17)
> […]
> Frank: The blurryness should have been fixed in 5.21.2 thanks to the above
> patch. Please report to me whether everything is fine whet it comes out.

(In reply to Frank Steinmetzger from comment #23)
> veggero: I just installed 5.21.2 on the two affected systems and another
> unaffected one. The icon bluriness has gone away now, both in the taskbar
> and also in the tray area.

I’m sorry, but I must rescind my previous answer. I’ve been having blurry icons
again on my laptop (the one with 176 DPI setting) for quite some time now. I
narrowed it down by setting a new DPI and restarting plasmasession. Please look
at the screenshot. The panel is always the same size (in pixels). As you can
see from the clock’s font, the margin is increasing in pixel count (as is
expected to compensate for the higher pixel density, so it always looks the
same physically). But for the icons the margins actually shrink. Could this be
a sign error? :-)

The clipboard icon for 142 DPI is clearly 16×16. But the one for 144 DPI is
only 18 px high instead of the next common icon size (22 I believe). So I think
it would be nice if plasma knew which sizes it may draw (16, 22, 48, 64 and so
in) and which not in order to avoid this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 433138] Since update to 5.21, system tray icons on a very thin panel are smaller

2021-05-22 Thread Matthias Mueller
https://bugs.kde.org/show_bug.cgi?id=433138

--- Comment #29 from Matthias Mueller  ---
I'm now on 5.21.5 and still got the same issue - see my earlier screenshot - i
somehow can't believe THAT should be intentional?!

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 433138] Since update to 5.21, system tray icons on a very thin panel are smaller

2021-03-24 Thread Jan Pavlicek
https://bugs.kde.org/show_bug.cgi?id=433138

--- Comment #28 from Jan Pavlicek  ---
You're right, I'll double check that the change didn't break anything when I
have a bit of time and issue a merge request.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 433138] Since update to 5.21, system tray icons on a very thin panel are smaller

2021-03-24 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=433138

Nate Graham  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |INTENTIONAL

--- Comment #27 from Nate Graham  ---
You could perhaps submit that change to the Oxygen theme:
https://invent.kde.org/plasma/oxygen/-/merge_requests

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 433138] Since update to 5.21, system tray icons on a very thin panel are smaller

2021-03-24 Thread Jan Pavlicek
https://bugs.kde.org/show_bug.cgi?id=433138

--- Comment #26 from Jan Pavlicek  ---
Created attachment 137018
  --> https://bugs.kde.org/attachment.cgi?id=137018=edit
What needs to be changed in panel background to make icons large again

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 433138] Since update to 5.21, system tray icons on a very thin panel are smaller

2021-03-24 Thread Jan Pavlicek
https://bugs.kde.org/show_bug.cgi?id=433138

--- Comment #25 from Jan Pavlicek  ---
I was able to finaly work around this by modifying the SVG files of the Oxygen
theme. For me, changing only the margin hits to 1px, as Ilia Kats said, didn't
work. I had to change the sizes of the panel corners themselves. I have
attached a screenshot of what needs to be done to solve this - the file I
changed is in
/usr/share/plasma/desktoptheme/oxygen2/widgets/panel-background.svgz
(archlinux, might be different elsewhere) - there is also a mask that needs to
be resized in the same way.

I'm not sure what to do with this bug, but I think it can be closed since
workaround exists and if I understand correctly, there are no plans to revert
changes that made this workaround necessary.

Thanks to everyone looking into this, especially Ilia Kats for pointing me into
the right direction.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 433138] Since update to 5.21, system tray icons on a very thin panel are smaller

2021-03-08 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=433138

Nate Graham  changed:

   What|Removed |Added

 CC||a.g...@libero.it

--- Comment #24 from Nate Graham  ---
*** Bug 433777 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 433138] Since update to 5.21, system tray icons on a very thin panel are smaller

2021-03-03 Thread Frank Steinmetzger
https://bugs.kde.org/show_bug.cgi?id=433138

--- Comment #23 from Frank Steinmetzger  ---
veggero: I just installed 5.21.2 on the two affected systems and another
unaffected one. The icon bluriness has gone away now, both in the taskbar and
also in the tray area. I made comparative screenshots and looking at 5.21.1
again, the taskbar items themselves also had aliased (not-sharp) borders on the
left and right. Those are fixed as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 433138] Since update to 5.21, system tray icons on a very thin panel are smaller

2021-03-01 Thread Ilia Kats
https://bugs.kde.org/show_bug.cgi?id=433138

--- Comment #22 from Ilia Kats  ---
Created attachment 136282
  --> https://bugs.kde.org/attachment.cgi?id=136282=edit
panels of different heights

In contrast to Jan, I can also reproduce this with the Breeze theme (attached
screenshots using Breeze Dark). Note that I normally have the panel set to
36px, with Plasma 5.20 the icons would have the full height of the panel.

Jan: For me it really was enough to change the size of the margin-hints object
and restart plasmashell. But there are several plasma-background.svg files, one
in widgets, one in translucent/widgets and one in opaque/widgets, you may need
to edit all of them.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 433138] Since update to 5.21, system tray icons on a very thin panel are smaller

2021-03-01 Thread Jan Pavlicek
https://bugs.kde.org/show_bug.cgi?id=433138

--- Comment #21 from Jan Pavlicek  ---
(In reply to Ilia Kats from comment #12)
> Doesn't work for me. I just edited
> /usr/share/plasma/plasmoids/org.kde.panel/contents/ui/main.qml and restarted
> plasmashell, icons are still too small. Note that editing my plasma theme
> and setting the margin hints in panel-background.svg to 1px helps.

Could you elaborate on how to set the margin hits? I tried dragging the green
boxes in Inkscape, but with no effect - I suspect that their actual size on the
page is not relevant and the 1px height is set elsewhere? Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 433138] Since update to 5.21, system tray icons on a very thin panel are smaller

2021-03-01 Thread Jan Pavlicek
https://bugs.kde.org/show_bug.cgi?id=433138

--- Comment #20 from Jan Pavlicek  ---
I have added bunch of screenshots with different panel heights as veggero to
further clarify the problem. While doing that, I have found that this issue
does not affect Breeze - that theme behaves as Oxygen did before. But I was
able to reproduce the behavior with stock Oxygen as well as my edited one with
colored tray icons.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 433138] Since update to 5.21, system tray icons on a very thin panel are smaller

2021-03-01 Thread Jan Pavlicek
https://bugs.kde.org/show_bug.cgi?id=433138

--- Comment #19 from Jan Pavlicek  ---
Created attachment 136279
  --> https://bugs.kde.org/attachment.cgi?id=136279=edit
Demonstration of different icons sizes in different themes

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 433138] Since update to 5.21, system tray icons on a very thin panel are smaller

2021-02-27 Thread Manuel Geißer
https://bugs.kde.org/show_bug.cgi?id=433138

Manuel Geißer  changed:

   What|Removed |Added

 CC||geisse...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 433138] Since update to 5.21, system tray icons on a very thin panel are smaller

2021-02-26 Thread Jan Pavlicek
https://bugs.kde.org/show_bug.cgi?id=433138

--- Comment #18 from Jan Pavlicek  ---
Hi, I must say I was a little bit confused too, but it seems clear to me now. I
will upload more screenshots today when I get back to my work machine - I am
not using pure Oxygen (I use oxygen-colors), but I am able to reproduce it with
stock Oxygen as well - I'll do a bunch of screenshots and upload.

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 433138] Since update to 5.21, system tray icons on a very thin panel are smaller

2021-02-26 Thread veggero
https://bugs.kde.org/show_bug.cgi?id=433138

veggero  changed:

   What|Removed |Added

 Resolution|INTENTIONAL |WAITINGFORINFO

--- Comment #17 from veggero  ---
After giving this bug a bit more thought, I gotta say I'm really confused. It's
a mess of different bugs mixed in. So let me discuss each one singularly.

Jan: could you upload a couple more screenshot with your panel at size 34, 30,
and maybe 26? Weirdly enough, I cannot reproduce smaller icons at size <35, for
me it's <44 with Oxygen. I think what you are seeing at size 24 are 16px icon,
that - to me - disappear at 24px size. From 24px and on, I get the 22px icons,
which is correct. The other screenshot, panel size 35 or higher, show 22px
icons that should appear from 24px. What theme are you using? It does not look
like pure Oxygen.

Frank: The blurryness should have been fixed in 5.21.2 thanks to the above
patch. Please report to me whether everything is fine whet it comes out.

Matthias: Stupid me. After spending lots of time trying to figure out what the
hell was happening, I remember this is actually a know bug that's fixed in
5.22. It only affects vertical panels. Sorry about the confusion.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 433138] Since update to 5.21, system tray icons on a very thin panel are smaller

2021-02-26 Thread Matthias Mueller
https://bugs.kde.org/show_bug.cgi?id=433138

--- Comment #16 from Matthias Mueller  ---
I don't know if resolved is even the right category - even if it is
intentionally, it still looked way better before imho.  Or are
suggestions/requests tracked elsewhere that i don't know of yet?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 433138] Since update to 5.21, system tray icons on a very thin panel are smaller

2021-02-26 Thread veggero
https://bugs.kde.org/show_bug.cgi?id=433138

veggero  changed:

   What|Removed |Added

 Resolution|FIXED   |INTENTIONAL

--- Comment #15 from veggero  ---
Right.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 433138] Since update to 5.21, system tray icons on a very thin panel are smaller

2021-02-26 Thread Matthias Mueller
https://bugs.kde.org/show_bug.cgi?id=433138

--- Comment #14 from Matthias Mueller  ---
The i guess we shouldn't mark this report as resolved fixed as it originally is
about the size and not the blurriness?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 433138] Since update to 5.21, system tray icons on a very thin panel are smaller

2021-02-26 Thread veggero
https://bugs.kde.org/show_bug.cgi?id=433138

--- Comment #13 from veggero  ---
To clarify, the fix is regarding the blurryness of the icons, not their size.
I'm afraid the size change is intentional.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 433138] Since update to 5.21, system tray icons on a very thin panel are smaller

2021-02-26 Thread Ilia Kats
https://bugs.kde.org/show_bug.cgi?id=433138

Ilia Kats  changed:

   What|Removed |Added

 CC||ilia-k...@gmx.net

--- Comment #12 from Ilia Kats  ---
Doesn't work for me. I just edited
/usr/share/plasma/plasmoids/org.kde.panel/contents/ui/main.qml and restarted
plasmashell, icons are still too small. Note that editing my plasma theme and
setting the margin hints in panel-background.svg to 1px helps.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 433138] Since update to 5.21, system tray icons on a very thin panel are smaller

2021-02-25 Thread Jan Pavlicek
https://bugs.kde.org/show_bug.cgi?id=433138

--- Comment #11 from Jan Pavlicek  ---
Hi,

thanks very much for taking the time to work on this. I'm on Arch packages, so
I should have the 5.21.2 version soon. I'll test it when it lands in repos and
let you know right away!

Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 433138] Since update to 5.21, system tray icons on a very thin panel are smaller

2021-02-25 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=433138

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.21.2
  Latest Commit||https://invent.kde.org/plas
   ||ma/plasma-desktop/-/commit/
   ||1d53973d633dcd9073efe6b38d0
   ||cafb6344d89d0
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #10 from Nate Graham  ---
We have a fix:
https://invent.kde.org/plasma/plasma-desktop/-/commit/1d53973d633dcd9073efe6b38d0cafb6344d89d0

Please test that or wait for Plasma 5.21.2.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 433138] Since update to 5.21, system tray icons on a very thin panel are smaller

2021-02-25 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=433138

--- Comment #9 from Nate Graham  ---
I talked with the author of this change and discovered that the blurriness is
already fixed in Plasma 5.22, but unfortunately the change to do so could not
be backported to Plasma 5.21 because it depended on a Frameworks version that
was newer than the Plasma 5.21 dependency version.

We're going to see if we can backport a smaller version of it that fixes the
bug in Plasma 5.21 without depending on a newer Frameworks version.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 433138] Since update to 5.21, system tray icons on a very thin panel are smaller

2021-02-25 Thread Matthias Mueller
https://bugs.kde.org/show_bug.cgi?id=433138

Matthias Mueller  changed:

   What|Removed |Added

 CC||mat.muel...@mailbox.org

--- Comment #8 from Matthias Mueller  ---
Created attachment 136142
  --> https://bugs.kde.org/attachment.cgi?id=136142=edit
Icon Sizes in 5.21 Tray

i can also confirm an undesirable change in the icon size. I've got a vertical
panel and after updating to 5.21 the icons with the setting "fit to panel size"
are way bigger than before, "small" icons are (i think?) even smaller than
before.
Ideally the icons with setting "fit to size" should be the same size as in the
taskbar for the running programs imho.
In 5.20, that was (at least roughly) the case when using "fit to size" (at
least with my panel width 50)

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 433138] Since update to 5.21, system tray icons on a very thin panel are smaller

2021-02-19 Thread Michal Kec
https://bugs.kde.org/show_bug.cgi?id=433138

Michal Kec (MiK)  changed:

   What|Removed |Added

 CC||k...@kecnet.cz

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 433138] Since update to 5.21, system tray icons on a very thin panel are smaller

2021-02-18 Thread Frank Steinmetzger
https://bugs.kde.org/show_bug.cgi?id=433138

--- Comment #7 from Frank Steinmetzger  ---
Created attachment 135863
  --> https://bugs.kde.org/attachment.cgi?id=135863=edit
The panel on the last of the four systems I upgraded today, before and after
re-login

Aw man, now it’s getting complicated. :(
I just had the time to looked at the last of my machines and this one is just
fine.

The icons do take up less space (less margin, apparently), but their size has
not changed and they are not stretched. And this here panel is even only 26 px
high because the screen is a desktop monitor with only 108 DPI. My previous
screenshot comes from a laptop with a 172 DPI screen, hence a few more pixels.

To summarise:
Today I upgraded four systems: PC, Laptop, Tablet, virtual machine, all running
the same distribution and package versions. I use Oxygen as my main icon theme
on all of them, in case that’s relevant.

SystemPanel heightGraphicsFont DPIIcons look…
-
Laptop   28 px Intel172   blurry
Tablet   38 px Intel192   blurry
PC   26 px Radeon   108   normal
VM  vertical   VMware normal

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 433138] Since update to 5.21, system tray icons on a very thin panel are smaller

2021-02-18 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=433138

Nate Graham  changed:

   What|Removed |Added

 CC||niccolo.venera...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 433138] Since update to 5.21, system tray icons on a very thin panel are smaller

2021-02-18 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=433138

Nate Graham  changed:

   What|Removed |Added

   Priority|NOR |HI
 Resolution|WAITINGFORINFO  |---
   Keywords||regression
 Status|NEEDSINFO   |CONFIRMED
Summary|Since update to 5.21, icons |Since update to 5.21,
   |in systray are smaller  |system tray icons on a very
   ||thin panel are smaller
 Ever confirmed|0   |1

--- Comment #6 from Nate Graham  ---
Can confirm now.

Niccolò, perhaps this is some fallout from the margin changes? At very very
thin panel thicknesses, we need to basically be using no extra margins or else
things are too small.

-- 
You are receiving this mail because:
You are watching all bug changes.