[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-14 Thread Nick Stefanov
https://bugs.kde.org/show_bug.cgi?id=449870

--- Comment #34 from Nick Stefanov  ---
Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-14 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=449870

Nate Graham  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/plasma-workspace/commit/ |ma/plasma-workspace/commit/
   |03f982261b7f329b42d490651ef |b53fec3714c68ae6191f3c2207e
   |ca1f115cbf097   |7b7a06b53d9f5

--- Comment #33 from Nate Graham  ---
Git commit b53fec3714c68ae6191f3c2207e7b7a06b53d9f5 by Nate Graham, on behalf
of Claudio Holo.
Committed on 14/02/2022 at 18:14.
Pushed by ngraham into branch 'Plasma/5.24'.

applets/systemtray: fix SNI context menu usage without libappindicator

StatusNotifierItem.qml does not explicitly handle the case of
right-clicking, which causes right-clicks to be ignored unless you also
happen to have the libappindicator package installed, which injects a
handler for this itself. But this should work even if you don't have
that package installed; this commit fixes it.
FIXED-IN: 5.24.1


(cherry picked from commit 03f982261b7f329b42d490651efca1f115cbf097)

M  +3-0   
applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml

https://invent.kde.org/plasma/plasma-workspace/commit/b53fec3714c68ae6191f3c2207e7b7a06b53d9f5

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-14 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=449870

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/plas
   ||ma/plasma-workspace/commit/
   ||03f982261b7f329b42d490651ef
   ||ca1f115cbf097
 Status|ASSIGNED|RESOLVED
   Version Fixed In||5.24.1

--- Comment #32 from Nate Graham  ---
Git commit 03f982261b7f329b42d490651efca1f115cbf097 by Nate Graham, on behalf
of Claudio Holo.
Committed on 14/02/2022 at 18:13.
Pushed by ngraham into branch 'master'.

applets/systemtray: fix SNI context menu usage without libappindicator

StatusNotifierItem.qml does not explicitly handle the case of
right-clicking, which causes right-clicks to be ignored unless you also
happen to have the libappindicator package installed, which injects a
handler for this itself. But this should work even if you don't have
that package installed; this commit fixes it.
FIXED-IN: 5.24.1

M  +3-0   
applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml

https://invent.kde.org/plasma/plasma-workspace/commit/03f982261b7f329b42d490651efca1f115cbf097

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-14 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=449870

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #31 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1455

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-11 Thread Matt
https://bugs.kde.org/show_bug.cgi?id=449870

--- Comment #30 from Matt  ---
@Claudio - You are awesome!  Thank you so much!

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-11 Thread Nick Stefanov
https://bugs.kde.org/show_bug.cgi?id=449870

--- Comment #29 from Nick Stefanov  ---
@Michael
Yep, it's working! Thank you so much!!!

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-11 Thread Michael
https://bugs.kde.org/show_bug.cgi?id=449870

--- Comment #28 from Michael  ---
@Claudio
Thanks, I didn't realize you don't need that file for compilation.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-11 Thread Claudio
https://bugs.kde.org/show_bug.cgi?id=449870

--- Comment #27 from Claudio  ---
For a workaround just add to the following file on your system (make a backup
copy before):
/usr/share/plasma/plasmoids/org.kde.plasma.private.systemtray/contents/ui/items/StatusNotifierItem.qml
at line 61 the following 3 lines with your texteditor of choice  (nano, kate or
whatever):

case Qt.RightButton:
openContextMenu(pos);
break;

Now run "plasmashell --replace" and the right click menu is working again - no
need to compile anything yourself.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-11 Thread Michael
https://bugs.kde.org/show_bug.cgi?id=449870

--- Comment #26 from Michael  ---
(In reply to Noah Davis from comment #21)
> A quicker self-fix would be to install libappindicator. It seems we missed
> this bug because every KDE dev who tested the patch had libappindicator
> installed.

I don't know about that. I played with libappindicator, and while it does help
discord, old gtk apps (gxneur) still don't have the tray menu. I suspect it'll
be the same for gajim.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-11 Thread Nick Stefanov
https://bugs.kde.org/show_bug.cgi?id=449870

--- Comment #25 from Nick Stefanov  ---
Ah, thanks, let's hope it will be fixed quick.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-11 Thread Michael
https://bugs.kde.org/show_bug.cgi?id=449870

--- Comment #24 from Michael  ---
(In reply to Nick Stefanov from comment #20)
> @Michael
> How we can apply your patch? This weird bug literally ruins my workflow :(

There is no patch. I went and partially undid this commit
https://invent.kde.org/plasma/plasma-workspace/-/commit/ae5f355a992786834babc952c616b21929cd3a97
namely the changes to StatusNotifierItem.qml and then rebuilt and reinstalled.
How to do all that in your distro, I frankly have no idea.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-11 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=449870

--- Comment #23 from Nate Graham  ---
Heh maybe I'll remove libappindicator so I can catch future regressions in this
use case.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-11 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=449870

Nate Graham  changed:

   What|Removed |Added

 CC||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-11 Thread Nick Stefanov
https://bugs.kde.org/show_bug.cgi?id=449870

--- Comment #22 from Nick Stefanov  ---
@Noah Davis
Thank you for your suggestion but unfortunately ibappindicator is not an option
for me. Some of the reasons are very well described in comment 4:
https://bugs.kde.org/show_bug.cgi?id=449870#c4

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-11 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=449870

--- Comment #21 from Noah Davis  ---
(In reply to Nick Stefanov from comment #20)
> @Michael
> How we can apply your patch? This weird bug literally ruins my workflow :(

A quicker self-fix would be to install libappindicator. It seems we missed this
bug because every KDE dev who tested the patch had libappindicator installed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-11 Thread Nick Stefanov
https://bugs.kde.org/show_bug.cgi?id=449870

--- Comment #20 from Nick Stefanov  ---
@Michael
How we can apply your patch? This weird bug literally ruins my workflow :(

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-11 Thread gromky
https://bugs.kde.org/show_bug.cgi?id=449870

gromky  changed:

   What|Removed |Added

   Platform|Gentoo Packages |Neon Packages

--- Comment #19 from gromky  ---
Same problem in Deadbeef player and Altus (Whatsapp client)

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-11 Thread maetthu
https://bugs.kde.org/show_bug.cgi?id=449870

maetthu  changed:

   What|Removed |Added

 CC||[email protected]

--- Comment #18 from maetthu  ---
Slack and 1password are also affected (both electron)

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-11 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=449870

David Edmundson  changed:

   What|Removed |Added

   Priority|NOR |VHI
 CC||[email protected]
   Keywords||regression

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-11 Thread gromky
https://bugs.kde.org/show_bug.cgi?id=449870

gromky  changed:

   What|Removed |Added

 CC||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-10 Thread Nick Stefanov
https://bugs.kde.org/show_bug.cgi?id=449870

--- Comment #17 from Nick Stefanov  ---
*** Bug 449963 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-10 Thread Nick Stefanov
https://bugs.kde.org/show_bug.cgi?id=449870

Nick Stefanov  changed:

   What|Removed |Added

 CC||[email protected]

--- Comment #16 from Nick Stefanov  ---
My findings so far:
Tixati, Teams, Discord, Skype, Jdownloader. All with missing context menu. Is
5.24 still in alpha???

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-10 Thread Michael
https://bugs.kde.org/show_bug.cgi?id=449870

--- Comment #15 from Michael  ---
Okay, I did the manual partial undoind of ae5f355a99 and it fixes the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-10 Thread Michael
https://bugs.kde.org/show_bug.cgi?id=449870

--- Comment #14 from Michael  ---
(In reply to Claudio from comment #6)
> I browsed through the git history and reverting part of the changes in
> StatusNotifierItem.qml of commit ae5f355a992786834babc952c616b21929cd3a97
> makes the right click menu appear again.
> 
> I just readded the following at line 61 and then everything works as
> expected:
> 
>  case Qt.RightButton:
> openContextMenu(pos);
> break;

Could you make it into a patch on top of 5.24 so I could test? I'd very much
appreciate that.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-10 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=449870

--- Comment #13 from Nicolas Fella  ---
What I'm referring to is StatusNotifierItem vs xembed tray icons. Although I'm
not 100% sure that's the relevant difference here

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-10 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=449870

--- Comment #12 from Noah Davis  ---
(In reply to Nicolas Fella from comment #9)
> Which app did you test? It doesn't happen with apps using "proper" SNIs

What makes an SNI "proper" or "improper"?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-10 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=449870

Noah Davis  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-10 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=449870

--- Comment #11 from Noah Davis  ---
Ok, I can reproduce this with Gajim

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-10 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=449870

--- Comment #10 from Noah Davis  ---
(In reply to Nicolas Fella from comment #9)
> Which app did you test? It doesn't happen with apps using "proper" SNIs, so
> all KDE apps, Electron etc
> 
> I can reproduce it on master with Gajim

I tested Discord since the reporter said they had a problem with it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-10 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=449870

--- Comment #9 from Nicolas Fella  ---
Which app did you test? It doesn't happen with apps using "proper" SNIs, so all
KDE apps, Electron etc

I can reproduce it on master with Gajim

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-10 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=449870

--- Comment #8 from Noah Davis  ---
I can't reproduce this on git master. Maybe a commit depending on KF5.91 was
cherry-picked to Plasma 5.24 too soon?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-10 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=449870

Nicolas Fella  changed:

   What|Removed |Added

 CC||[email protected],
   ||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-10 Thread Behzad A
https://bugs.kde.org/show_bug.cgi?id=449870

Behzad A  changed:

   What|Removed |Added

 CC||[email protected]

--- Comment #7 from Behzad A  ---
*** Bug 449928 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-10 Thread Claudio
https://bugs.kde.org/show_bug.cgi?id=449870

--- Comment #6 from Claudio  ---
OK you can ignore my previous post about the journal entry regarding "DBusMenu
interface", as it also appears when downgrading to the still working
plasma-workspace 5.23.90.

I browsed through the git history and reverting part of the changes in
StatusNotifierItem.qml of commit ae5f355a992786834babc952c616b21929cd3a97 makes
the right click menu appear again.

I just readded the following at line 61 and then everything works as expected:

 case Qt.RightButton:
openContextMenu(pos);
break;

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-10 Thread Claudio
https://bugs.kde.org/show_bug.cgi?id=449870

Claudio  changed:

   What|Removed |Added

 CC||[email protected]

--- Comment #5 from Claudio  ---
Same problem here since the upgrade from 5.23.90 to 5.24 - Discord and Gajim
right click menus in the taskbar are no longer working. At the moment of the
right click the following entry appears in the journal:

plasmashell[818]: Could not find DBusMenu interface, falling back to calling
ContextMenu()

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-09 Thread Nikos Chantziaras
https://bugs.kde.org/show_bug.cgi?id=449870

Nikos Chantziaras  changed:

   What|Removed |Added

 CC||[email protected]

--- Comment #4 from Nikos Chantziaras  ---
I have the exact same issue.  Downgrading to 5.23.5 fixes it.

A workaround is to install libappindicator, which is detected by discord and
makes it use a different method to implement its tray icon. However, this is
far from a good workaround because then there's no left click support anymore.
Both right and left clicking on the tray icon will simply open the same context
menu. Normally, what you want is not have libappindicator installed so that a
left click on the tray icon will unminimize discord, and a right click will
open the context menu, like in virtually any other application that has a tray
icon.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-09 Thread Michael
https://bugs.kde.org/show_bug.cgi?id=449870

--- Comment #3 from Michael  ---
Skype's icon doesn't show the menu either.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-09 Thread Behzad A
https://bugs.kde.org/show_bug.cgi?id=449870

Behzad A  changed:

   What|Removed |Added

 CC||[email protected]

--- Comment #2 from Behzad A  ---
*** Bug 449879 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-09 Thread Michael
https://bugs.kde.org/show_bug.cgi?id=449870

--- Comment #1 from Michael  ---
Notably Viber's tray icon menu works as it should.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449870] Tray icons don't react to right click

2022-02-09 Thread Michael
https://bugs.kde.org/show_bug.cgi?id=449870

Michael  changed:

   What|Removed |Added

 CC||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.