[systemsettings] [Bug 470280] Color scheme doesn't change after applying accent color from bw wallpaper
https://bugs.kde.org/show_bug.cgi?id=470280 Fushan Wen changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/plasma-workspace/-/commi |ma/plasma-workspace/-/commi |t/4c08bf02d42b3e67854640e4c |t/e5da1eb6cdd35c8d18f1fdec1 |2ee3a712adf3099 |21cb3cb50103a37 --- Comment #9 from Fushan Wen --- Git commit e5da1eb6cdd35c8d18f1fdec121cb3cb50103a37 by Fushan Wen. Committed on 13/06/2023 at 07:44. Pushed by fusionfuture into branch 'master'. shell: make accent color optional, and enable accent color after slot connection 1. `m_accentColor` in `DesktopView` now becomes an optional value, so when the current accent color is transparent, `ShellCorona::colorChanged` signal can still be emitted without being blocked by `accentColor == m_accentColor`. 2. The `ShellCorona::colorChanged` signal may be emitted earlier than `m_fakeColorRequestConn` is established, so connect to the slot before enabling accent color from wallpaper. STR: 1. Disable accent color from wallpaper 2. Switch to "Cold Ripple" wallpaper 3. Restart plasmashell. 4. Run `qdbus-qt5 org.kde.plasmashell /PlasmaShell org.kde.PlasmaShell.color` Before this commit, the command will hang and quit with error. After this commit, the command will print "0". FIXED-IN: 5.27.6 (cherry picked from commit 4c08bf02d42b3e67854640e4c2ee3a712adf3099) M +15 -6shell/desktopview.cpp M +5-2shell/desktopview.h M +5-3shell/shellcorona.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/e5da1eb6cdd35c8d18f1fdec121cb3cb50103a37 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 470280] Color scheme doesn't change after applying accent color from bw wallpaper
https://bugs.kde.org/show_bug.cgi?id=470280 Fushan Wen changed: What|Removed |Added Latest Commit||https://invent.kde.org/plas ||ma/plasma-workspace/-/commi ||t/4c08bf02d42b3e67854640e4c ||2ee3a712adf3099 Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Version Fixed In||5.27.6 --- Comment #8 from Fushan Wen --- Git commit 4c08bf02d42b3e67854640e4c2ee3a712adf3099 by Fushan Wen. Committed on 13/06/2023 at 00:52. Pushed by fusionfuture into branch 'Plasma/5.27'. shell: make accent color optional, and enable accent color after slot connection 1. `m_accentColor` in `DesktopView` now becomes an optional value, so when the current accent color is transparent, `ShellCorona::colorChanged` signal can still be emitted without being blocked by `accentColor == m_accentColor`. 2. The `ShellCorona::colorChanged` signal may be emitted earlier than `m_fakeColorRequestConn` is established, so connect to the slot before enabling accent color from wallpaper. STR: 1. Disable accent color from wallpaper 2. Switch to "Cold Ripple" wallpaper 3. Restart plasmashell. 4. Run `qdbus-qt5 org.kde.plasmashell /PlasmaShell org.kde.PlasmaShell.color` Before this commit, the command will hang and quit with error. After this commit, the command will print "0". FIXED-IN: 5.27.6 M +15 -6shell/desktopview.cpp M +5-2shell/desktopview.h M +5-3shell/shellcorona.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/4c08bf02d42b3e67854640e4c2ee3a712adf3099 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 470280] Color scheme doesn't change after applying accent color from bw wallpaper
https://bugs.kde.org/show_bug.cgi?id=470280 --- Comment #7 from Fushan Wen --- Git commit 7695386070f6c3c61ac3b95c2234566ef0f5301b by Fushan Wen. Committed on 03/06/2023 at 05:11. Pushed by fusionfuture into branch 'master'. Desktop: set accentColor binding enabled condition Without this, accentColor may still be updated after usedInAccentColor becomes false. (cherry picked from commit cd05ae276c5fb95b129ffd1b2bf651549afe5a48) M +1-0desktoppackage/contents/views/Desktop.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/7695386070f6c3c61ac3b95c2234566ef0f5301b -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 470280] Color scheme doesn't change after applying accent color from bw wallpaper
https://bugs.kde.org/show_bug.cgi?id=470280 --- Comment #6 from Fushan Wen --- Git commit cd05ae276c5fb95b129ffd1b2bf651549afe5a48 by Fushan Wen. Committed on 03/06/2023 at 05:08. Pushed by fusionfuture into branch 'Plasma/5.27'. Desktop: set accentColor binding enabled condition Without this, accentColor may still be updated after usedInAccentColor becomes false. M +1-0desktoppackage/contents/views/Desktop.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/cd05ae276c5fb95b129ffd1b2bf651549afe5a48 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 470280] Color scheme doesn't change after applying accent color from bw wallpaper
https://bugs.kde.org/show_bug.cgi?id=470280 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #5 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2970 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 470280] Color scheme doesn't change after applying accent color from bw wallpaper
https://bugs.kde.org/show_bug.cgi?id=470280 --- Comment #4 from Fushan Wen --- Can reproduce -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 470280] Color scheme doesn't change after applying accent color from bw wallpaper
https://bugs.kde.org/show_bug.cgi?id=470280 Nate Graham changed: What|Removed |Added Status|NEEDSINFO |CONFIRMED Resolution|WAITINGFORINFO |--- Ever confirmed|0 |1 --- Comment #3 from Nate Graham --- Oops, was not testing correctly, sorry. I can in fact reproduce this issue. I wonder if the lack of any colors is throwing off the detector. -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 470280] Color scheme doesn't change after applying accent color from bw wallpaper
https://bugs.kde.org/show_bug.cgi?id=470280 --- Comment #2 from Albina F --- Yes, it still reproduces. -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 470280] Color scheme doesn't change after applying accent color from bw wallpaper
https://bugs.kde.org/show_bug.cgi?id=470280 Nate Graham changed: What|Removed |Added CC||n...@kde.org, ||qydwhotm...@gmail.com Status|REPORTED|NEEDSINFO Resolution|--- |WAITINGFORINFO --- Comment #1 from Nate Graham --- Works for me with those steps. Is this 100% reproducible for you? -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 470280] Color scheme doesn't change after applying accent color from bw wallpaper
https://bugs.kde.org/show_bug.cgi?id=470280 Nicolas Fella changed: What|Removed |Added Product|Breeze |systemsettings Component|Color scheme|kcm_colors CC||nicolas.fe...@gmx.de, ||noaha...@gmail.com, ||tantalising...@gmail.com, ||uhh...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
