[systemsettings] [Bug 489366] Night Light with the "Custom times" option doesn't properly use custom times
https://bugs.kde.org/show_bug.cgi?id=489366 Nate Graham changed: What|Removed |Added Target Milestone|1.0 |--- CC||bharadwaj.raju777@protonmai ||l.com, isma...@gmail.com, ||kwin-bugs-n...@kde.org, ||n...@kde.org Product|plasmashell |systemsettings Component|Brightness and Color|kcm_nightcolor -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 489366] Night Light with the "Custom times" option doesn't properly use custom times
https://bugs.kde.org/show_bug.cgi?id=489366 Miranda changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 CC||mira...@xyla.net --- Comment #2 from Miranda --- Confirmed. Custom times no longer work since updating to 6.1.1. -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 489366] Night Light with the "Custom times" option doesn't properly use custom times
https://bugs.kde.org/show_bug.cgi?id=489366 --- Comment #3 from Natalie Clarius --- I can't reproduce it, it's working fine for me. -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 489366] Night Light with the "Custom times" option doesn't properly use custom times
https://bugs.kde.org/show_bug.cgi?id=489366 deadmeu changed: What|Removed |Added CC||dead...@dmu.gg -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 489366] Night Light with the "Custom times" option doesn't properly use custom times
https://bugs.kde.org/show_bug.cgi?id=489366 --- Comment #4 from deadmeu --- Created attachment 171651 --> https://bugs.kde.org/attachment.cgi?id=171651&action=edit example 1 (the night light is really disabled) -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 489366] Night Light with the "Custom times" option doesn't properly use custom times
https://bugs.kde.org/show_bug.cgi?id=489366 --- Comment #5 from deadmeu --- Created attachment 171652 --> https://bugs.kde.org/attachment.cgi?id=171652&action=edit example 2 (the night light is really enabled) -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 489366] Night Light with the "Custom times" option doesn't properly use custom times
https://bugs.kde.org/show_bug.cgi?id=489366 --- Comment #6 from deadmeu --- Created attachment 171653 --> https://bugs.kde.org/attachment.cgi?id=171653&action=edit example 3 (the night light is really enabled) -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 489366] Night Light with the "Custom times" option doesn't properly use custom times
https://bugs.kde.org/show_bug.cgi?id=489366 --- Comment #7 from deadmeu --- Also an issue for me. The bug seems to show itself when the time ranges get flipped (assuming the current time is a little past 6pm and transition duration is set to 15 minutes): 1. if "Begin night light at" is set to 19:00, and "Begin day light at" is set to 18:00, then the night light will be disabled (GOOD) 2. if you drop the "Begin night light at" time to 17:00, the time range inverts and the night light is enabled (BAD) 3. if you bring the "Begin night light at" time back up to 19:00, and bump up the "Begin day light at" time to 20:00, the time range inverts and the night light is enabled (BAD) See my the attached screenshots for examples of what I'm talking about. The day/night graph is rendered accurately according to the provided times, but the actual time the night light is being enabled differs from this graph, and although the graph says the night light should never be activated in any of these three scenarios, in reality the night light is being enabled in scenarios 2 and 3. -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 489366] Night Light with the "Custom times" option doesn't properly use custom times
https://bugs.kde.org/show_bug.cgi?id=489366 --- Comment #8 from Vlad Zahorodnii --- What is the use case for creating such "flipped" custom times? On the kwin side, we have a guard to fallback to 6:00-18:00 cycle if such a configuration has been provided. -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 489366] Night Light with the "Custom times" option doesn't properly use custom times
https://bugs.kde.org/show_bug.cgi?id=489366 --- Comment #9 from Vlad Zahorodnii --- Just in case, at the moment, the night light kcm is very permissive and allows setting configurations that kwin is going to reject. This one needs to be fixed. -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 489366] Night Light with the "Custom times" option doesn't properly use custom times
https://bugs.kde.org/show_bug.cgi?id=489366 Vlad Zahorodnii changed: What|Removed |Added Latest Commit||https://invent.kde.org/plas ||ma/kwin/-/commit/2adf962467 ||89c08266dcf01cf500094e1330d ||c82 Resolution|--- |FIXED Status|CONFIRMED |RESOLVED --- Comment #10 from Vlad Zahorodnii --- Git commit 2adf96246789c08266dcf01cf500094e1330dc82 by Vlad Zahorodnii. Committed on 15/07/2024 at 12:16. Pushed by vladz into branch 'master'. plugins/nightlight: Relax custom times constraints Apparently the night light kcm allows to set the custom times so the evening is earlier than the morning to handle extreme cases close to the North and the South pole. NightLightManager::updateTransitionTimings() should require no changes. M +1-5src/plugins/nightlight/nightlightmanager.cpp https://invent.kde.org/plasma/kwin/-/commit/2adf96246789c08266dcf01cf500094e1330dc82 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 489366] Night Light with the "Custom times" option doesn't properly use custom times
https://bugs.kde.org/show_bug.cgi?id=489366 Vlad Zahorodnii changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/kwin/-/commit/2adf962467 |ma/kwin/-/commit/6ef1c5dfbb |89c08266dcf01cf500094e1330d |b523eef3b9923af5d448a50079b |c82 |9e6 --- Comment #11 from Vlad Zahorodnii --- Git commit 6ef1c5dfbbb523eef3b9923af5d448a50079b9e6 by Vlad Zahorodnii. Committed on 16/07/2024 at 06:26. Pushed by vladz into branch 'Plasma/6.1'. plugins/nightlight: Relax custom times constraints Apparently the night light kcm allows to set the custom times so the evening is earlier than the morning to handle extreme cases close to the North and the South pole. NightLightManager::updateTransitionTimings() should require no changes. (cherry picked from commit 2adf96246789c08266dcf01cf500094e1330dc82) M +1-5src/plugins/nightlight/nightlightmanager.cpp https://invent.kde.org/plasma/kwin/-/commit/6ef1c5dfbbb523eef3b9923af5d448a50079b9e6 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 489366] Night Light with the "Custom times" option doesn't properly use custom times
https://bugs.kde.org/show_bug.cgi?id=489366 Nate Graham changed: What|Removed |Added Version Fixed In||6.1.3 -- You are receiving this mail because: You are watching all bug changes.
