[umbrello] [Bug 73847] support for UML tagged values

2021-01-14 Thread Oliver Kellogg
https://bugs.kde.org/show_bug.cgi?id=73847

--- Comment #37 from Oliver Kellogg  ---
Git commit d6ff4174622ef2c6db542028908ed2da2a947f1d by Oliver Kellogg.
Committed on 14/01/2021 at 21:23.
Pushed by okellogg into branch 'master'.

Fixes for commit c7fdfef saving of tagged values to XMI:

umbrello/uml1model/stereotype.cpp
- In function saveToXMI1 case !m_attrDefs.isEmpty() loop over m_attrDefs
  call writer.writeEndElement() to close the opened .

umbrello/uml1model/umlobject.cpp
- In function save1end case m_TaggedValues.count(), after end of loop
  over m_TaggedValues call writer.writeEndElement() to close the opened
  .

M  +2-1umbrello/uml1model/stereotype.cpp
M  +2-1umbrello/uml1model/umlobject.cpp

https://invent.kde.org/sdk/umbrello/commit/d6ff4174622ef2c6db542028908ed2da2a947f1d

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 73847] support for UML tagged values

2020-12-28 Thread Oliver Kellogg
https://bugs.kde.org/show_bug.cgi?id=73847

--- Comment #36 from Oliver Kellogg  ---
Git commit 4b1a4d487d1775df1fc8c5828185489b8cd2abf2 by Oliver Kellogg.
Committed on 28/12/2020 at 11:15.
Pushed by okellogg into branch 'master'.

umbrello/dialogs/pages/classoptionspage.cpp followup to commit a7fd431

- In function createShowStereotypeCB texts at calls to cobox->addItem()
  provide context "Stereotype" which was omitted by accident.

M  +3-3umbrello/dialogs/pages/classoptionspage.cpp

https://invent.kde.org/sdk/umbrello/commit/4b1a4d487d1775df1fc8c5828185489b8cd2abf2

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 73847] support for UML tagged values

2020-12-22 Thread Oliver Kellogg
https://bugs.kde.org/show_bug.cgi?id=73847

Oliver Kellogg  changed:

   What|Removed |Added

 Status|ASSIGNED|CONFIRMED

--- Comment #35 from Oliver Kellogg  ---
I set this back to CONFIRMED because I am currently not finding time for a full
implementation.
"Full implementation" would mean
* making a top level menu entry for the tag definition and/or extending the
  UML object dialogs for tag definition
* permitting tags to be applied to all elements for which stereotypes can be
  applied (currently only implemented for classifiers).

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 73847] support for UML tagged values

2020-12-22 Thread Oliver Kellogg
https://bugs.kde.org/show_bug.cgi?id=73847

--- Comment #34 from Oliver Kellogg  ---
The merge from the work/73847-tagged-uml branch adds a minimal implementation:

Below the tree view you should see tabs such as "Tree View", "Stereotypes",
"Diagrams", "UML Objects".
Select the Stereotypes tab.
In the Name/Usage display that appears, right click on the stereotype for which
you want to add tags.
A dialog will pop up which permits specifying up to three tags for the
stereotype.
Note that this dialog only defines the stereotype tag *definition* not the
concrete tag values.

Once the tag types are defined, go back to the Tree View and double click on
the class for which the stereotype attributes shall be applied.
In the General Settings dialog that appears, at the line "Stereotype name"
there will appear additional fields for the attributes.
In these fields the concrete tag values can be filled in.

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 73847] support for UML tagged values

2020-12-21 Thread Oliver Kellogg
https://bugs.kde.org/show_bug.cgi?id=73847

--- Comment #29 from Oliver Kellogg  ---
Git commit 506b58b7e9330c9265b0f6fc808c441d6cd7293e by Oliver Kellogg.
Committed on 17/10/2020 at 21:00.
Pushed by okellogg into branch 'master'.

umbrello/uml1model/umlobject.{h,cpp} followup to commit c7fdfef :
- Add function tags() returning reference to m_TaggedValues.
- In function loadFromXMI1 fix loading of subelement
   and nested elements .

M  +11   -2umbrello/uml1model/umlobject.cpp
M  +2-0umbrello/uml1model/umlobject.h

https://invent.kde.org/sdk/umbrello/commit/506b58b7e9330c9265b0f6fc808c441d6cd7293e

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 73847] support for UML tagged values

2020-12-21 Thread Oliver Kellogg
https://bugs.kde.org/show_bug.cgi?id=73847

--- Comment #33 from Oliver Kellogg  ---
Git commit a7fd4318f7397cbe77f3ae4697f5e482ba31eded by Oliver Kellogg.
Committed on 30/10/2020 at 20:56.
Pushed by okellogg into branch 'master'.

Hook up UMLObject::m_TaggedValues in widgets and class options:

umbrello/basictypes.h
- Add namespace ShowStereoType with Enum { None, Name, Tags }.

umbrello/umbrello.kcfg
- In group "Class Options" change entry "showStereoType" to type "Enum"
  with choices "None", "Name", "Tags".

umbrello/optionstate.h
- In class ClassState change type of member showStereoType to
  Uml::ShowStereoType::Enum.

umbrello/optionstate.cpp
- Adjust function ClassState::loadFromXMI1 to changed type of member
  showStereoType.

umbrello/umlwidgets/umlwidget.{h,cpp}
- Change type of member m_showStereotype to Uml::ShowStereoType::Enum.
- At function showStereotype change return type to
  Uml::ShowStereoType::Enum.
- At function setShowStereotype change argument type to
  Uml::ShowStereoType::Enum.
- New function tags() returns stringified m_umlObject->tags().

umbrello/umlwidgets/widgetbase.cpp
- In function slotMenuSelection add deprecation note at case
  ListPopupMenu::mt_{Show,Hide}_Stereotypes_Selection.

umbrello/umlwidgets/classifierwidget.h
- At enum VisualProperty add deprecation note on value ShowStereotype.

umbrello/umlwidgets/classifierwidget.cpp
- Adjust to change in type of OptionState::ClassState::showStereoType
  and UMLWidget::m_showStereotype.  Affect methods:
  - ClassifierWidget(UMLScene *, UMLClassifier *)
  - ClassifierWidget(UMLScene *, UMLPackage *)
  - bool visualProperty(VisualProperty) const
  - void setVisualPropertyCmd(VisualProperty, bool)
  - QSizeF calculateSize(bool withExtensions) const
  - void paint(QPainter *, const QStyleOptionGraphicsItem *, QWidget *)
  - void changeToClass()
  - void changeToInterface()
  - void changeToPackage()
  - bool loadFromXMI1(QDomElement &)
  - void saveToXMI1(QDomDocument &, QDomElement &)

umbrello/umlwidgets/entitywidget.cpp
- In function slotMenuSelection remove case
  ListPopupMenu::mt_Show_Stereotypes, it is handled in
  UMLWidget::slotMenuSelection().

umbrello/menus/widgetbasepopupmenu.cpp
- Adjust function makeClassifierShowPopup to changed return type of
  UMLWidget::showStereotype().

umbrello/dialogs/pages/classoptionspage.{h,cpp}
- Change type of member m_showStereotypeCB to KComboBox*.
  Reason: It shall represent the values of Uml::ShowStereoType::Enum.
- New function createShowStereotypeCB(QGroupBox*) encapsulates creation
  of the KComboBox for m_showStereotype.
  For the moment this is a member method but it could be made "static"
  or be moved to Dialog_Utils.

M  +14   -2umbrello/basictypes.h
M  +23   -10   umbrello/dialogs/pages/classoptionspage.cpp
M  +3-1umbrello/dialogs/pages/classoptionspage.h
M  +1-1umbrello/menus/widgetbasepopupmenu.cpp
M  +1-1umbrello/optionstate.cpp
M  +2-2umbrello/optionstate.h
M  +7-2umbrello/umbrello.kcfg
M  +57   -21   umbrello/umlwidgets/classifierwidget.cpp
M  +5-1umbrello/umlwidgets/classifierwidget.h
M  +2-1umbrello/umlwidgets/entitywidget.cpp
M  +47   -5umbrello/umlwidgets/umlwidget.cpp
M  +4-3umbrello/umlwidgets/umlwidget.h
M  +2-0umbrello/umlwidgets/widgetbase.cpp

https://invent.kde.org/sdk/umbrello/commit/a7fd4318f7397cbe77f3ae4697f5e482ba31eded

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 73847] support for UML tagged values

2020-12-21 Thread Oliver Kellogg
https://bugs.kde.org/show_bug.cgi?id=73847

--- Comment #32 from Oliver Kellogg  ---
Git commit c588e7b6c7cb76490cde5e840b4150bded318456 by Oliver Kellogg.
Committed on 17/10/2020 at 21:18.
Pushed by okellogg into branch 'master'.

umbrello/dialogs/widgets/comboboxwidgetbase.{h,cpp}
- New function editField() returns the KComboBox *m_editField.
  This is useful for connecting a slot method to signals such as
  currentIndexChanged(), currentTextChanged(), activated().

M  +9-1umbrello/dialogs/widgets/comboboxwidgetbase.cpp
M  +2-0umbrello/dialogs/widgets/comboboxwidgetbase.h

https://invent.kde.org/sdk/umbrello/commit/c588e7b6c7cb76490cde5e840b4150bded318456

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 73847] support for UML tagged values

2020-12-21 Thread Oliver Kellogg
https://bugs.kde.org/show_bug.cgi?id=73847

--- Comment #31 from Oliver Kellogg  ---
Git commit 144e809eb7aa659d8e63d4c465fc35db0ce29ef8 by Oliver Kellogg.
Committed on 17/10/2020 at 21:49.
Pushed by okellogg into branch 'master'.

Hook up UMLObject::m_TaggedValues in the Class, Attribute, and Operation
dialogs:

umbrello/dialogs/pages/classgeneralpage.{h,cpp}
- Remove unused members m_pInstanceL, m_pStereoTypeL.
- New member m_pNameLayout replaces same named local variable of
  classgeneralpage.cpp.
- New member m_pTagL is an array of QLabel* for stereotype tags.
- New member m_pTagLE is an array of KLineEdit* for stereotype tags.
- Function setupDialog initializes m_pTagL[] and m_pTagLE[] using
  Dialog_Utils::makeTagEditFields().
- New function slotStereoTextChanged is connected to
  m_stereotypeWidget->editField() signal currentTextChanged().
  Tag fields are rebuilt using Dialog_Utils::remakeTagEditFields().
- In function apply(), if m_stereotypeWidget and m_pObject are both
  non null then call Dialog_Utils::updateTagsFromEditFields().

umbrello/dialogs/umlattributedialog.{h,cpp}
- New member m_pValuesLayout replaces local variable valuesLayout of
  umlattributedialog.cpp.
- New member m_pTagL is an array of QLabel* for stereotype tags.
- New member m_pTagLE is an array of KLineEdit* for stereotype tags.
- Function setupDialog initializes m_pTagL[] and m_pTagLE[] using
  Dialog_Utils::makeTagEditFields().
- New function slotStereoTextChanged is connected to
  m_stereotypeWidget->editField() signal currentTextChanged().
  Tag fields are rebuilt using Dialog_Utils::remakeTagEditFields().
- In function apply() call Dialog_Utils::updateTagsFromEditFields().

umbrello/dialogs/umloperationdialog.{h,cpp}
- New member m_pGenLayout replaces local variable genLayout of
  umloperationdialog.cpp.
- New member m_pTagL is an array of QLabel* for stereotype tags.
- New member m_pTagLE is an array of KLineEdit* for stereotype tags.
- Function setupDialog initializes m_pTagL[] and m_pTagLE[] using
  Dialog_Utils::makeTagEditFields().
- New function slotStereoTextChanged is connected to
  m_stereotypeWidget->editField() signal currentTextChanged().
  Tag fields are rebuilt using Dialog_Utils::remakeTagEditFields().
- In function apply() call Dialog_Utils::updateTagsFromEditFields().

M  +28   -10   umbrello/dialogs/pages/classgeneralpage.cpp
M  +6-1umbrello/dialogs/pages/classgeneralpage.h
M  +21   -8umbrello/dialogs/umlattributedialog.cpp
M  +7-0umbrello/dialogs/umlattributedialog.h
M  +30   -18   umbrello/dialogs/umloperationdialog.cpp
M  +7-0umbrello/dialogs/umloperationdialog.h

https://invent.kde.org/sdk/umbrello/commit/144e809eb7aa659d8e63d4c465fc35db0ce29ef8

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 73847] support for UML tagged values

2020-12-21 Thread Oliver Kellogg
https://bugs.kde.org/show_bug.cgi?id=73847

--- Comment #30 from Oliver Kellogg  ---
Git commit f0779b7aa6593bacbcf26e60c5da8ac83affe1b9 by Oliver Kellogg.
Committed on 17/10/2020 at 21:11.
Pushed by okellogg into branch 'master'.

umbrello/dialogs/dialog_utils.{h,cpp}
- New function makeTagEditFields creates labeled edit fields for
  stereotype tags.
  The label/line-edit pairs are arranged horizontally on the same row.
  The label texts are taken from the AttributeDefs of the object's
  UMLStereotype.
- New function remakeTagEditFields recreates labeled edit fields for
  stereotype tags.  This means that the existing label/line-edit pairs
  are deleted and new ones are created afresh.
  It is intended for use when the object's stereotype has changed.
  The label/line-edit pairs are arranged horizontally on the same row.
  The label texts are taken from the AttributeDefs of the object's
  UMLStereotype.
- New function updateTagsFromEditFields updates the stereotype tag
  values of the given UMLObject from the corresponding values in the
  given array of KLineEdit widgets.
  This is useful as the action in the slot method when the Apply or
  OK button is pressed.

M  +98   -0umbrello/dialogs/dialog_utils.cpp
M  +15   -0umbrello/dialogs/dialog_utils.h

https://invent.kde.org/sdk/umbrello/commit/f0779b7aa6593bacbcf26e60c5da8ac83affe1b9

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 73847] support for UML tagged values

2020-12-21 Thread Oliver Kellogg
https://bugs.kde.org/show_bug.cgi?id=73847

--- Comment #27 from Oliver Kellogg  ---
Git commit c7fdfefc7df721f2f167e1b52bae9e07f68cb439 by Oliver Kellogg.
Committed on 12/10/2020 at 21:28.
Pushed by okellogg into branch 'master'.

Create branch work/73847-tagged-uml from master@9817ffc :

umbrello/basictypes.h
- New namespace PrimitiveTypes encapsulates basic element of the
  support for UML primitive types:
  - enum Enum lists the available primitive types plus a final value
Reserved which is used for determining the number of values.
  - Integer constant n_types acts as synonym for Reserved.
  - Functions toString convert an Enum or equivalent integer value
to the corresponding string.
  - Function fromString converts a string to the corresponding Enum.
If the string doe not correspond to an Enum value then the value
Reserved is returned.
  - Function fromInt converts an integer position number to the Enum
value at that position.
- At ProgrammingLanguage::Enum value `Reserved' document that this is
  now used for selecting the UML Primitive Types.

umbrello/basictypes.cpp
- Implement the functions in new namespace PrimitiveTypes.
- In namespace ProgrammingLanguage function toString return "none"
  for the Reserved value.

umbrello/uml1model/stereotype.{h,cpp}
- Class AttributeDef defines a stereotype attribute.
- Type AttributeDefs is a QVector of AttributeDef.
  This is the type used by the new protected member m_attrDefs.
- Function clearAttributeDefs clears m_attrDefs.
- Function setAttributeDefs sets m_attrDefs.
- Function getAttributeDefs() returns m_attrDefs.
- Function load1 loads m_attrDefs from XMI.
- Function saveToXMI1 is extended to save m_attrDefs to XMI.

umbrello/model_utils.cpp
- In function isCommonDataType case (gen == 0) return true to reflect
  the fact that UML primitive types are common types.

umbrello/dialogs/stereoattributedialog.{h,cpp}
- Dialog for specifying up to N_STEREOATTRS stereotype attributes.
  A stereotype attribute has a name and type.
  The type can be chosen from among the UML Primitive Types.

umbrello/stereotypeswindow.cpp
- Extend function contextMenuEvent so that if the user clicks on an
  existing stereotype row then a StereoAttributeDialog is opened
  which permits to define the attributes for the selected stereotype.

umbrello/codegenwizard/codegenoptionspage.cpp
- In function setupActiveLanguageBox while-loop, include
  Uml::ProgrammingLanguage::Reserved in the range covered by
  indexCounter.
- In function updateCodeGenerationPolicyTab, do not call
  CodeGenFactory::newCodeGenPolicyExt(pl) if pl is
  Uml::ProgrammingLanguage::Reserved.

umbrello/umldoc.cpp
- In function loadExtensionsFromXMI1 decoding of tag "codegeneration",
  the cgelement attribute "language" may now assume the value "none"
  to denote that the UML primitive types are selected. In this case do
  not attempt setting a code generator.
- In function addDefaultDatatypes, if UMLApp::app()->generator() returns
  null on entry then this causes the UML primitive types to be created.

umbrello/uml.h
- In private slots declare void setLang_none().
- At declaration of m_langAct increase array size by 1 to accomodate
  the action for Uml::ProgrammingLanguage::Reserved.

umbrello/uml.cpp
- In function initActions(),
  - call setProgLangAction for associating Uml::ProgrammingLanguage::
Reserved with the action "setLang_none";
  - connect m_langAct[Uml::ProgrammingLanguage::Reserved] trigger with
the setLang_none slot.
- In function setGenerator :
  - Remove early actions / early return on
(pl == Uml::ProgrammingLanguage::Reserved).
  - If pl is Uml::ProgrammingLanguage::Reserved then avoid allocating
and calling functions on m_codegen. The only actions taken in this
case are: Set m_activeLanguage, call updateLangSelectMenu(pl),
call slotAddDefaultDatatypes().
- Define added slot setLang_none to call
  setActiveLanguage(Uml::ProgrammingLanguage::Reserved).
- In function updateLangSelectMenu include Uml::ProgrammingLanguage::
  Reserved in the range covered by for-loop variable `i'.

umbrello/main.cpp
- In for-loop constructing the "set-language-" options include
  Uml::ProgrammingLanguage::Reserved in the iteration in order to
  construct "set-language-none".
- In for-loop listing the supported languages for option "--languages"
  include Uml::ProgrammingLanguage::Reserved in the iteration.

umbrello/uml1model/umlobject.h
- Add member m_TaggedValues of type QStringList.

umbrello/uml1model/umlobject.cpp   WORK IN PROGRESS
- In function save1 add saving of m_TaggedValues (if non empty).
  This creates a new subelement,  in
  which the  elements are embedded.
- In function loadFromXMI1 add loading of subelement
   with nested elements
  .

umbrello/CMakeLists.txt
- On setting libdialogs_SRCS include new file
  dialogs/stereoattributedialog.cpp.

umbrello/umbrelloui.rc.cmake
- In menu "code" submenu "active_lang_menu" add action "setLang_none".

umbrello/versi

[umbrello] [Bug 73847] support for UML tagged values

2020-12-21 Thread Oliver Kellogg
https://bugs.kde.org/show_bug.cgi?id=73847

--- Comment #28 from Oliver Kellogg  ---
Git commit 66da747fe8dbd48aeea79074da9e06539e4aee59 by Oliver Kellogg.
Committed on 13/10/2020 at 21:44.
Pushed by okellogg into branch 'master'.

Add default value capability at stereotype attribute:

umbrello/uml1model/stereotype.h
- In class AttributeDef,
  - add member defaultVal of type QString;
  - extend constructor for externally provided defaultVal.

umbrello/uml1model/stereotype.cpp
- In function saveToXMI1 loop over m_attrDefs, if ad.defaultVal is
  non empty then setAttribute "initialValue" on attElement.
- In function load1 traversal of QDomNodes tag "UML:Stereotype.feature"
  while-loop over attElem tag "UML:Attribute" retrieve attElem attribute
  "initialValue" into local dfltVal of type QString.
  Pass dfltVal into AttributeDef constructor.

umbrello/dialogs/stereoattributedialog.h
- Add member m_pDefaultValueLabel[N_STEREOATTRS] of type QLabel*.
- Add member m_pDefaultValueEdit [N_STEREOATTRS] of type KLineEdit*.

umbrello/dialogs/stereoattributedialog.cpp
- In function setupDialog() for-loop of row,
  - place m_pDefaultValueLabel[row], m_pDefaultValueEdit[row] into
columns 4, 5 using Dialog_Utils::makeLabeledEditField();
  - in case (adefs.count() > row) initialize m_pDefaultValueEdit[row]
from adefs.at(row).defaultVal.
- In function apply() pass m_pDefaultValueEdit[i]->text().trimmed()
  into UMLStereotype::AttributeDef constructor argument dfltVal.

M  +11   -2umbrello/dialogs/stereoattributedialog.cpp
M  +7-5umbrello/dialogs/stereoattributedialog.h
M  +4-1umbrello/uml1model/stereotype.cpp
M  +5-3umbrello/uml1model/stereotype.h

https://invent.kde.org/sdk/umbrello/commit/66da747fe8dbd48aeea79074da9e06539e4aee59

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 73847] support for UML tagged values

2020-10-12 Thread Oliver Kellogg
https://bugs.kde.org/show_bug.cgi?id=73847

--- Comment #26 from Oliver Kellogg  ---
Further progress happens in the branch work/73847-tagged-uml, see
https://invent.kde.org/sdk/umbrello/-/tree/work/73847-tagged-uml

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 73847] support for UML tagged values

2020-10-10 Thread Oliver Kellogg
https://bugs.kde.org/show_bug.cgi?id=73847

--- Comment #24 from Oliver Kellogg  ---
Git commit 4fa1d9994d0b64172800f4fb3c20c6a61ae09195 by Oliver Kellogg.
Committed on 10/10/2020 at 10:40.
Pushed by okellogg into branch 'master'.

Preparation for reverting commit 92d13fb required by planned changes:

umbrello/uml1model/package.{h,cpp}
- At function addObject add argument interactOnConflict of type bool
  defaulting to true.  If interactOnConflict is passed in false and
  pObject's name is already present in the package's contained objects
  then the function returns false without opening a dialog asking the
  user to provide a different name.

umbrello/codeimport/import_utils.cpp
- In function remapUMLEnum,
  - reduce indentation by returning early in case (ns == 0);
  - for adding `e' to currentScope->containedObjects() call
currentScope->addObject(e, false).

umbrello/codeimport/javaimport.cpp
- In function parseStmt handling of keywords "class" / "interface", for
  adding m_klass to currentScope->containedObjects() call
  currentScope()->addObject(m_klass, false).

M  +26   -21   umbrello/codeimport/import_utils.cpp
M  +3-3umbrello/codeimport/javaimport.cpp
M  +23   -5umbrello/uml1model/package.cpp
M  +1-1umbrello/uml1model/package.h

https://invent.kde.org/sdk/umbrello/commit/4fa1d9994d0b64172800f4fb3c20c6a61ae09195

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 73847] support for UML tagged values

2020-10-10 Thread Oliver Kellogg
https://bugs.kde.org/show_bug.cgi?id=73847

--- Comment #25 from Oliver Kellogg  ---
Git commit 18747a69c5fa6489cab0e71a82b2f68620ec020b by Oliver Kellogg.
Committed on 10/10/2020 at 12:56.
Pushed by okellogg into branch 'master'.

Reverting commit 92d13fb prepares for work on tagged values:

umbrello/uml1model/package.{h,cpp}
- Function containedObjects() shall return UMLObjectList by value.
  Reason: In near future we will not be returning a class member.

umbrello/model_utils.cpp
umbrello/models/objectsmodel.cpp
umbrello/umldoc.cpp
umbrello/umllistview.cpp
umbrello/dialogs/pages/packagecontentspage.cpp
- At calls to UMLPackage::containedObjects() receive returned list by
  value.

M  +3-3umbrello/dialogs/pages/packagecontentspage.cpp
M  +1-1umbrello/model_utils.cpp
M  +4-2umbrello/models/objectsmodel.cpp
M  +1-1umbrello/uml1model/package.cpp
M  +1-1umbrello/uml1model/package.h
M  +10   -8umbrello/umldoc.cpp
M  +1-1umbrello/umllistview.cpp

https://invent.kde.org/sdk/umbrello/commit/18747a69c5fa6489cab0e71a82b2f68620ec020b

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 73847] support for UML tagged values

2020-10-07 Thread Oliver Kellogg
https://bugs.kde.org/show_bug.cgi?id=73847

Oliver Kellogg  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 73847] support for UML tagged values

2020-10-06 Thread Oliver Kellogg
https://bugs.kde.org/show_bug.cgi?id=73847

--- Comment #23 from Oliver Kellogg  ---
(In reply to Julian S. from comment #22)
> 
> Are UML Tagged Values already implemented? I can't find any option to
> specify my own tagged values on class attributes/classes/associations.

Not yet; this is work in progress.
Having started the work, it looks like a tunnel that becomes longer the more I
progress.
There are a lot of preparatory changes necessary before Umbrello is in shape
for adding the actual feature.
This first set of changes will benefit Umbrello regardless of the tagged value
feature. I plan to commit it to git master before making the actual feature
branch.
Judging by my current rate of progress, the work will take at least several
weeks.

> I wonder whether it is possible to specify multiplicity of a class attribute?

This can be done using an association in place of the attribute.

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 73847] support for UML tagged values

2020-10-06 Thread Julian S.
https://bugs.kde.org/show_bug.cgi?id=73847

Julian S.  changed:

   What|Removed |Added

 CC||[email protected]

--- Comment #22 from Julian S.  ---
(In reply to Oliver Kellogg from comment #21)

> There is no need for inventing a new tag here ("StereoApp").
> Instead we can use the UML 1.3 TaggedValue extended by an attribute
>   stereotype="xmiid_of_the_stereotype_def"
> where "xmiid_of_the_stereotype_def" is the xmi.id of the 
> definition.

Are UML Tagged Values already implemented? I can't find any option to specify
my own tagged values on class attributes/classes/associations. Also I wonder
wether it is possible to specifiy multiplicity of a class attribute?
Using v0.34 on Windows.
Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 73847] support for UML tagged values

2020-09-20 Thread Oliver Kellogg
https://bugs.kde.org/show_bug.cgi?id=73847

--- Comment #21 from Oliver Kellogg  ---
(In reply to Oliver Kellogg from comment #20)
> [...]
> 2) Stereotype application
> 
>   
> 
> 
>   
> 

Correction:
There is no need for inventing a new tag here ("StereoApp").
Instead we can use the UML 1.3 TaggedValue extended by an attribute
  stereotype="xmiid_of_the_stereotype_def"
where "xmiid_of_the_stereotype_def" is the xmi.id of the 
definition.

Here the corrected stereotype application example:


  


  


-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 73847] support for UML tagged values

2020-09-20 Thread Oliver Kellogg
https://bugs.kde.org/show_bug.cgi?id=73847

--- Comment #20 from Oliver Kellogg  ---
(In reply to Ralf Habacker from comment #8)
> [...]
> To support uml 1.4 tagged values, it is required
> 1. to add a key/value map to class UMLStereotype

IMHO stereotype definition needs to be separated from stereotype application.
This means that the stereotype definition would declare e.g.
" this stereotype has an attribute named 'foo' of type String and an attribute
'bar' of type Double "
and the stereotype application would define the concrete values of the 'foo'
and 'bar' attributes.
Example in XMI:

1) Stereotype definition

  
  


2) Stereotype application

  


  


We need the separation between definition and application because different
classes will apply the same stereotype but with different concrete values for
the stereotype attributes.
Stereotype attributes cannot be of arbitrary type but they can use the UML
primitive types, see
https://www.omg.org/spec/UML/20161101/PrimitiveTypes.xmi
I.e. the possible attribute types are:
- Boolean
- UnlimitedNatural
- Integer
- Real
- String

The stereotype definition attributes from the example,
  
  
use the xmi.id given at "type" to be equal to the primitive type name.

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 73847] support for UML tagged values

2020-08-12 Thread Oliver Kellogg
https://bugs.kde.org/show_bug.cgi?id=73847

--- Comment #19 from Oliver Kellogg  ---
(In reply to Robert Hairgrove from comment #18)
> Can we close this now?

Unfortunately no. Comment #7 still applies,
> [...] stereotype attributes are not supported at all by Umbrello.

Comment #8 has some ideas but no one has stepped forward.

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 73847] support for UML tagged values

2020-08-11 Thread Robert Hairgrove
https://bugs.kde.org/show_bug.cgi?id=73847

Robert Hairgrove  changed:

   What|Removed |Added

 CC||[email protected]

--- Comment #18 from Robert Hairgrove  ---
Can we close this now?

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 73847] support for UML tagged values

2019-11-23 Thread Ralf Habacker
https://bugs.kde.org/show_bug.cgi?id=73847

Ralf Habacker  changed:

   What|Removed |Added

   Target Milestone|2.19 (KDE Applications  |---
   |16.04)  |

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 73847] support for UML tagged values

2016-02-01 Thread Ralf Habacker via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=73847

Ralf Habacker  changed:

   What|Removed |Added

   Target Milestone|2.18 (KDE Applications  |2.19 (KDE Applications
   |15.12)  |16.04)

-- 
You are receiving this mail because:
You are watching all bug changes.