[valgrind] [Bug 385386] Assertion failed "szB >= CACHE_ENTRY_SIZE" on m_debuginfo/image.c:517

[Julian Seward]

https://bugs.kde.org/show_bug.cgi?id=385386

Julian Seward  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from Julian Seward  ---
Committed, 3542be5bdc706b1a7d5d080ea01e81d4791e20b4.  Thank you
for the patch and the analysis.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 385386] Assertion failed "szB >= CACHE_ENTRY_SIZE" on m_debuginfo/image.c:517

[Reimar Döffinger]

https://bugs.kde.org/show_bug.cgi?id=385386

--- Comment #8 from Reimar Döffinger  ---
I can confirm that something trivial like e.g. below fixes it:

--- a/coregrind/m_debuginfo/image.c
+++ b/coregrind/m_debuginfo/image.c
@@ -509,10 +509,10 @@ static UInt alloc_CEnt ( DiImage* img, SizeT szB, Bool
fromC )
return entNo;
 }

-static void realloc_CEnt ( DiImage* img, UInt entNo, SizeT szB )
+static void realloc_CEnt ( DiImage* img, UInt entNo, SizeT szB, Bool fromC )
 {
vg_assert(img != NULL);
-   vg_assert(szB >= CACHE_ENTRY_SIZE);
+   vg_assert(fromC || szB >= CACHE_ENTRY_SIZE);
vg_assert(is_sane_CEnt("realloc_CEnt-pre", img, entNo));
img->ces[entNo] = ML_(dinfo_realloc)("di.realloc_CEnt.1",
 img->ces[entNo],
@@ -768,7 +768,7 @@ static UChar get_slowcase ( DiImage* img, DiOffT off )
}
vg_assert(i >= 0 && i < CACHE_N_ENTRIES);

-   realloc_CEnt(img, i, size);
+   realloc_CEnt(img, i, size, /*fromC?*/cslc != NULL);
img->ces[i]->size = size;
img->ces[i]->used = 0;
if (cslc == NULL) {

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 385386] Assertion failed "szB >= CACHE_ENTRY_SIZE" on m_debuginfo/image.c:517

[Reimar Döffinger]

https://bugs.kde.org/show_bug.cgi?id=385386

Reimar Döffinger  changed:

   What|Removed |Added

 CC||k...@reimardoeffinger.de

--- Comment #7 from Reimar Döffinger  ---
This seems to be a logic bug in the realloc_CEnt function that was never
adjusted for compressed symbol support.
alloc_CEnt has this logic:
   if (fromC) {
  // szB can be arbitrary
   } else {
  vg_assert(szB ==
CACHE_ENTRY_SIZE);
   }

However realloc_CEnt does not have such a fromC argument and unconditionally
checks
vg_assert(szB >= CACHE_ENTRY_SIZE);
Shouldn't these simply be aligned in behaviour?
Unfortunately I can't share any examples, but I would greatly appreciate if
someone could check my logic and consider a patch based on that.
I think it requires a rather large binary with lots of debug symbols, as the
cache re-uses compressed entries last, and that is when this bug happens.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 385386] Assertion failed "szB >= CACHE_ENTRY_SIZE" on m_debuginfo/image.c:517

[Matt]

https://bugs.kde.org/show_bug.cgi?id=385386

--- Comment #6 from Matt  ---
We found that the assertion is no longer hit when we converted our application
from compressed to uncompressed debug symbols.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 385386] Assertion failed "szB >= CACHE_ENTRY_SIZE" on m_debuginfo/image.c:517

[Matt]

https://bugs.kde.org/show_bug.cgi?id=385386

--- Comment #5 from Matt  ---
In the failure, the values are as such:

szB=424
CACHE_ENTRY_SIZE=8192

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 385386] Assertion failed "szB >= CACHE_ENTRY_SIZE" on m_debuginfo/image.c:517

[Matt]

https://bugs.kde.org/show_bug.cgi?id=385386

Matt  changed:

   What|Removed |Added

 CC||m...@protonmail.ch

--- Comment #4 from Matt  ---
We are able to consistently reproduce this with
Valgrind-3.15.0-608cb11914-20190413

(Different application, not kwrite)

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 385386] Assertion failed "szB >= CACHE_ENTRY_SIZE" on m_debuginfo/image.c:517

[Pedro Ferreira]

https://bugs.kde.org/show_bug.cgi?id=385386

--- Comment #3 from Pedro Ferreira  ---
Despite my attempts, I am no longer able to trigger this.
I do not recall what bug I was looking at when I stumbled onto this, and thus
can't retrace my steps.
Also, Gentoo has upgraded GCC since this was originally reported, so that might
have had an effect on this as well.
I was confident I had saved the debugging symbols file somewhere in case it
would be required, but can't find it.
*sigh* I suppose I am unable to provide you with additional information at
present :(

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 385386] Assertion failed "szB >= CACHE_ENTRY_SIZE" on m_debuginfo/image.c:517

[Julian Seward]

https://bugs.kde.org/show_bug.cgi?id=385386

--- Comment #2 from Julian Seward  ---
I can't imagine how this failed.  Can you still reproduce it?

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 385386] Assertion failed "szB >= CACHE_ENTRY_SIZE" on m_debuginfo/image.c:517

[Pedro Ferreira]

https://bugs.kde.org/show_bug.cgi?id=385386

--- Comment #1 from Pedro Ferreira  ---
Just prior to the crash, the last log message was:

--15349-- Reading syms from /usr/lib64/libQt5Qml.so.5.7.1
--15349--   Considering /usr/lib/debug/usr/lib64/libQt5Qml.so.5.7.1.debug ..
--15349--   .. CRC is valid

Would attaching the debug symbols file help?

-- 
You are receiving this mail because:
You are watching all bug changes.