[valgrind] [Bug 388862] Add replacements for wmemchr and wcsnlen on Linux

2018-03-02 Thread Ivo Raisr
https://bugs.kde.org/show_bug.cgi?id=388862

Ivo Raisr  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #12 from Ivo Raisr  ---
Pushed as 23185f46a17079fcfca35c2ef335a598812cb23b.

https://sourceware.org/git/?p=valgrind.git;a=commitdiff;h=23185f46a17079fcfca35c2ef335a598812cb23b

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 388862] Add replacements for wmemchr and wcsnlen on Linux

2018-03-02 Thread Nix
https://bugs.kde.org/show_bug.cgi?id=388862

--- Comment #11 from Nix  ---
OK OK I was clearly on some serious drugs that day. God only knows what I
actually compiled (though it does seem to work, and is still working). I have
now replaced it with your fixed patch, which also works while having the
significant advantage of not being full of horrible syntax errors. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 388862] Add replacements for wmemchr and wcsnlen on Linux

2018-03-02 Thread Ivo Raisr
https://bugs.kde.org/show_bug.cgi?id=388862

--- Comment #10 from Ivo Raisr  ---
:-)

There was also a problem with the actual replacement definition.
For example wcsnlen had the following:

#if defined(VGO_linux)
 STRNLEN(VG_Z_LIBC_SONAME, wcsnlen)
 STRNLEN(VG_Z_LIBC_SONAME, __GI_wcsnlen)
#endif

This could not have worked.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 388862] Add replacements for wmemchr and wcsnlen on Linux

2018-03-02 Thread Nix
https://bugs.kde.org/show_bug.cgi?id=388862

--- Comment #9 from Nix  ---
OK!

I don't understand how my original wcsnlen() is compiling for me at all: I mean
it's obvious that I forgot I was writing a while and changed to a for halfway
through the statement, leading to something grossly syntactically invalid. I
wonder why it didn't get a compilation error for me? (Because it didn't, and
still doesn't. Weird upon weird! Ah well I'll be moving off this GCC release
soon anyway, so I guess I don't care much. You caught it and that's what
matters.)

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 388862] Add replacements for wmemchr and wcsnlen on Linux

2018-03-02 Thread Ivo Raisr
https://bugs.kde.org/show_bug.cgi?id=388862

Ivo Raisr  changed:

   What|Removed |Added

 Attachment #42|0   |1
is obsolete||

--- Comment #8 from Ivo Raisr  ---
Created attachment 43
  --> https://bugs.kde.org/attachment.cgi?id=43=edit
Add-replacements-for-wmemchr-and-wcsnlen-on-Linux

Make wcslen() operate on Int as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 388862] Add replacements for wmemchr and wcsnlen on Linux

2018-03-02 Thread Ivo Raisr
https://bugs.kde.org/show_bug.cgi?id=388862

--- Comment #7 from Ivo Raisr  ---
Oh, alright, let's make it Int also for wcslen() so the whole file is
consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 388862] Add replacements for wmemchr and wcsnlen on Linux

2018-03-02 Thread Nix
https://bugs.kde.org/show_bug.cgi?id=388862

--- Comment #6 from Nix  ---
I'll admit I don't understand why wmemchr() and wcsnlen() need to take UInt *s
when the other wide character functions in the same file are quite happy with
Ints, but if you prefer it, I don't see any problem doing it that way.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 388862] Add replacements for wmemchr and wcsnlen on Linux

2018-03-02 Thread Ivo Raisr
https://bugs.kde.org/show_bug.cgi?id=388862

Ivo Raisr  changed:

   What|Removed |Added

 Attachment #111086|0   |1
is obsolete||

--- Comment #5 from Ivo Raisr  ---
Created attachment 42
  --> https://bugs.kde.org/attachment.cgi?id=42=edit
0001-Add-replacements-for-wmemchr-and-wcsnlen-on-Linux.patch

Fixed patch originally from Nick Alcock.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 388862] Add replacements for wmemchr and wcsnlen on Linux

2018-03-02 Thread Ivo Raisr
https://bugs.kde.org/show_bug.cgi?id=388862

--- Comment #4 from Ivo Raisr  ---
Thank you for the patch.
I had to make some fixes to make it actually work and do not introduce
regressions. Please review the attachment.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 388862] Add replacements for wmemchr and wcsnlen on Linux

2018-03-02 Thread Ivo Raisr
https://bugs.kde.org/show_bug.cgi?id=388862

Ivo Raisr  changed:

   What|Removed |Added

   Assignee|jsew...@acm.org |iv...@ivosh.net
 Status|UNCONFIRMED |ASSIGNED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 388862] Add replacements for wmemchr and wcsnlen on Linux

2018-03-02 Thread Ivo Raisr
https://bugs.kde.org/show_bug.cgi?id=388862

Ivo Raisr  changed:

   What|Removed |Added

 CC||iv...@ivosh.net
Summary|false positive of   |Add replacements for
   |__wcsnlen_sse4_1 with glibc |wmemchr and wcsnlen on
   |2.26|Linux

-- 
You are receiving this mail because:
You are watching all bug changes.