[valgrind] [Bug 402369] Overhaul DHAT
https://bugs.kde.org/show_bug.cgi?id=402369 Nick Nethercote changed: What|Removed |Added Resolution|--- |FIXED Status|REPORTED|RESOLVED --- Comment #11 from Nick Nethercote --- Landed as https://sourceware.org/git/?p=valgrind.git;a=commit;h=441bfc5f51c7f5f80cc6491d23cbe2dc711d191f -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 402369] Overhaul DHAT
https://bugs.kde.org/show_bug.cgi?id=402369 --- Comment #10 from Nick Nethercote --- > I think the order of the Sort Metrics in the documentation should match that > in dh_view.html. I just double-checked; as far as I can tell it does match. Which ones do you think are out of order? > How much work would it be to have a custom sort/filter option in the viewer? That sounds difficult. I'm having trouble even imagining how it would work. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 402369] Overhaul DHAT
https://bugs.kde.org/show_bug.cgi?id=402369 --- Comment #9 from Julian Seward --- This looks excellent to me; I especially appreciate the documentation. I suggest landing it as-is, and if there's any residual breakage we can easily enough fix it up after the event. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 402369] Overhaul DHAT
https://bugs.kde.org/show_bug.cgi?id=402369 Philippe Waroquiers changed: What|Removed |Added CC||jsew...@acm.org --- Comment #8 from Philippe Waroquiers --- Note that if no effort is available to look at what is suggested in comment 3 and 6, then maybe better to push the patch as is. (for sure, I do not want to block a clear functional improvement for that reason). Julian can maybe comment. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 402369] Overhaul DHAT
https://bugs.kde.org/show_bug.cgi?id=402369 Philippe Waroquiers changed: What|Removed |Added Component|callgrind |dhat Assignee|josef.weidendor...@gmx.de |jsew...@acm.org -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 402369] Overhaul DHAT
https://bugs.kde.org/show_bug.cgi?id=402369 Roger Light changed: What|Removed |Added CC||ro...@atchoo.org --- Comment #7 from Roger Light --- This looks good to me. The viewer in particular is very helpful. Just a few very minor suggestions: I think the order of the Sort Metrics in the documentation should match that in dh_view.html. Should "Sort Metrics" actually be labelled something like "Sort and Filter Metrics"? How much work would it be to have a custom sort/filter option in the viewer? -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 402369] Overhaul DHAT
https://bugs.kde.org/show_bug.cgi?id=402369 --- Comment #6 from Philippe Waroquiers --- (In reply to Nick Nethercote from comment #5) > > It might be interesting to replace the wordFM by an xtree, > > It may. Nonetheless, I'd rather land the code as-is, because it's a major > improvement over the existing DHAT. We can consider optimizations to the > implementation later :) Optimization (in terms of speed) is one (non major) aspect (I would guess that it is unlikely that dhat spends a lot of cpu in this data structure). The main aspect is to avoid adding another dhat specific data structure, instead of reusing (extending) the 'common coregrind data structure', used by massif/memcheck/helgrind. Or told otherwise: avoid growing the code basis unnecessarily. But I have not looked much in details how easy it would be to extend xtre to make it support the dhat and output json. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 402369] Overhaul DHAT
https://bugs.kde.org/show_bug.cgi?id=402369 --- Comment #5 from Nick Nethercote --- > It might be interesting to replace the wordFM by an xtree, It may. Nonetheless, I'd rather land the code as-is, because it's a major improvement over the existing DHAT. We can consider optimizations to the implementation later :) -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 402369] Overhaul DHAT
https://bugs.kde.org/show_bug.cgi?id=402369 Nick Nethercote changed: What|Removed |Added Attachment #117020|0 |1 is obsolete|| --- Comment #4 from Nick Nethercote --- Created attachment 117393 --> https://bugs.kde.org/attachment.cgi?id=117393=edit patch Here is an updated patch with documentation written. I think this is ready to land. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 402369] Overhaul DHAT
https://bugs.kde.org/show_bug.cgi?id=402369 Philippe Waroquiers changed: What|Removed |Added CC||philippe.waroquiers@skynet. ||be --- Comment #3 from Philippe Waroquiers --- No comment about the tool itself, just a suggestion for the implementation. As I understand, dhat has 2 data structures: * an interval tree, to find for an address a what block is covering it * a wordFM of an Execontext, together with some data associated with this execontext. It looks to me that the second data structure could be done by using pub_tool_xtree.h, which is a generalised way to associate data to an execontext, and print it in (currently) 2 output formats : massif format, kcachegrind format. It might be interesting to replace the wordFM by an xtree, and add the json output format to pub_tool_xtree.h (I suspect that an xtree might be somewhat faster than an wordFM). Massif speed was improved a lot when switching it to an xtree. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 402369] Overhaul DHAT
https://bugs.kde.org/show_bug.cgi?id=402369 --- Comment #2 from Nick Nethercote --- If you want to try it out easily: - save the attached file - visit http://njn.valgrind.org/dh_view.html and load the saved file. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 402369] Overhaul DHAT
https://bugs.kde.org/show_bug.cgi?id=402369 --- Comment #1 from Nick Nethercote --- Created attachment 117022 --> https://bugs.kde.org/attachment.cgi?id=117022=edit Sample output file Here is output from a run of the Rust compiler under DHAT. -- You are receiving this mail because: You are watching all bug changes.
