[valgrind] [Bug 470520] Multiple realloc zero errors crash in MC_(eq_Error)

2023-06-02 Thread Mark Wielaard
https://bugs.kde.org/show_bug.cgi?id=470520

Mark Wielaard  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #3 from Mark Wielaard  ---
(In reply to Paul Floyd from comment #2)
> LGTM except that memcheck/tests/realloc_size_zero_again needs to be in
> .gitignore (and add this item to NEWS)

Thanks, pushed with those changes.

commit 453c733ce9dc5dce043e03b7b58efdbf46cd
Author: Mark Wielaard 
Date:   Thu Jun 1 16:10:56 2023 +0200

memcheck: Handle Err_ReallocSizeZero in MC_(eq_Error)

When an realloc size zero error is emitted MC_(eq_Error) is called to
see if the errors can be deduplicated. This crashed since
Err_ReallocSizeZero wasn't handled. Handle it like Err_Free.

Also add a testcase for this case and test with both
--realloc-zero-bytes-frees=yes and
--realloc-zero-bytes-frees=no.
Which will report a different number of errors.

https://bugs.kde.org/show_bug.cgi?id=470520

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 470520] Multiple realloc zero errors crash in MC_(eq_Error)

2023-06-01 Thread Paul Floyd
https://bugs.kde.org/show_bug.cgi?id=470520

--- Comment #2 from Paul Floyd  ---
LGTM except that memcheck/tests/realloc_size_zero_again needs to be in
.gitignore (and add this item to NEWS)

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 470520] Multiple realloc zero errors crash in MC_(eq_Error)

2023-06-01 Thread Paul Floyd
https://bugs.kde.org/show_bug.cgi?id=470520

Paul Floyd  changed:

   What|Removed |Added

 CC||pjfl...@wanadoo.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 470520] Multiple realloc zero errors crash in MC_(eq_Error)

2023-06-01 Thread Mark Wielaard
https://bugs.kde.org/show_bug.cgi?id=470520

Mark Wielaard  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|ASSIGNED
   Assignee|jsew...@acm.org |m...@klomp.org

--- Comment #1 from Mark Wielaard  ---
Created attachment 159393
  --> https://bugs.kde.org/attachment.cgi?id=159393=edit
memcheck: Handle Err_ReallocSizeZero in MC_(eq_Error)

Proposed patch and new testcases

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 470520] Multiple realloc zero errors crash in MC_(eq_Error)

2023-06-01 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=470520

Bug Janitor Service  changed:

   What|Removed |Added

   Severity|normal  |crash

-- 
You are receiving this mail because:
You are watching all bug changes.