KDE4_ADD_TEST_EXECUTABLE's properties don't work

2007-06-21 Thread Andreas Pakulat
Hi, I just wanted to remove the need for knotifyrc to be installed and found out that the set_properties call in KDE4_ADD_TEST_EXECUTABLE doesn't have an effect at all. That means - the executable is put into kdelibs/bin instead of current binary dir - the -DKDESRCDIR is not included properly, I

Re: Installed tests

2007-06-21 Thread Olivier Goffart
Le mardi 19 juin 2007, Andreas Pakulat a écrit : On 19.06.07 10:14:26, David Faure wrote: On Monday 18 June 2007, Andreas Pakulat wrote: Hi, it seems my changes did have an unfortunate impact on installed tests. Two users reported an installing problem with kdelibs on IRC and it

fatal error if KDE compiles with hidden visibility but Q_DECL_EXPORT is defined to nothing

2007-06-21 Thread Matthias Kretz
Hi, as I just got my second report that phonon doesn't link I thought I'd better implement a check that errors out if Qt has been compiled without visibility support but KDE is compiled with default hidden visibility. This is necessary for 1. phonon which uses Q_DECL_EXPORT as export macro 2.

Re: fatal error if KDE compiles with hidden visibility but Q_DECL_EXPORT is defined to nothing

2007-06-21 Thread Thiago Macieira
Matthias Kretz said: Hi, as I just got my second report that phonon doesn't link I thought I'd better implement a check that errors out if Qt has been compiled without visibility support but KDE is compiled with default hidden visibility. This is necessary for 1. phonon which uses

Re: fatal error if KDE compiles with hidden visibility but Q_DECL_EXPORT is defined to nothing

2007-06-21 Thread Andreas Pakulat
On 21.06.07 14:18:03, Thiago Macieira wrote: Matthias Kretz said: Hi, as I just got my second report that phonon doesn't link I thought I'd better implement a check that errors out if Qt has been compiled without visibility support but KDE is compiled with default hidden

Re: fatal error if KDE compiles with hidden visibility but Q_DECL_EXPORT is defined to nothing

2007-06-21 Thread Christian Ehrlicher
Von: Andreas Pakulat [EMAIL PROTECTED] On 21.06.07 14:18:03, Thiago Macieira wrote: Matthias Kretz said: Hi, as I just got my second report that phonon doesn't link I thought I'd better implement a check that errors out if Qt has been compiled without visibility support

Re: fatal error if KDE compiles with hidden visibility but Q_DECL_EXPORT is defined to nothing

2007-06-21 Thread Thiago Macieira
Christian Ehrlicher said: and while this works on Win32, it breaks on linux because Q_DECL_EXPORT doesn't evaluate to default-visibility (don't know the gcc command for that) but to nothing. At least on a default-built qt-copy. It's not the fault of Q_DECL_EXPORT but Q_DECL_IMPORT which is

Re: fatal error if KDE compiles with hidden visibility but Q_DECL_EXPORT is defined to nothing

2007-06-21 Thread Andreas Pakulat
On 21.06.07 15:41:21, Thiago Macieira wrote: Christian Ehrlicher said: and while this works on Win32, it breaks on linux because Q_DECL_EXPORT doesn't evaluate to default-visibility (don't know the gcc command for that) but to nothing. At least on a default-built qt-copy. It's not the

Re: fatal error if KDE compiles with hidden visibility but Q_DECL_EXPORT is defined to nothing

2007-06-21 Thread Andreas Pakulat
On 21.06.07 15:58:45, Andreas Pakulat wrote: On 21.06.07 15:41:21, Thiago Macieira wrote: Christian Ehrlicher said: and while this works on Win32, it breaks on linux because Q_DECL_EXPORT doesn't evaluate to default-visibility (don't know the gcc command for that) but to nothing. At

Re: fatal error if KDE compiles with hidden visibility but Q_DECL_EXPORT is defined to nothing

2007-06-21 Thread Christian Ehrlicher
Thiago Macieira schrieb: Christian Ehrlicher said: and while this works on Win32, it breaks on linux because Q_DECL_EXPORT doesn't evaluate to default-visibility (don't know the gcc command for that) but to nothing. At least on a default-built qt-copy. It's not the fault of Q_DECL_EXPORT but

Re: fatal error if KDE compiles with hidden visibility but Q_DECL_EXPORT is defined to nothing

2007-06-21 Thread Thiago Macieira
Matthias Kretz said: On Thursday 21 June 2007, Thiago Macieira wrote: It's much easier and even probably better to define KDE_EXPORT as Q_DECL_EXPORT (similarly for KDE_IMPORT). That will only move the link error to the first KDE lib that gets linked to a program - if we use our own check

Re: fatal error if KDE compiles with hidden visibility but Q_DECL_EXPORT is defined to nothing

2007-06-21 Thread Thiago Macieira
Christian Ehrlicher said: Thiago Macieira schrieb: Christian Ehrlicher said: It's not the fault of Q_DECL_EXPORT but Q_DECL_IMPORT which is defined to nothing on linux. That's not a problem on ELF/x86, but I do wonder how it compiles at all under 64-bit. It's working because tt uses

Re: KDE4_ADD_TEST_EXECUTABLE's properties don't work

2007-06-21 Thread Alexander Neundorf
On Thursday 21 June 2007 04:17, Andreas Pakulat wrote: Hi, I just wanted to remove the need for knotifyrc to be installed and found out that the set_properties call in KDE4_ADD_TEST_EXECUTABLE doesn't have an effect at all. That means - the executable is put into kdelibs/bin instead of