Howto fix KDE4 Buildsystem with CMake CVS

2008-01-28 Thread Andreas Pakulat
Hi, CMake CVS changed some behaviour in how it treats target_link_directories. Specifically it now doesn't -L switches to the linker call unless one explicitly calls link_directories() and sets the needed paths. This breaks building any module in KDE4 (except kdelibs) because we get some

Re: Howto fix KDE4 Buildsystem with CMake CVS

2008-01-28 Thread Andreas Pakulat
On 28.01.08 16:04:06, David Faure wrote: On Monday 28 January 2008, Andreas Pakulat wrote: Opinions? Better Ideas? Does replacing -lsolid with ${KDE4_SOLID_LIBS} work? After all we already have those variables, so we can avoid -lfoo completely I think. Its not quite that easy. The thing

Re: Howto fix KDE4 Buildsystem with CMake CVS

2008-01-28 Thread Brad King
Andreas Pakulat wrote: On 28.01.08 16:04:06, David Faure wrote: On Monday 28 January 2008, Andreas Pakulat wrote: Opinions? Better Ideas? Does replacing -lsolid with ${KDE4_SOLID_LIBS} work? After all we already have those variables, so we can avoid -lfoo completely I think. Its not

Fwd: kdelibs/cmake/modules patches

2008-01-28 Thread Allen Winter
-- Forwarded Message -- Subject: kdelibs/cmake/modules patches Date: Monday 28 January 2008 From: David Johnson [EMAIL PROTECTED] To: [EMAIL PROTECTED] At the kde-freebsd team, we have make some simple patches to fix some linkage errors, that will sometimes link to KDE3/Qt3

Re: Howto fix KDE4 Buildsystem with CMake CVS

2008-01-28 Thread Brad King
Andreas Pakulat wrote: CMake CVS changed some behaviour in how it treats target_link_directories. Specifically it now doesn't -L switches to the linker call unless one explicitly calls link_directories() and sets the needed paths. I'll elaborate on this point. CMake's link line generation

Re: Howto fix KDE4 Buildsystem with CMake CVS

2008-01-28 Thread David Faure
On Monday 28 January 2008, Andreas Pakulat wrote: Opinions? Better Ideas? Does replacing -lsolid with ${KDE4_SOLID_LIBS} work? After all we already have those variables, so we can avoid -lfoo completely I think. PS: Thanks Brad for the explanation about the changes, seems very sensible

Re: Howto fix KDE4 Buildsystem with CMake CVS

2008-01-28 Thread Andreas Pakulat
On 28.01.08 10:32:15, Andreas Pakulat wrote: There are a couple of ways to fix this: a) introduce KDE_XXX_LIBRARY_DIR (or KDE_LIBRARY_DIR) and add link_directories calls for kde libdir and qt libdir in all CMakeLists.txt all over trunk/. I must be blind. FindKDE4Internal.cmake already

Re: Howto fix KDE4 Buildsystem with CMake CVS

2008-01-28 Thread Andreas Pakulat
On 28.01.08 23:31:34, Andreas Pakulat wrote: On 28.01.08 10:32:15, Andreas Pakulat wrote: There are a couple of ways to fix this: a) introduce KDE_XXX_LIBRARY_DIR (or KDE_LIBRARY_DIR) and add link_directories calls for kde libdir and qt libdir in all CMakeLists.txt all over trunk/.