Re: Review Request 118020: Add XDG directories for AppStream metadata

2014-07-15 Thread Matthias Klumpp
On Juli 15, 2014, 7:01 nachm., Alex Merry wrote: Also the tests? Is there an example of how stuff like this should be tested? (if even - it's a pretty simple thing...) I searched for the existing XDG variables, but they only appear once. - Matthias

Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

2014-07-15 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119302/ --- Review request for Build System, KDE Bindings, kdelibs, Alex Merry, Luca

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

2014-07-15 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119302/#review62432 --- cmake/modules/FindPyQt.py

Re: Review Request 118020: Add XDG directories for AppStream metadata

2014-07-15 Thread Matthias Klumpp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118020/ --- (Updated Juli 15, 2014, 11:21 nachm.) Review request for Extra Cmake

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

2014-07-15 Thread Scott Kitterman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119302/#review62456 --- I think PYQT4_SIP_DIR can still be determined automatically,

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

2014-07-15 Thread Scott Kitterman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119302/#review62457 --- This is the method used in qscintilla2's configure.py (which

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

2014-07-15 Thread Scott Kitterman
On July 16, 2014, 1:42 a.m., Scott Kitterman wrote: This is the method used in qscintilla2's configure.py (which upstream has generally endorsed): #! /usr/bin/python import sys import os if sys.platform == 'win32': data_dir = sys.prefix else: data_dir =