D28444: Add ECMCargo module

2020-04-05 Thread Carson Black
cblack retitled this revision from "WIP/RFC: Add ECMCargo module" to "Add ECMCargo module". cblack edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D28444 To: cblack, #frameworks, #build_system Cc: apol, IlyaBizyaev,

D28444: WIP/RFC: Add ECMCargo module

2020-04-05 Thread Carson Black
cblack updated this revision to Diff 79430. cblack added a comment. Address feedback REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28444?vs=78925=79430 BRANCH cblack/cargo-integration REVISION DETAIL https://phabricator.kde.org/D28444

D28409: ECM: attempt to fix KDEInstallDirsTest.relative_or_absolute on Windows

2020-04-05 Thread David Faure
dfaure closed this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D28409 To: dfaure, kossebau, apol, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, michaelh, ngraham, bruns

D28409: ECM: attempt to fix KDEInstallDirsTest.relative_or_absolute on Windows

2020-04-05 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D28409 To: dfaure, kossebau, apol, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2,

D28409: ECM: attempt to fix KDEInstallDirsTest.relative_or_absolute on Windows

2020-04-05 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > CMakeLists.txt:146 > set(KDEInstallDirsTest.relative_or_absolute_usr_EXTRA_OPTIONS > --build-options -DCMAKE_INSTALL_PREFIX=/usr > -DKDE_INSTALL_USE_QT_SYS_PATHS=FALSE This test uses /usr and passes on Windows. It's not

D28409: ECM: attempt to fix KDEInstallDirsTest.relative_or_absolute on Windows

2020-04-05 Thread Aleix Pol Gonzalez
apol added a comment. Will /tmp then still work on Windows? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D28409 To: dfaure, kossebau, apol, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, michaelh, ngraham,