Re: Review Request 125561: Sync FindGettext.cmake macros with upstream module from CMake

2015-10-09 Thread Jeremy Whiting
> On Oct. 9, 2015, 2:26 p.m., Albert Astals Cid wrote: > > This doesn't look like "a bugfix" to me. Oh, but it is. Without this or cmake_policy(SET CMP0002 OLD) (see https://bugs.kde.org/show_bug.cgi?id=316308) applications that have their own translations in the tarball (everything we

Re: Review Request 125561: Sync FindGettext.cmake macros with upstream module from CMake

2015-10-08 Thread Jeremy Whiting
. Someone else should give the ship it. If it fixes it so setting the CMake policy 0002 to OLD isn't needed anymore that's good. - Jeremy Whiting On Oct. 8, 2015, 11:50 a.m., Hrvoje Senjan wrote: > > --- > This is an automatically ge

Review Request 124476: Fix warning about deprecated regex syntax using perl 5.22 here.

2015-07-26 Thread Jeremy Whiting
; marked by -- HERE in m/(\${ -- HERE MODULE})|(\$MODULE\b)/ at /home/jeremy/devel/kde/src/extragear/utils/kdesrc-build/modules/ksb/Module.pm line 981. Thanks, Jeremy Whiting ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org

Re: Review Request 124476: Fix warning about deprecated regex syntax using perl 5.22 here.

2015-07-26 Thread Jeremy Whiting
marked as submitted. Review request for Build System and Michael Pyne. Changes --- Submitted with commit e2b5dc2b2f4200ab205dd48ea4a2887531bbaca3 by Jeremy Whiting to branch master. Repository: kdesrc-build Description --- More information can be found here: http

Re: building kio on Mac

2015-06-19 Thread Jeremy Whiting
Alex's memory is correct. We can solve this in one of two ways: 1) Patching Qt's QStandardPaths, we tried that and it didn't seem to get anywhere. 2) Using Qt's QstandardPaths when we build and install KDE software. This is the approach I've taken locally and seems to work. I think this is what

Re: Review Request 120648: Encode the URIs which end up in DTD files

2015-02-28 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review76782 --- Ship it! Ship It! - Jeremy Whiting On Oct. 19, 2014, 6:12

Re: Review Request 122135: Add ecm_add_app_icon function.

2015-01-20 Thread Jeremy Whiting
can't test it on windows currently, but I will try it there soon also, for some definition of soon. Ralf can you test this on windows? Feel free to try kanagram's appicon branch if you want. - Jeremy Whiting On Jan. 20, 2015, 1:07 p.m., Alex Merry wrote

Re: Review Request 122135: Add ecm_add_app_icon function.

2015-01-19 Thread Jeremy Whiting
to try it on windows some time also, or for you to tell me how I'm using the macro wrong possibly. - Jeremy Whiting On Jan. 19, 2015, 3:01 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 121448: Introduce ECMAddAppIcon.

2015-01-16 Thread Jeremy Whiting
, in so far as they need similar information. I'll admit it makes porting a little harder, but it should be possible to create a porting script without too much difficulty. Jeremy Whiting wrote: Ralf any updates on this patch? Ralf Habacker wrote: @Alex, you wrote

Re: Review Request 121448: Introduce ECMAddAppIcon.

2015-01-16 Thread Jeremy Whiting
? It's much easier to apply a diff than to figure out where to put this file and if any other changes are needed to use it, etc. - Jeremy Whiting On Dec. 15, 2014, 1:01 a.m., Ralf Habacker wrote: --- This is an automatically generated

Re: Review Request 121448: Introduce ECMAddAppIcon.

2015-01-15 Thread Jeremy Whiting
On Dec. 12, 2014, 7:08 a.m., Alex Merry wrote: modules/ECMAddAppIcon.cmake, line 15 https://git.reviewboard.kde.org/r/121448/diff/1/?file=332663#file332663line15 Would this actually work? The code looks to me like pattern_rx would just be the filename again, so fn would be empty,

Fwd: KDE 4.6.3 tarballs (try#1 part1) uploaded

2011-05-05 Thread Jeremy Whiting
migration issues fixed. I don't think it's worth delaying the rest of kde for our mistake in kdeedu. thanks, Jeremy -- Forwarded message -- From: Jeremy Whiting jpwhit...@kde.org Date: Tue, May 3, 2011 at 1:16 PM Subject: Re: KDE 4.6.3 tarballs (try#1 part1) uploaded To: KDE release

Re: KDE 4.6.3 tarballs (try#1 part1) uploaded

2011-05-02 Thread Jeremy Whiting
On Mon, May 2, 2011 at 4:08 PM, Dirk Mueller muel...@kde.org wrote: On Sunday 01 May 2011, Mark Davies wrote: on kubuntu which doesn't work since it seems to ship the old CMakeLists.txt from before but the cmake configuration has Couldn't see your log at that url but presume I'm

Re: Automoc with qt 4.8 issue.

2011-04-29 Thread Jeremy Whiting
Ugh false alarm I think I was misunderstanding the errors I'm getting when building kdelibs with Qt 4.8 Sorry for the noise Jeremy On Apr 28, 2011 12:54 PM, Alexander Neundorf neund...@kde.org wrote: On Thursday 28 April 2011, you wrote: Hello Alexander, Frederik gladhorn tells me the reason