D18952: new find module for Canberra

This revision was automatically updated to reflect the committed changes. Closed by commit R240:50e8dd7b2d00: new find module for Canberra (authored by sitter). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18952?vs=52042=52043 REVISION DETAIL

D18952: new find module for Canberra

sitter marked an inline comment as done. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D18952 To: sitter, cgiboudeaux Cc: aacid, apol, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18952: new find module for Canberra

sitter updated this revision to Diff 52042. sitter added a comment. explicitly set FOUND_VAR so it is camelcase too REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18952?vs=51976=52042 BRANCH master REVISION DETAIL

D18952: new find module for Canberra

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. Thanks! just a little thing to fix before pushing INLINE COMMENTS > FindCanberra.cmake:75 > +find_package_handle_standard_args(Canberra > +REQUIRED_VARS > +

D18952: new find module for Canberra

sitter updated this revision to Diff 51976. sitter added a comment. fix bad copy paste in compat setup REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18952?vs=51952=51976 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18952

D18952: new find module for Canberra

sitter marked 5 inline comments as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18952 To: sitter, cgiboudeaux Cc: aacid, apol, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18952: new find module for Canberra

sitter updated this revision to Diff 51952. sitter added a comment. - pkgconfig is now quiet - variables are now camelcase - old variables are still set for compat - new imported target (also sets pkgconfig's cflags, which I presume is the sane thing to do) - set package description

D18952: new find module for Canberra

cgiboudeaux added a comment. In D18952#413454 , @aacid wrote: > Yes, imported targets are the future/present :) > > Canberra::Canberra sounds good to me as target name +1 You may also add a set_package_properties() call. see eg:

D18952: new find module for Canberra

aacid added a comment. Yes, imported targets are the future/present :) Canberra::Canberra sounds good to me as target name REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18952 To: sitter, cgiboudeaux Cc: aacid, apol, kde-frameworks-devel,

D18952: new find module for Canberra

sitter added a comment. Good point, I've also noticed that (all?) our finders now also create an IMPORTED target. Should we maybe add that too? If so I guess `Canberra::Canberra` would be the preferred target name? REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D18952: new find module for Canberra

sitter updated this revision to Diff 51576. sitter added a comment. document in rst syntax REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18952?vs=51491=51576 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18952 AFFECTED

D18952: new find module for Canberra

apol added inline comments. INLINE COMMENTS > FindCanberra.cmake:4 > +# > +# CANBERRA_FOUND- true if libcanberra was found > +# CANBERRA_LIBRARIES- libcanberra libraries to link against Maybe you can follow the style (rst syntax?) that Volker used here D18944

D18952: new find module for Canberra

lbeltrame added a reviewer: cgiboudeaux. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18952 To: sitter, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18952: new find module for Canberra

sitter created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY used by: - knotification - (possibly also knotifyconfig at some point) - plasma-pa