D24841: Use modern way to set the C/CXX standad

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH cmake_c_standard REVISION DETAIL https://phabricator.kde.org/D24841 To: vonreth, dfaure, cullmann Cc: aacid, chehrlic, kde-frameworks-devel, kde-buildsystem,

D24841: Use modern way to set the C/CXX standad

vonreth updated this revision to Diff 68488. vonreth added a comment. - Raise CMake requirements to 3.5 REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24841?vs=68486=68488 BRANCH cmake_c_standard REVISION DETAIL

D24841: Use modern way to set the C/CXX standad

dfaure added a comment. Dunno, it's harder to justify in a standalone review :) "Increase dependency, just because" ;) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24841 To: vonreth, dfaure, cullmann Cc: aacid, chehrlic, kde-frameworks-devel,

D24841: Use modern way to set the C/CXX standad

vonreth added a comment. I guess we should do that in a separate review? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24841 To: vonreth, dfaure, cullmann Cc: aacid, chehrlic, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy,

D24841: Use modern way to set the C/CXX standad

vonreth updated this revision to Diff 68486. vonreth added a comment. Fix REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24841?vs=68478=68486 BRANCH cmake_c_standard REVISION DETAIL https://phabricator.kde.org/D24841 AFFECTED FILES

D24841: Use modern way to set the C/CXX standad

aacid added a comment. If you want to increase cmake dependency, we should at least increase it to 3.5 https://repology.org/project/cmake/badges REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24841 To: vonreth, dfaure, cullmann Cc: aacid,

D24841: Use modern way to set the C/CXX standad

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > KDECompilerSettings.cmake:208 > +set(CMAKE_C_STANDARD 90) > +set(CMAKE_CXX_STANDARD_REQUIRED 11) > That's not how it works. You want

D24841: Use modern way to set the C/CXX standad

vonreth updated this revision to Diff 68478. vonreth added a comment. CMAKE_CXX_STANDARD_REQUIRED REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24841?vs=68475=68478 BRANCH cmake_c_standard REVISION DETAIL

D24841: Use modern way to set the C/CXX standad

vonreth edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24841 To: vonreth, dfaure, cullmann Cc: chehrlic, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D24841: Use modern way to set the C/CXX standad

vonreth added a comment. In D24841#551653 , @chehrlic wrote: > I would also use CMAKE_CXX_STANDARD_REQUIRED to make sure the compiler actually *can* c++11, otherwise the flag is only added when the compiler supports it. Should not make much

D24841: Use modern way to set the C/CXX standad

chehrlic added a comment. I would also use CMAKE_CXX_STANDARD_REQUIRED to make sure the compiler actually *can* c++11, otherwise the flag is only added when the compiler supports it. Should not make much difference nowadays but since it's in ECM... REPOSITORY R240 Extra CMake Modules

D24841: Use modern way to set the C/CXX standad

vonreth updated this revision to Diff 68475. vonreth added a comment. Change message REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24841?vs=68473=68475 BRANCH cmake_c_standard REVISION DETAIL https://phabricator.kde.org/D24841 AFFECTED

D24841: Use modern way to set the C/CXX standad

vonreth added reviewers: dfaure, cullmann. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24841 To: vonreth, dfaure, cullmann Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D24841: Use modern way to set the C/CXX standad

vonreth created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vonreth requested review of this revision. REVISION SUMMARY Raise C from C89 ti C90 as C89 is not supported by the CMAKE flag