Re: Do not force CMAKE_COLOR_MAKEFILE=ON

2010-06-29 Thread Maciej Mrozowski
On Tuesday 29 of June 2010 23:29:39 Alexander Neundorf wrote: [...] Now that everything is clear, I'd say go ahead and commit. Now in 4.4, 4.5 and trunk. -- regards MM ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org

Re: Do not force CMAKE_COLOR_MAKEFILE=ON

2010-06-27 Thread Andreas Pakulat
On 26.06.10 20:03:33, Maciej Mrozowski wrote: I'm going to commit the following, any objections? No way to actually disable colors when building KDE4 apps otherwise. Colors are enabled by default in CMake version we depend on. Just out of curiosity: Why do you need to explicitly disable

Re: Do not force CMAKE_COLOR_MAKEFILE=ON

2010-06-27 Thread Maciej Mrozowski
On Sunday 27 of June 2010 09:36:04 Andreas Pakulat wrote: On 26.06.10 20:03:33, Maciej Mrozowski wrote: I'm going to commit the following, any objections? No way to actually disable colors when building KDE4 apps otherwise. Colors are enabled by default in CMake version we depend on.

Re: Do not force CMAKE_COLOR_MAKEFILE=ON

2010-06-27 Thread Alexander Neundorf
On Sunday 27 June 2010, Maciej Mrozowski wrote: On Sunday 27 of June 2010 09:36:04 Andreas Pakulat wrote: On 26.06.10 20:03:33, Maciej Mrozowski wrote: I'm going to commit the following, any objections? No way to actually disable colors when building KDE4 apps otherwise. Colors are

Re: Do not force CMAKE_COLOR_MAKEFILE=ON

2010-06-27 Thread Maciej Mrozowski
On Sunday 27 of June 2010 22:30:14 Alexander Neundorf wrote: On Sunday 27 June 2010, Maciej Mrozowski wrote: On Sunday 27 of June 2010 09:36:04 Andreas Pakulat wrote: On 26.06.10 20:03:33, Maciej Mrozowski wrote: I'm going to commit the following, any objections? No way to actually

Do not force CMAKE_COLOR_MAKEFILE=ON

2010-06-26 Thread Maciej Mrozowski
I'm going to commit the following, any objections? No way to actually disable colors when building KDE4 apps otherwise. Colors are enabled by default in CMake version we depend on. Index: cmake/modules/KDE4Defaults.cmake === ---