Re: KDELibsDependencies.cmake problem (Re: KDE/kdebase/runtime/kioslave/smtp)

2006-10-18 Thread Dirk Mueller
On Wednesday 18 October 2006 07:50, Thiago Macieira wrote: Well, then we need to port -Wl,--as-needed over to CMake. it would also help in general, therefore being a good thing. Can you explain your reasoning? The reason is that the -Wl,--as-needed feature was lost by the switch to CMake,

Re: KDELibsDependencies.cmake problem (Re: KDE/kdebase/runtime/kioslave/smtp)

2006-10-18 Thread Alexander Neundorf
On Wednesday 18 October 2006 13:33, Dirk Mueller wrote: On Wednesday 18 October 2006 07:50, Thiago Macieira wrote: Well, then we need to port -Wl,--as-needed over to CMake. it would also help in general, therefore being a good thing. Can you explain your reasoning? The reason is that

Re: KDELibsDependencies.cmake problem (Re: KDE/kdebase/runtime/kioslave/smtp)

2006-10-18 Thread Thiago Macieira
Dirk Mueller wrote: I am building KDE with --as-needed and sometimes the build fails because indirect dependencies aren't found during link. Well, that can only be a bug. But given that I don't know where it fails, I can only guess. I believe it's a bug, yes, but I don't remember by heart

KDELibsDependencies.cmake problem (Re: KDE/kdebase/runtime/kioslave/smtp)

2006-10-17 Thread David Faure
On Tuesday 17 October 2006 13:35, Holger Freyther wrote: SVN commit 596397 by zecke: runtime/kioslave/smtp: Link to QtNetwork to fix link issues on OSX/Darwin M +1 -1 CMakeLists.txt --- trunk/KDE/kdebase/runtime/kioslave/smtp/CMakeLists.txt #596396:596397 @@ -90,7 +90,7 @@

Re: KDELibsDependencies.cmake problem (Re: KDE/kdebase/runtime/kioslave/smtp)

2006-10-17 Thread Thiago Macieira
David Faure wrote: How can we fix KDELibsDependencies.cmake to also include indirect dependencies? We shouldn't. Why should we care whether Qt links to Xrender? Or if libxslt uses libexpat? --   Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org     PGP/GPG: 0x6EF45358;

Re: KDELibsDependencies.cmake problem (Re: KDE/kdebase/runtime/kioslave/smtp)

2006-10-17 Thread David Faure
On Tuesday 17 October 2006 14:20, Thiago Macieira wrote: David Faure wrote: How can we fix KDELibsDependencies.cmake to also include indirect dependencies? We shouldn't. Why should we care whether Qt links to Xrender? Or if libxslt uses libexpat? Well, see the message I was replying to -

Re: KDELibsDependencies.cmake problem (Re: KDE/kdebase/runtime/kioslave/smtp)

2006-10-17 Thread Thiago Macieira
David Faure wrote: On Tuesday 17 October 2006 14:20, Thiago Macieira wrote: David Faure wrote: How can we fix KDELibsDependencies.cmake to also include indirect dependencies? We shouldn't. Why should we care whether Qt links to Xrender? Or if libxslt uses libexpat? Well, see the message I

Re: KDELibsDependencies.cmake problem (Re: KDE/kdebase/runtime/kioslave/smtp)

2006-10-17 Thread Thiago Macieira
David Faure wrote: I understand what you're saying - if it uses QtNetwork it should link directly to it and not via kdecore. I agree with this, conceptually. But the practical problem is that on Linux it all links just fine via kdecore, so the developers will never remember to add such explicit

Re: KDELibsDependencies.cmake problem (Re: KDE/kdebase/runtime/kioslave/smtp)

2006-10-17 Thread Dirk Mueller
On Tuesday, 17. October 2006 15:32, David Faure wrote: But the practical problem is that on Linux it all links just fine via kdecore, so the developers will never remember to add such explicit links, since it works for them (tm). So the guys doing Mac OS (and maybe Windows) porting will keep

Re: KDELibsDependencies.cmake problem (Re: KDE/kdebase/runtime/kioslave/smtp)

2006-10-17 Thread Thiago Macieira
Dirk Mueller wrote: On Tuesday, 17. October 2006 15:32, David Faure wrote: But the practical problem is that on Linux it all links just fine via kdecore, so the developers will never remember to add such explicit links, since it works for them (tm). So the guys doing Mac OS (and maybe Windows)