yesterday this change was made to kdelibs_export.h:
-#define KSPELL2_EXPORT KDE_EXPORT
+#define SONNET_EXPORT KDE_EXPORT
And this is still wrong!
-
kde4_add_library(sonnetcore SHARED ${sonnetbase_STAT_SRCS})
so it must be MAKE_SONNETCORE_LIB
once more recompiling whole kdelibs (but
Christian Ehrlicher said the following, On 2007-01-23 22:34:
Jacob R Rideout schrieb:
yesterday this change was made to kdelibs_export.h:
-#define KSPELL2_EXPORT KDE_EXPORT
+#define SONNET_EXPORT KDE_EXPORT
And this is still wrong!
-
kde4_add_library(sonnetcore SHARED
On Monday 22 January 2007 15:46, David Faure wrote:
That makes a LOT of extra files to install in kdelibs. I am not sure we
gain a big advantage by doing that.
I think modularity is always a huge advantage.
yesterday this change was made to kdelibs_export.h:
-#define KSPELL2_EXPORT
On Tuesday 23 January 2007 18:36, David Faure wrote:
On Monday 22 January 2007 15:46, David Faure wrote:
That makes a LOT of extra files to install in kdelibs. I am not sure we
gain a big advantage by doing that.
I think modularity is always a huge advantage.
yesterday this change was
David Faure schrieb:
On Monday 22 January 2007 15:46, David Faure wrote:
That makes a LOT of extra files to install in kdelibs. I am not sure we
gain a big advantage by doing that.
I think modularity is always a huge advantage.
yesterday this change was made to kdelibs_export.h:
-#define
David Faure schrieb:
On Tuesday 23 January 2007 19:16, Christian Ehrlicher wrote:
Alexander Neundorf schrieb:
On Tuesday 23 January 2007 18:36, David Faure wrote:
On Monday 22 January 2007 15:46, David Faure wrote:
That makes a LOT of extra files to install in kdelibs. I am not sure we
gain
On Tuesday 23 January 2007 19:56, Alexander Neundorf wrote:
On Tuesday 23 January 2007 19:52, Christian Ehrlicher wrote:
...
Then the new cmake command should look for kde_foo_export.h.cmake and
add the definitions instead creating an own header.
This would then be done everytime cmake
Christian Ehrlicher wrote:
kde4_add_library(sonnetcore SHARED ${sonnetbase_STAT_SRCS})
so it must be MAKE_SONNETCORE_LIB
I am changing that symbol to sonnetcore_EXPORTS instead. I asked here and
no one opposed...
I had all of kdelibs_export.h done... But if we're going to split -- and
now I
Thiago Macieira schrieb:
Christian Ehrlicher wrote:
kde4_add_library(sonnetcore SHARED ${sonnetbase_STAT_SRCS})
so it must be MAKE_SONNETCORE_LIB
I am changing that symbol to sonnetcore_EXPORTS instead. I asked here and
no one opposed...
How you name the export is not the problem - you
Christian Ehrlicher wrote:
And there is one more problem inside sonnet - some sources for
sonnetcore are also used for sonnetui (looks like an old convienence lib
for me) which breaks compilation on win32 too.
I'm going to make the build on 32-bit break on Unix too, if you do that
mistake.
I
Jacob R Rideout schrieb:
yesterday this change was made to kdelibs_export.h:
-#define KSPELL2_EXPORT KDE_EXPORT
+#define SONNET_EXPORT KDE_EXPORT
And this is still wrong!
-
kde4_add_library(sonnetcore SHARED ${sonnetbase_STAT_SRCS})
so it must be MAKE_SONNETCORE_LIB
once more
On Saturday 20 January 2007 12:21, Thiago Macieira wrote:
David Faure wrote:
Speaking of unneeded recompilations, can I suggest that we also split up
the export.h file into one-file-per-lib, like I did in koffice last
week? It also makes things more modular and easier to move when needed.
Christian Ehrlicher wrote:
Thiago Macieira schrieb:
I've noticed that CMake defines a macro called targetname_EXPORTS
for each module that is being built.
Would the Win32 guys oppose if I merged the two export headers into
one and used that macro instead?
Afaik the _win.h was just introduced
Thiago Macieira wrote:
I didn't know we had such a script. Patch is attached.
I don't think kdemacros.h has to be generated anymore. A static file
will do just fine. We can use Q_DECL_IMPORT and Q_DECL_EXPORT -- all I
have to do is convince the Trolls to move their definition to outside
the
14 matches
Mail list logo
