Re: Severe test regression in Kate?

2012-09-27 Thread Ben Cooksley
Hi all, I will be reverting commit cd8a8d6d3914ce8a72f252b054073193b97dd0a7 in kate in 24 hours unless a fix is provided. The issue it introduces, especially with php files is particularly disruptive to user workflow. (I don't understand exactly how a broken Javascript syntax file can affect PHP

Re: Severe test regression in Kate?

2012-09-27 Thread Dominik Haumann
Hi Ben, sorry for not answering immediately. On Thursday, 27. September 2012 17:28:48 Ben Cooksley wrote: Hi all, I will be reverting commit cd8a8d6d3914ce8a72f252b054073193b97dd0a7 in kate in 24 hours unless a fix is provided. The issue it introduces, especially with php files is

Re: Severe test regression in Kate?

2012-09-27 Thread Ben Cooksley
On Fri, Sep 28, 2012 at 7:35 AM, Eddy B. edy.b...@gmail.com wrote: Hi all, Hi Eddy, I'm sorry I didn't reply to this sooner, I didn't recognize that commit hash as being related to my patch - https://git.reviewboard.kde.org/r/106540/ I just tested this, and it seems a missing closing brace