Re: make KDE4_AUTOMOC compatible to qmake

2007-07-01 Thread Matthias Kretz
On Friday 29 June 2007, Alexander Neundorf wrote: On Thursday 28 June 2007 11:20, Matthias Kretz wrote: after that it seems to work, at least my stuff. Here's an error I didn't look into: Scanning dependencies of target globalcleanuptest [ 8%] Building CXX object

Re: make KDE4_AUTOMOC compatible to qmake

2007-07-01 Thread Matt Rogers
On Jul 1, 2007, at 3:19 PM, Matthias Kretz wrote: On Friday 29 June 2007, Alexander Neundorf wrote: On Thursday 28 June 2007 11:20, Matthias Kretz wrote: after that it seems to work, at least my stuff. Here's an error I didn't look into: Scanning dependencies of target globalcleanuptest

Re: make KDE4_AUTOMOC compatible to qmake

2007-06-27 Thread Matthias Kretz
On Wednesday 27 June 2007, Alexander Neundorf wrote: Could you maybe measure cmake times with the old and the new one with cold and warm caches ? Measuring is almost impossible. Using time cmake I get +/- 50% on total time. But here are the numbers: old automoc: without cache: 39.47s user

Re: make KDE4_AUTOMOC compatible to qmake

2007-06-27 Thread Alexander Neundorf
On Wednesday 27 June 2007 18:26, Matthias Kretz wrote: On Wednesday 27 June 2007, Alexander Neundorf wrote: Could you maybe measure cmake times with the old and the new one with cold and warm caches ? Measuring is almost impossible. Using time cmake I get +/- 50% on total time. But here

Re: make KDE4_AUTOMOC compatible to qmake

2007-06-26 Thread David Faure
On Friday 22 June 2007, Matthias Kretz wrote: Is it ok if I commit the KDE4Macros.cmake change to make the delayed automoc work? Or do you want to do it? Any showstoppers with it? Alex? I just committed my patch to kde4automoc.cmake to make the moc include qmake compatible there... Thanks

Re: make KDE4_AUTOMOC compatible to qmake

2007-06-26 Thread Thiago Macieira
David Faure wrote: On Tuesday 26 June 2007, Thiago Macieira wrote: Matthias Kretz wrote: don't have David's mail here for replying to it... but attached is a patch to create the .moc file from the .cpp file if the .cpp file matches ^\s*Q_OBJECT. For moc_foo.cpp files it always creates it

Re: make KDE4_AUTOMOC compatible to qmake

2007-06-26 Thread Thiago Macieira
David Faure wrote: On Tuesday 26 June 2007, Thiago Macieira wrote: David Faure wrote: Only *.moc files should be included. You're talking about qmake? I tested with foo.cpp including both moc_foo.cpp and foo.moc (when both foo.cpp and foo.h have a Q_OBJECT) and it worked fine. No, I'm

Re: make KDE4_AUTOMOC compatible to qmake

2007-06-22 Thread Matthias Kretz
Is it ok if I commit the KDE4Macros.cmake change to make the delayed automoc work? Or do you want to do it? Any showstoppers with it? I just committed my patch to kde4automoc.cmake to make the moc include qmake compatible there... --

Re: make KDE4_AUTOMOC compatible to qmake

2007-06-18 Thread Matthias Kretz
On Monday 18 June 2007, Alexander Neundorf wrote: On Saturday 16 June 2007 06:50, you wrote: On Tuesday 12 June 2007, Alexander Neundorf wrote: Hi, On Saturday 09 June 2007 05:20, Matthias Kretz wrote: On Saturday 09 June 2007, Alexander Neundorf wrote: On Friday 08 June 2007

Re: make KDE4_AUTOMOC compatible to qmake

2007-06-18 Thread Matthias Kretz
On Monday 18 June 2007, Alexander Neundorf wrote: So you didn't have any problems ? See kdepim/kresources/groupdav/CMakeLists.txt lines 17 and 48. It defines two different targets with the same target name. The same on lines 31 and 63. This results in the _automoc.files file to be overwritten

Re: make KDE4_AUTOMOC compatible to qmake

2007-06-18 Thread Alexander Neundorf
On Monday 18 June 2007 19:13, Matthias Kretz wrote: On Monday 18 June 2007, Alexander Neundorf wrote: So you didn't have any problems ? See kdepim/kresources/groupdav/CMakeLists.txt lines 17 and 48. It defines two different targets with the same target name. The same on lines 31 and 63.

Re: make KDE4_AUTOMOC compatible to qmake

2007-06-18 Thread Allen Winter
On Monday 18 June 2007 7:13:01 pm Matthias Kretz wrote: On Monday 18 June 2007, Alexander Neundorf wrote: So you didn't have any problems ? See kdepim/kresources/groupdav/CMakeLists.txt lines 17 and 48. It defines two different targets with the same target name. The same on lines 31 and

Re: make KDE4_AUTOMOC compatible to qmake

2007-06-17 Thread Alexander Neundorf
On Saturday 16 June 2007 06:50, you wrote: On Tuesday 12 June 2007, Alexander Neundorf wrote: Hi, On Saturday 09 June 2007 05:20, Matthias Kretz wrote: On Saturday 09 June 2007, Alexander Neundorf wrote: On Friday 08 June 2007 05:07, Matthias Kretz wrote: On Friday 08 June 2007,

Re: make KDE4_AUTOMOC compatible to qmake

2007-06-16 Thread Matthias Kretz
On Tuesday 12 June 2007, Alexander Neundorf wrote: Hi, On Saturday 09 June 2007 05:20, Matthias Kretz wrote: On Saturday 09 June 2007, Alexander Neundorf wrote: On Friday 08 June 2007 05:07, Matthias Kretz wrote: On Friday 08 June 2007, Alexander Neundorf wrote: Using

Re: make KDE4_AUTOMOC compatible to qmake

2007-06-12 Thread Alexander Neundorf
Hi, On Saturday 09 June 2007 05:20, Matthias Kretz wrote: On Saturday 09 June 2007, Alexander Neundorf wrote: On Friday 08 June 2007 05:07, Matthias Kretz wrote: On Friday 08 June 2007, Alexander Neundorf wrote: Using OBJECT_DEPENDS works more or less, but not 100%. :( Is this a

Re: make KDE4_AUTOMOC compatible to qmake

2007-06-10 Thread Manuel Klimek
Hi Alex, I think there is currently no way to tell cmake not to compile a file with a known extension. Even if this would be added for 2.4.7 or 2.4.8 it wouldn't help us since we require 2.4.5. this bug: http://www.cmake.org/Bug/bug.php?op=showbugid=3908pos=2 is fixed since 2.4.5. So you

Re: make KDE4_AUTOMOC compatible to qmake

2007-06-08 Thread Thiago Macieira
Alexander Neundorf said: IOW we have to stay with a non-source-file extension. Yep: *.moc for anything #included (this includes moc_*.moc, if needed) moc_*.cpp for anything that isn't #included (but has a Q_OBJECT nonetheless) -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT)

Re: make KDE4_AUTOMOC compatible to qmake

2007-06-08 Thread Matthias Kretz
On Friday 08 June 2007, Thiago Macieira wrote: Alexander Neundorf said: IOW we have to stay with a non-source-file extension. Yep: *.moc for anything #included (this includes moc_*.moc, if needed) moc_*.cpp for anything that isn't #included (but has a Q_OBJECT nonetheless) But

Re: make KDE4_AUTOMOC compatible to qmake

2007-06-07 Thread Matthias Kretz
Hi, I updated the patch so that it now adds a dependency on the moc generated file and does not add the moc files in the add_library/add_executable calls. Works fine with a clean build dir now, too. Please CC me as I'm not subscribed to this list. --

Re: make KDE4_AUTOMOC compatible to qmake

2007-06-07 Thread Christian Ehrlicher
Von: Matthias Kretz [EMAIL PROTECTED] Hi, I updated the patch so that it now adds a dependency on the moc generated file and does not add the moc files in the add_library/add_executable calls. Works fine with a clean build dir now, too. Afair we had a similar discussion short after we

Re: make KDE4_AUTOMOC compatible to qmake

2007-06-07 Thread Matthias Kretz
On Thursday 07 June 2007, Christian Ehrlicher wrote: Von: Matthias Kretz [EMAIL PROTECTED] Hi, I updated the patch so that it now adds a dependency on the moc generated file and does not add the moc files in the add_library/add_executable calls. Works fine with a clean build dir