Re: qt4 vs qt5 build for dependencies

2013-04-30 Thread David Faure
On Sunday 07 April 2013 12:26:38 Stephen Kelly wrote: David Faure wrote: Later on, when we're about to release KF5, we want to turn this around, i.e. make it easy to build things for Qt5, and if we still need qt4 support at that point, adding a -DQT4_BUILD=true (and dropping the QT5_BUILD

Re: qt4 vs qt5 build for dependencies

2013-04-14 Thread Stephen Kelly
Stephen Kelly wrote: Alexander Neundorf wrote: Is there a plan what to do with Qt5Transitional.cmake from e-c-m ? When qt5.git is updated, we can try to remove the use of it. I've done that now. In the process I used more imported target names for using Qt. I you don't like that, so if

Re: qt4 vs qt5 build for dependencies

2013-04-07 Thread Stephen Kelly
David Faure wrote: Later on, when we're about to release KF5, we want to turn this around, i.e. make it easy to build things for Qt5, and if we still need qt4 support at that point, adding a -DQT4_BUILD=true (and dropping the QT5_BUILD variable, obviously). I'd say skip adding the QT5_BUILD

Re: qt4 vs qt5 build for dependencies

2013-04-07 Thread Stephen Kelly
Alexander Neundorf wrote: Is there a plan what to do with Qt5Transitional.cmake from e-c-m ? When qt5.git is updated, we can try to remove the use of it. Thanks, Steve. ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org

Re: qt4 vs qt5 build for dependencies

2013-04-06 Thread Alexander Neundorf
On Friday 05 April 2013, Ben Cooksley wrote: On Fri, Apr 5, 2013 at 10:27 PM, David Faure faure+bluesyst...@kde.org wrote: When I ported attica, soprano, libdbusmenu-qt and other such kdesupport- level dependencies to Qt5, I used find_package(Qt5Core QUIET) if (Qt5Core_FOUND)

qt4 vs qt5 build for dependencies

2013-04-05 Thread David Faure
When I ported attica, soprano, libdbusmenu-qt and other such kdesupport- level dependencies to Qt5, I used find_package(Qt5Core QUIET) if (Qt5Core_FOUND) message(STATUS Building with Qt5 support) ... else() find_package(Qt4 REQUIRED) endif() i.e. use Qt5 if it's in the user's environment

Re: qt4 vs qt5 build for dependencies

2013-04-05 Thread Ben Cooksley
On Fri, Apr 5, 2013 at 10:27 PM, David Faure faure+bluesyst...@kde.org wrote: When I ported attica, soprano, libdbusmenu-qt and other such kdesupport- level dependencies to Qt5, I used find_package(Qt5Core QUIET) if (Qt5Core_FOUND) message(STATUS Building with Qt5 support) ... else()

Re: qt4 vs qt5 build for dependencies

2013-04-05 Thread Max Brazhnikov
On Fri, 05 Apr 2013 23:22:09 +1300 Ben Cooksley wrote: On Fri, Apr 5, 2013 at 10:27 PM, David Faure faure+bluesyst...@kde.org wrote: When I ported attica, soprano, libdbusmenu-qt and other such kdesupport- level dependencies to Qt5, I used find_package(Qt5Core QUIET) if