D24882: Don't set C/C++ standards if already set

dfaure closed this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24882 To: dfaure, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D24841: Use modern way to set the C/CXX standard

cgiboudeaux added a comment. Another issue caused by the new CMake 3.5 dependency, some tests fail: > > > 59 - ecm_setup_version-old_simple (Failed) > 60 - ecm_setup_version-old_soversion (Failed) > 61 - ecm_setup_version-old_version_file (Failed) > 62 -

D24841: Use modern way to set the C/CXX standard

vonreth added a comment. In D24841#552600 , @cgiboudeaux wrote: > Another issue caused by the new CMake 3.5 dependency, some tests fail: > > > > > > > 59 - ecm_setup_version-old_simple (Failed) > > 60 -

D24841: Use modern way to set the C/CXX standard

kossebau added a comment. In D24841#552842 , @vonreth wrote: > Where are those tests running? I'm only aware of https://build.kde.org/job/Frameworks/job/extra-cmake-modules/ The tests are currntly sadly skipped on CI, compare T11858

D24841: Use modern way to set the C/CXX standard

cgiboudeaux added a comment. I'm seeing build failures in several repositories seemingly caused by 6e3c794 (eg akonadi, kasync) Building with clang9, before: `-std=c++0x -std=gnu++14` are set After:

D24841: Use modern way to set the C/CXX standard

dfaure added a comment. Where did -std=gnu++14 come from? The old code above certainly didn't set it. Maybe some projects were doing `set(CMAKE_CXX_STANDARD 14)` before including KDECompilerSettings? We could test the var here to avoid overwriting it... REPOSITORY R240 Extra CMake

D24882: Don't set C/C++ standards if already set

dfaure created this revision. dfaure added a reviewer: cgiboudeaux. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY Fixes regression from

D24841: Use modern way to set the C/CXX standard

dfaure added a comment. Does https://phabricator.kde.org/D24882 help? (Not tested) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24841 To: vonreth, dfaure, cullmann Cc: cgiboudeaux, aacid, chehrlic, kde-frameworks-devel, kde-buildsystem, LeGast00n,

D24882: Don't set C/C++ standards if already set

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. Thanks! tested successfullly REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D24882 To: dfaure, cgiboudeaux Cc: