KDE/kdelibs/cmake/modules

2007-01-23 Thread Thiago Macieira
SVN commit 626619 by thiago: Add macro KDE4_ADD_TEST for unit test usage. This way, if you have CMake 2.4.4 or later, you don't need to turn on KDE4_BUILD_TESTS to be allowed to build tests: just cd into the tests dir and "make targetname". PS: it's time we bumped the minimum version requirement

KDE/kdelibs/cmake/modules

2007-01-23 Thread Alexander Neundorf
SVN commit 626609 by neundorf: add a macro KDE4_CREATE_EXPORTS_HEADER(fileName libName) which should create an exports header for the given lib This happen via configure_file() from the template file kde4exportsheader.h.in Is this ok this way ? Please let me know. Alex CCMAIL: kde-buildsystem@k

Re: Merging of kdelibs_export.h and kdelibs_export_win.h

2007-01-23 Thread Christian Ehrlicher
Jacob R Rideout schrieb: >> > yesterday this change was made to kdelibs_export.h: >> > -#define KSPELL2_EXPORT KDE_EXPORT >> > +#define SONNET_EXPORT KDE_EXPORT >> > >> And this is still wrong! >> -> >> kde4_add_library(sonnetcore SHARED ${sonnetbase_STAT_SRCS}) >> so it must be MAKE_SONNETCORE_LIB

Re: Merging of kdelibs_export.h and kdelibs_export_win.h

2007-01-23 Thread Thiago Macieira
Christian Ehrlicher wrote: >And there is one more problem inside sonnet - some sources for >sonnetcore are also used for sonnetui (looks like an old convienence lib >for me) which breaks compilation on win32 too. I'm going to make the build on 32-bit break on Unix too, if you do that mistake. I

Re: Merging of kdelibs_export.h and kdelibs_export_win.h

2007-01-23 Thread Christian Ehrlicher
Thiago Macieira schrieb: > Christian Ehrlicher wrote: >> kde4_add_library(sonnetcore SHARED ${sonnetbase_STAT_SRCS}) >> so it must be MAKE_SONNETCORE_LIB > > I am changing that symbol to sonnetcore_EXPORTS instead. I asked here and > no one opposed... > How you name the export is not the problem

Re: Merging of kdelibs_export.h and kdelibs_export_win.h

2007-01-23 Thread Thiago Macieira
Christian Ehrlicher wrote: >kde4_add_library(sonnetcore SHARED ${sonnetbase_STAT_SRCS}) >so it must be MAKE_SONNETCORE_LIB I am changing that symbol to sonnetcore_EXPORTS instead. I asked here and no one opposed... I had all of kdelibs_export.h done... But if we're going to split -- and now I t

Re: Merging of kdelibs_export.h and kdelibs_export_win.h

2007-01-23 Thread David Faure
On Tuesday 23 January 2007 19:56, Alexander Neundorf wrote: > On Tuesday 23 January 2007 19:52, Christian Ehrlicher wrote: > ... > > Then the new cmake command should look for kde_foo_export.h.cmake and > > add the definitions instead creating an own header. > > This would then be done everytime c

Re: Merging of kdelibs_export.h and kdelibs_export_win.h

2007-01-23 Thread Alexander Neundorf
On Tuesday 23 January 2007 19:52, Christian Ehrlicher wrote: ... > Then the new cmake command should look for kde_foo_export.h.cmake and > add the definitions instead creating an own header. This would then be done everytime cmake runs. Do we want this ? Bye Alex -- Work: alexander.neundorf AT j

Re: Merging of kdelibs_export.h and kdelibs_export_win.h

2007-01-23 Thread Christian Ehrlicher
David Faure schrieb: > On Tuesday 23 January 2007 19:16, Christian Ehrlicher wrote: >> Alexander Neundorf schrieb: >>> On Tuesday 23 January 2007 18:36, David Faure wrote: On Monday 22 January 2007 15:46, David Faure wrote: >> That makes a LOT of extra files to install in kdelibs. I am not

Re: Merging of kdelibs_export.h and kdelibs_export_win.h

2007-01-23 Thread David Faure
On Tuesday 23 January 2007 19:16, Christian Ehrlicher wrote: > Alexander Neundorf schrieb: > > On Tuesday 23 January 2007 18:36, David Faure wrote: > >> On Monday 22 January 2007 15:46, David Faure wrote: > That makes a LOT of extra files to install in kdelibs. I am not sure we > gain a b

Re: Merging of kdelibs_export.h and kdelibs_export_win.h

2007-01-23 Thread Christian Ehrlicher
Alexander Neundorf schrieb: > On Tuesday 23 January 2007 18:36, David Faure wrote: >> On Monday 22 January 2007 15:46, David Faure wrote: That makes a LOT of extra files to install in kdelibs. I am not sure we gain a big advantage by doing that. >>> I think modularity is always a huge adv

Re: Merging of kdelibs_export.h and kdelibs_export_win.h

2007-01-23 Thread Christian Ehrlicher
David Faure schrieb: > On Monday 22 January 2007 15:46, David Faure wrote: >>> That makes a LOT of extra files to install in kdelibs. I am not sure we >>> gain a big advantage by doing that. >> I think modularity is always a huge advantage. > > yesterday this change was made to kdelibs_export.h:

Re: Merging of kdelibs_export.h and kdelibs_export_win.h

2007-01-23 Thread Alexander Neundorf
On Tuesday 23 January 2007 18:36, David Faure wrote: > On Monday 22 January 2007 15:46, David Faure wrote: > > > That makes a LOT of extra files to install in kdelibs. I am not sure we > > > gain a big advantage by doing that. > > > > I think modularity is always a huge advantage. > > yesterday thi

Re: Merging of kdelibs_export.h and kdelibs_export_win.h

2007-01-23 Thread David Faure
On Monday 22 January 2007 15:46, David Faure wrote: > > > > That makes a LOT of extra files to install in kdelibs. I am not sure we > > gain a big advantage by doing that. > > I think modularity is always a huge advantage. yesterday this change was made to kdelibs_export.h: -#define KSPELL2_EX