FindPlasma.cmake obsolete ?

2009-01-04 Thread Alexander Neundorf
Hi, in kdelibs/cmake/modules/ there is a FindPlasma.cmake. But plasma has moved to kdelibs and is now found automatically by find_package(KDE4) which sets the appropriate variables like KDE4_PLASMA_LIBS etc. Before KDE 4.2 there were no compatibility guarantees for plasma, right ? So, where is

Re: FindPlasma.cmake obsolete ?

2009-01-04 Thread Allen Winter
On Sunday 04 January 2009 10:43:48 am Alexander Neundorf wrote: Hi, in kdelibs/cmake/modules/ there is a FindPlasma.cmake. But plasma has moved to kdelibs and is now found automatically by find_package(KDE4) which sets the appropriate variables like KDE4_PLASMA_LIBS etc. Before KDE 4.2

Re: FindPlasma.cmake obsolete ?

2009-01-04 Thread Modestas Vainius
Hello, sekmadienis 04 Sausis 2009, Alexander Neundorf rašė: in kdelibs/cmake/modules/ there is a FindPlasma.cmake. But plasma has moved to kdelibs and is now found automatically by find_package(KDE4) which sets the appropriate variables like KDE4_PLASMA_LIBS etc. Why do you want to make

Re: FindPlasma.cmake obsolete ?

2009-01-04 Thread Allen Winter
On Sunday 04 January 2009 12:49:31 pm Alexander Neundorf wrote: On Sunday 04 January 2009, Allen Winter wrote: On Sunday 04 January 2009 10:43:48 am Alexander Neundorf wrote: Hi, in kdelibs/cmake/modules/ there is a FindPlasma.cmake. But plasma has moved to kdelibs and is now

[PATCH] Tests for PyQt4 and PyKDE4 fail too noisy

2009-01-04 Thread Friedrich W. H. Kossebau
Hi, see $subject. Is the attached patch okay? I once did a similar patch to the variants in kdeutils/printer-applet/cmake-module (are they still needed?), but then I have no real clue what is going on in cmake files. Cheers Friedrich -- Okteta - KDE 4 Hex Editor -

Re: FindPlasma.cmake obsolete ?

2009-01-04 Thread Alexander Neundorf
On Sunday 04 January 2009, Allen Winter wrote: On Sunday 04 January 2009 10:43:48 am Alexander Neundorf wrote: Hi, in kdelibs/cmake/modules/ there is a FindPlasma.cmake. But plasma has moved to kdelibs and is now found automatically by find_package(KDE4) which sets the appropriate

Re: FindPlasma.cmake obsolete ?

2009-01-04 Thread Laurent Montel
On Sunday 04 January 2009 16:43:48 Alexander Neundorf wrote: Hi, in kdelibs/cmake/modules/ there is a FindPlasma.cmake. But plasma has moved to kdelibs and is now found automatically by find_package(KDE4) which sets the appropriate variables like KDE4_PLASMA_LIBS etc. Before KDE 4.2 there

Re: FindPlasma.cmake obsolete ?

2009-01-04 Thread Alexander Neundorf
On Sunday 04 January 2009, Modestas Vainius wrote: Hello, sekmadienis 04 Sausis 2009, Alexander Neundorf rašė: in kdelibs/cmake/modules/ there is a FindPlasma.cmake. But plasma has moved to kdelibs and is now found automatically by find_package(KDE4) which sets the appropriate

Re: FindPlasma.cmake obsolete ?

2009-01-04 Thread Alexander Neundorf
On Sunday 04 January 2009, Modestas Vainius wrote: Hello, sekmadienis 04 Sausis 2009, Alexander Neundorf rašė: Historically there was no plasma which was keeping any compatibility. Now it is part of kdelibs and the necessary variables (except the opengl one) are already set anyway by

Re: FindPlasma.cmake obsolete ?

2009-01-04 Thread Modestas Vainius
Hello, sekmadienis 04 Sausis 2009, Alexander Neundorf rašė: That it doesn't work now doesn't mean it never will. At least it won't for 4.2. We can try to support somewhat modular builds better for 4.3 FindPlasma.cmake in its current state doesn't help with this. Actually it does. Now you plan