Review Request 113805: Do not change the build types available with cmake

2013-11-11 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113805/ --- Review request for Build System and KDE Frameworks. Repository:

Re: Review Request 113805: Do not change the build types available with cmake

2013-11-11 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113805/#review43479 --- Ship it! Yes please. - Nicolás Alvarez On Nov. 11, 2013,

Re: Review Request 113805: Do not change the build types available with cmake

2013-11-11 Thread Aleix Pol Gonzalez
On Nov. 12, 2013, 12:02 a.m., Aleix Pol Gonzalez wrote: Maybe I've missed something, but I would like to have it explained somehow. Why is it bad to define such values? How will g++ calls compare? Nicolás Alvarez wrote: In normal CMake, -DCMAKE_BUILD_TYPE=Debug builds without