Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

2014-01-22 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115210/#review47983 --- Until now we had no problems with the data installed to

Re: Review Request 115099: This file provides the function ecm_generate_pri_file(). Make ECMSetupVersion set PROJECT_VERSION_*

2014-01-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115099/ --- (Updated Jan. 22, 2014, 9:21 a.m.) Review request for Build System,

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

2014-01-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/#review47996 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 22, 2014,

Re: Review Request 115099: This file provides the function ecm_generate_pri_file(). Make ECMSetupVersion set PROJECT_VERSION_*

2014-01-22 Thread Alex Merry
On Jan. 21, 2014, 11:02 p.m., Alex Merry wrote: modules/ECMGeneratePriFile.cmake, line 13 https://git.reviewboard.kde.org/r/115099/diff/1/?file=234571#file234571line13 I feel DEPS should really be a list, but CMake apparently doesn't have a join function, for some bizarre reason

Re: Review Request 115099: This file provides the function ecm_generate_pri_file(). Make ECMSetupVersion set PROJECT_VERSION_*

2014-01-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115099/#review48008 --- Ship it! Ship It! - Alex Merry On Jan. 22, 2014, 9:21

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

2014-01-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/#review48009 --- Ship it! This seems sensible to me; however, I do wonder if

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

2014-01-22 Thread Aleix Pol Gonzalez
On Jan. 22, 2014, 12:08 p.m., Alex Merry wrote: This seems sensible to me; however, I do wonder if ECM should also provide an ecm_mark_gui_executable function as well (I'm thinking of the case where most of the tests should be non-gui, but a handful want to display widgets). Well, we

Re: Review Request 115221: Allow to co-install kjs devel files along with kde4 devel files

2014-01-22 Thread Nicolas Lécureuil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115221/ --- (Updated Jan. 22, 2014, 12:32 p.m.) Review request for Build System, KDE

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

2014-01-22 Thread Aleix Pol Gonzalez
On Jan. 22, 2014, 12:08 p.m., Alex Merry wrote: This seems sensible to me; however, I do wonder if ECM should also provide an ecm_mark_gui_executable function as well (I'm thinking of the case where most of the tests should be non-gui, but a handful want to display widgets). Aleix

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

2014-01-22 Thread Alex Merry
On Jan. 22, 2014, 12:08 p.m., Alex Merry wrote: This seems sensible to me; however, I do wonder if ECM should also provide an ecm_mark_gui_executable function as well (I'm thinking of the case where most of the tests should be non-gui, but a handful want to display widgets). Aleix

Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

2014-01-22 Thread Alexander Richardson
On Jan. 22, 2014, 9:22 a.m., Patrick von Reth wrote: Until now we had no problems with the data installed to bin/../share and this setup would make it impossible to have multiple independent kde setups on one system. Alexander Richardson wrote: I know. The problem is

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

2014-01-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/#review48036 --- This review has been submitted with commit

Re: Review Request 115221: Allow to co-install kjs devel files along with kde4 devel files

2014-01-22 Thread Nicolas Lécureuil
On Jan. 22, 2014, 3:20 p.m., Michael Palimaka wrote: This is already handled by extra-cmake-modules, or am I missing something? maybe this is me that miss something, but i am using last ecm. - Nicolas --- This is an automatically

Re: Review Request 115221: Allow to co-install kjs devel files along with kde4 devel files

2014-01-22 Thread Michael Palimaka
On Jan. 22, 2014, 3:20 p.m., Michael Palimaka wrote: This is already handled by extra-cmake-modules, or am I missing something? Nicolas Lécureuil wrote: maybe this is me that miss something, but i am using last ecm. Here is the change, and it should be part of 0.0.9:

Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC

2014-01-22 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Re: Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC

2014-01-22 Thread Thiago Macieira
On quarta-feira, 22 de janeiro de 2014 11:02:55, Thiago Macieira wrote: Only set QT_STRICT_ITERATORS when not compiling with MSVC On MSVC linker errors will happen when this flag is set. Or I could apply a fix to Qt too. Fix submitted for review:

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

2014-01-22 Thread Nicolás Alvarez
On Jan. 22, 2014, 9:08 a.m., Alex Merry wrote: This seems sensible to me; however, I do wonder if ECM should also provide an ecm_mark_gui_executable function as well (I'm thinking of the case where most of the tests should be non-gui, but a handful want to display widgets). Aleix Pol