Re: Review Request 124104: Make it possible to use kconfig_compiler from different sources

2015-06-15 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124104/#review81501 --- +1 on the idea from me. I don't know CMake well, so I'd

Re: Review Request 124104: Make it possible to use kconfig_compiler from different sources

2015-06-15 Thread Aleix Pol Gonzalez
On June 16, 2015, 5:12 a.m., Matthew Dawson wrote: src/kconfig_compiler/CMakeLists.txt, line 16 https://git.reviewboard.kde.org/r/124104/diff/1/?file=380232#file380232line16 Does this mean a cross-compiled KConfig won't be built right for development on the target? If this

Re: Review Request 124104: Make it possible to use kconfig_compiler from different sources

2015-06-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124104/#review81500 --- +1 - David Edmundson On June 15, 2015, 5:59 p.m., Aleix

Review Request 124104: Make it possible to use kconfig_compiler from different sources

2015-06-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124104/ --- Review request for Build System, KDE Frameworks, Matthew Dawson, and

Review Request 124106: Improve error reporting of query_qmake macro

2015-06-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124106/ --- Review request for Extra Cmake Modules and Rohan Garg. Repository: