D5143: Introduce fetch-translations build command

apol created this revision. Restricted Application added projects: Frameworks, Build System. REVISION SUMMARY Makes it possible to fetch translations when building the project. To do so it fetches kde:releaseme and uses the new fetchpo.rb program to download the translations into the build

D5136: Introduce fetch-translations build command

apol added a comment. In https://phabricator.kde.org/D5136#96878, @aacid wrote: > I'm not sure addign a dependency for releaseme in ki18n is a good idea to be honest. > > This very "only works for KDE-based applications", a third-party using k18n has no interest in this at all. >

D5136: Introduce fetch-translations build command

kfunk added a comment. In https://phabricator.kde.org/D5136#96878, @aacid wrote: > I'm not sure addign a dependency for releaseme in ki18n is a good idea to be honest. > > This very "only works for KDE-based applications", a third-party using k18n has no interest in this at all. >

D5136: Introduce fetch-translations build command

aacid added a comment. I'm not sure addign a dependency for releaseme in ki18n is a good idea to be honest. This very "only works for KDE-based applications", a third-party using k18n has no interest in this at all. Maybe it would make more sense in some of the *KDE* files ECM has?

D5136: Introduce fetch-translations build command

apol marked 2 inline comments as done. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D5136 To: apol, #frameworks, #build_system, aacid, sitter, kfunk

D5136: Introduce fetch-translations build command

kfunk requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D5136 To: apol, #frameworks, #build_system, aacid, sitter, kfunk

D5136: Introduce fetch-translations build command

kfunk added inline comments. INLINE COMMENTS > KF5I18nConfig.cmake.in:12 > + > +execute_process(COMMAND git config --get remote.origin.url > +OUTPUT_VARIABLE reponame Can you delay that git invocation to when the custom target is executed? Otherwise we also pay for this whenever

D5136: Introduce fetch-translations build command

apol created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Makes it possible to fetch translations when building the project. To do so it fetches kde:releaseme and uses the new fetchpo.rb program to download the translations into the build directory.

D5136: Introduce fetch-translations build command

apol added a dependency: D5133: Introduce fetchpo.rb. apol added a comment. FWIW, depends on https://phabricator.kde.org/D5133 REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D5136 To: apol, #frameworks, #build_system, aacid, sitter, kfunk