D6773: Add API dox for KDEInstallDirs' KDE_INSTALL_USE_QT_SYS_PATHS

2017-07-18 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH adddoxforqtsyspaths REVISION DETAIL https://phabricator.kde.org/D6773 To: kossebau, #frameworks, apol Cc: #build_system

D6773: Add API dox for KDEInstallDirs' KDE_INSTALL_USE_QT_SYS_PATHS

2017-07-18 Thread Friedrich W . H . Kossebau
kossebau added a comment. Given the slightly complicated history of what KDE_INSTALL_USE_QT_SYS_PATHS does, I omitted a "since" on purpose for now. Would you agree it makes sense to simplify things be just adding "Since 5.22" and ignore previous behaviour? See also

D6772: Fix usage of query_qmake: differ between calls expecting qmake or not

2017-07-18 Thread Friedrich W . H . Kossebau
kossebau added a comment. See also https://phabricator.kde.org/D6773 for making the resulting behaviour documented. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6772 To: kossebau, #frameworks, ltoscano, rdieter Cc: #build_system

D6773: Add API dox for KDEInstallDirs' KDE_INSTALL_USE_QT_SYS_PATHS

2017-07-18 Thread Friedrich W . H . Kossebau
kossebau created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Build System. REPOSITORY R240 Extra CMake Modules BRANCH adddoxforqtsyspaths REVISION DETAIL https://phabricator.kde.org/D6773 AFFECTED FILES

D6772: Fix usage of query_qmake: differ between calls expecting qmake or not

2017-07-18 Thread Friedrich W . H . Kossebau
kossebau created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Build System. REVISION SUMMARY when KDE_INSTALL_USE_QT_SYS_PATHS has been explicitely set, qmake can be considered a required dependency, otherwise the

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

2017-07-18 Thread Allen Winter
winterz closed this revision. winterz added a comment. see https://phabricator.kde.org/R240:db46fb7c2fdcfbff5f8a0445e4d055cf4388ead8 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6762 To: winterz, skelly, #build_system, #windows, kfunk Cc: nalvarez,

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

2017-07-18 Thread Allen Winter
winterz added a comment. In https://phabricator.kde.org/D6762#126463, @nalvarez wrote: > Looks reasonable – although I wonder why on earth you're building KDE stuff on Cygwin... fun. as an experiment. i'm curious. REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

2017-07-18 Thread Kevin Funk
kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6762 To: winterz, skelly, #build_system, #windows, kfunk Cc: nalvarez, #frameworks, #build_system