D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

mlaurent added a comment. Seems ok for me REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D27150 To: kossebau, #build_system, #frameworks, broulik, mlaurent Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D27151: Use ecm_qt_install_logging_categories over manual categories file

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Seems ok for me. REPOSITORY R244 KCoreAddons BRANCH generateqtlogcatfile REVISION DETAIL https://phabricator.kde.org/D27151 To: kossebau, #build_system, #frameworks, broulik,

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a comment. See D27150 as an example next to the test and docs for how this would be used. The ecm_qt_export_logging_category also is kept similar to ecm_qt_declare_logging_category in case someone wants to turn the manual definition to a

D27151: Use ecm_qt_install_logging_categories over manual categories file

kossebau added a dependency: D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D27151 To: kossebau, #build_system, #frameworks, broulik, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2,

D27151: Use ecm_qt_install_logging_categories over manual categories file

kossebau created this revision. kossebau added reviewers: Build System, Frameworks, broulik, mlaurent. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. TEST PLAN Diff of generated file matches existing file, besides

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a dependent revision: D27151: Use ecm_qt_install_logging_categories over manual categories file. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D27150 To: kossebau, #build_system, #frameworks, broulik, mlaurent Cc: kde-frameworks-devel,

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added inline comments. INLINE COMMENTS > ECMQtDeclareLoggingCategory.cmake:76 > +# FILE > +# DESTINATION > +# [SORT] Why the need for explicit DESTINATION argument, where almost all use-cases will use ${KDE_INSTALL_LOGGINGCATEGORIESDIR}? Because

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau created this revision. kossebau added reviewers: Build System, Frameworks, broulik, mlaurent. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Having to