D27270: Use ecm_qt_install_logging_categories over manual categories files

2020-02-09 Thread Laurent Montel
mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R174 KContacts BRANCH generateqtlogcatfile REVISION DETAIL https://phabricator.kde.org/D27270 To: kossebau, #build_system, #frameworks, broulik, mlaurent Cc: kde-frameworks-devel, LeGast00n,

D27270: Use ecm_qt_install_logging_categories over manual categories files

2020-02-09 Thread Friedrich W. H. Kossebau
kossebau added a dependency: D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category. REPOSITORY R174 KContacts REVISION DETAIL https://phabricator.kde.org/D27270 To: kossebau, #build_system, #frameworks, broulik, mlaurent Cc: kde-frameworks-devel, LeGast00n, cblack,

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

2020-02-09 Thread Friedrich W. H. Kossebau
kossebau added a dependent revision: D27270: Use ecm_qt_install_logging_categories over manual categories files. REPOSITORY R240 Extra CMake Modules BRANCH addautomaticcategoriesgeneration REVISION DETAIL https://phabricator.kde.org/D27150 To: kossebau, #build_system, #frameworks,

D27270: Use ecm_qt_install_logging_categories over manual categories files

2020-02-09 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Build System, Frameworks, broulik, mlaurent. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. TEST PLAN Generated files match entries of existing manual

D27269: Use ecm_qt_install_logging_categories over manual categories file

2020-02-09 Thread Friedrich W. H. Kossebau
kossebau added a dependency: D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27269 To: kossebau, #build_system, #frameworks, broulik, mlaurent Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27269: Use ecm_qt_install_logging_categories over manual categories file

2020-02-09 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Build System, Frameworks, broulik, mlaurent. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. TEST PLAN Generated file matches entries of existing manual

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

2020-02-09 Thread Friedrich W. H. Kossebau
kossebau added a dependent revision: D27269: Use ecm_qt_install_logging_categories over manual categories file. REPOSITORY R240 Extra CMake Modules BRANCH addautomaticcategoriesgeneration REVISION DETAIL https://phabricator.kde.org/D27150 To: kossebau, #build_system, #frameworks,

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

2020-02-09 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 75312. kossebau added a comment. Add support for also generating renamecategories files REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27150?vs=75069=75312 BRANCH addautomaticcategoriesgeneration

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

2020-02-09 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D27150#608492 , @mlaurent wrote: > In D27150#608491 , @kossebau wrote: > > > In D27150#608318 , @mlaurent wrote: > > > >

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

2020-02-09 Thread Laurent Montel
mlaurent added a comment. In D27150#608491 , @kossebau wrote: > In D27150#608318 , @mlaurent wrote: > > > Yep you need to create a file name "foo.renamecategories" where you change the categorie

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

2020-02-09 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D27150#608318 , @mlaurent wrote: > Yep you need to create a file name "foo.renamecategories" where you change the categorie name > > 1. old module namenew module name > > for example "log_mailfilteragent

D8281: Allow to use IcoTool for Windows icons

2020-02-09 Thread Christoph Cullmann
cullmann commandeered this revision. cullmann added a reviewer: vpinon. cullmann added a comment. Herald edited subscribers, added: kde-buildsystem, kde-frameworks-devel; removed: Frameworks, Build System. I reviewed the current state and there is now already icotool support in our

D8281: Allow to use IcoTool for Windows icons

2020-02-09 Thread Christoph Cullmann
cullmann abandoned this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8281 To: cullmann, dfaure, apol, kfunk, #windows, vpinon Cc: kde-frameworks-devel, kde-buildsystem, cullmann, cgiboudeaux, LeGast00n, cblack, GB_2, bencreasy, michaelh,

D24568: Provide clang-format target with a KDE Frameworks style file

2020-02-09 Thread Christoph Cullmann
cullmann added a comment. In D24568#563653 , @cullmann wrote: > For the lambda issue, I think we can add: > > # keep lambda formatting multi-line if not empty > AllowShortLambdasOnASingleLine: Empty > > > see

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

2020-02-09 Thread Laurent Montel
mlaurent added a comment. Yep you need to create a file name "foo.renamecategories" where you change the categorie name old module namenew module name = for example "log_mailfilteragent org.kde.pim.mailfilteragent" in kmail What do you need