D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

2020-02-28 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D27150#619735 , @bruns wrote: > You have ommited to update the minimum ECM version in all cases AFAICS. Because that bump is done by the release scripts, and I did not want to mess with them. In general

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

2020-02-28 Thread Stefan Brüns
bruns added a comment. @kossebau - you have pushed commits depending on this change to several repositories, sometimes without waiting for acceptance, sometimes even bypassing Phabricator review completely. You have ommited to update the minimum ECM version in all cases AFAICS.

D27178: Use ecm_qt_install_logging_categories over manual categories file

2020-02-28 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > CMakeLists.txt:7 > include(FeatureSummary) > find_package(ECM 5.67.0 NO_MODULE) > set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake > Modules." URL "https://commits.kde.org/extra-cmake-modules;) Obviously, this is no

D27269: Use ecm_qt_install_logging_categories over manual categories file

2020-02-28 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > CMakeLists.txt:9 > include(FeatureSummary) > find_package(ECM 5.67.0 NO_MODULE) > set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake > Modules." URL "https://commits.kde.org/extra-cmake-modules;) Obviously, this is no