kossebau added a dependent revision: D21356: Port to ECMAddQmlModule, add
plugins.qmltypes files.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D20984
To: kossebau, #plasma, apol
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy,
kossebau added a dependent revision: D21344: Port to ECMAddQmlModule.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D20984
To: kossebau, #plasma, apol
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy,
michaelh, ngraham, bruns
kossebau abandoned this revision.
kossebau added a comment.
@apol Thanks again for your review work.
I am still a bit unsure about the usefulness and completeness of this macro,
even more as I would not call myself a QML expert who has seen all corners. And
given the lack of feedback
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
BRANCH
addinstallqmlplugin
REVISION DETAIL
https://phabricator.kde.org/D20984
To: kossebau, #plasma, apol
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n,
kossebau updated this revision to Diff 59700.
kossebau added a comment.
- add options to take identifiers/type names from file base names
- add option to specify version suffix to install path
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
kossebau retitled this revision from "Add ECMInstallQmlModules, with
ecm_install_qmlplugin as start" to "Add ECMAddQmlModule".
kossebau edited the summary of this revision.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D20984
To: kossebau, #plasma
Cc:
