D21381: use org.freedesktop.appstream-glib package to validate appstream data

mgallien abandoned this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21381 To: mgallien, aacid, yurchor, apol Cc: bcooksley, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D21381: use org.freedesktop.appstream-glib package to validate appstream data

mgallien added a comment. In D21381#469617 , @apol wrote: > How about we test against both? I have just pushed a new diff to do that. I am not sure if it desirable to keep appstreamcli test given it fails to validate files that are

D21381: use org.freedesktop.appstream-glib package to validate appstream data

mgallien updated this revision to Diff 58628. mgallien added a comment. - use appstream-util and appstreamcli to validate appdata file REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21381?vs=58595=58628 BRANCH master REVISION DETAIL

D21381: use org.freedesktop.appstream-glib package to validate appstream data

bcooksley added a comment. Aleix is correct, Flatpak commands are not possible within the CI environment (as Docker is heavily locked down, and the containerisation and other isolation measures that Flatpak tries to take are locked out as a consequence) Not to mention that Flatpak is Linux

D21381: use org.freedesktop.appstream-glib package to validate appstream data

apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. How about we test against both? And maybe it should be using `appstream-util validate` instead of forcing it through flatpak? It will make it easier to be able to run it in

D21381: use org.freedesktop.appstream-glib package to validate appstream data

ngraham added a reviewer: apol. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21381 To: mgallien, aacid, yurchor, apol Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D21381: use org.freedesktop.appstream-glib package to validate appstream data

mgallien created this revision. mgallien added reviewers: aacid, yurchor. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. mgallien requested review of this revision. REVISION SUMMARY should help having the same validation than