D24159: new module ECMSourceVersionControl

This revision was automatically updated to reflect the committed changes. Closed by commit R240:f3f4893b5bd2: new module ECMSourceVersionControl (authored by sitter). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24159?vs=4=67114 REVISION

D24159: new module ECMSourceVersionControl

apol added a comment. +1 REPOSITORY R240 Extra CMake Modules BRANCH vcs REVISION DETAIL https://phabricator.kde.org/D24159 To: sitter, kde-buildsystem, dfaure Cc: apol, kossebau, kde-frameworks-devel, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D24159: new module ECMSourceVersionControl

kossebau added a comment. In D24159#536388 , @kossebau wrote: > Should the new module be part of public ECM macros? Then it misses a documentation linking file `docs/module/ECMSourceVersionControl.rst` I am blind, ignore me. REPOSITORY

D24159: new module ECMSourceVersionControl

kossebau added a comment. Should the new module be part of public ECM macros? Then it misses a documentation linking file `docs/module/ECMSourceVersionControl.rst` Would be also good to have this variable being set mentioned in KDECompilerSettings, unless this is also not under public

D24159: new module ECMSourceVersionControl

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH vcs REVISION DETAIL https://phabricator.kde.org/D24159 To: sitter, kde-buildsystem, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, bencreasy, michaelh, ngraham,

D24159: new module ECMSourceVersionControl

sitter created this revision. sitter added reviewers: kde-buildsystem, dfaure. Herald added projects: Frameworks, Build System. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY simply sets a variable when the source is under version