This revision was automatically updated to reflect the committed changes.
Closed by commit R237:215986603c0f: Allow to also pass a target instead of list
of sources to KCONFIG_ADD_KCFG_FILES (authored by davidre).
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
davidre updated this revision to Diff 73455.
davidre marked an inline comment as done.
davidre added a comment.
target_or_source_var
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26626?vs=73410=73455
BRANCH
target (branched from master)
REVISION
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Makes sense, thanks David!
Please address kossebau's comments before landing.
REPOSITORY
R237 KConfig
BRANCH
target (branched from master)
REVISION DETAIL
davidre added a subscriber: kossebau.
davidre added a comment.
Sorry for removing you, I had accidentally opened the change subscribers
lineedit
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D26626
To: davidre, #frameworks, #build_system
Cc: kossebau,
davidre removed a subscriber: kossebau.
davidre added a comment.
For context as I'm not very proficient in CMake this is mostly a copy of
https://phabricator.kde.org/D22698
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D26626
To: davidre, #frameworks,
kossebau added a comment.
While touching this file, you might want to fix this file and make it
self-contained by also having a `include(CMakeParseArguments)` at the begin,
could be done as direct commit, no review needed IMHO :)
No comment on the actual new method API, I yet have to
davidre added reviewers: Frameworks, Build System.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D26626
To: davidre, #frameworks, #build_system
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
