D29096: Prefix includes and libs dir with QT_SYSROOT

ablu abandoned this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29096 To: ablu, #build_system, apol, vkrause, kfunk Cc: dfaure, kossebau, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh, ngraham, bruns

D29096: Prefix includes and libs dir with QT_SYSROOT

ablu added a comment. Ah, right. If you are using a normal sysroot for system libs, but conan for some libs then it makes sense! REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29096 To: ablu, #build_system, apol, vkrause, kfunk Cc: dfaure, kossebau,

D29096: Prefix includes and libs dir with QT_SYSROOT

dfaure added a comment. I'm using conan, not doing cross compilation. But with relative paths it's no problem, both use cases work. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29096 To: ablu, #build_system, apol, vkrause, kfunk Cc: dfaure,

D29096: Prefix includes and libs dir with QT_SYSROOT

ablu added a comment. Sure! Though... How does it come that you do not have SYSROOT set in your case? Won't that break in other cases? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29096 To: ablu, #build_system, apol, vkrause, kfunk Cc: dfaure,

D29096: Prefix includes and libs dir with QT_SYSROOT

dfaure added a comment. Thanks for the quick test! I'll indeed proceed with the other one, which is more generic (our use case isn't related to QT_SYSROOT). Actually: can you add your comment (that it works for you) in the other review request, so people know it's been tested by

D29096: Prefix includes and libs dir with QT_SYSROOT

ablu added a comment. looks good! yours is probably a bit more "CMakeish"! So feel free to continue with that one and close this. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29096 To: ablu, #build_system, apol, vkrause, kfunk Cc: dfaure, kossebau,

D29096: Prefix includes and libs dir with QT_SYSROOT

ablu added a comment. Hi @dfaure. It looks pretty much the same and I think it should work for us. I will kick off a build to confirm. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29096 To: ablu, #build_system, apol, vkrause, kfunk Cc: dfaure,

D29096: Prefix includes and libs dir with QT_SYSROOT

dfaure added a comment. Hi @ablu, Could you test if my patch in D29274 solves your problem? By making these lines relative to the location of the .pri file, it should work very well in a sysroot context as well. REPOSITORY R240 Extra CMake Modules

D29096: Prefix includes and libs dir with QT_SYSROOT

ablu added a comment. > Not having done much cross-compilation-library-setups naively I would have thought that when building a library which uses ECMGeneratePriFile and preparing it for cross-compilation, the installation prefix would be hardcoded into the generated artifacts.. Seems that

D29096: Prefix includes and libs dir with QT_SYSROOT

kossebau added reviewers: Build System, apol, vkrause, kfunk. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29096 To: ablu, #build_system, apol, vkrause, kfunk Cc: kossebau, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh,

D29096: Prefix includes and libs dir with QT_SYSROOT

kossebau added a comment. Thanks for the explanation, fear though I am missing some details and thus have not yet understood the problem and the solution. Not having done much cross-compilation-library-setups naively I would have thought that when building a library which uses

D29096: Prefix includes and libs dir with QT_SYSROOT

ablu added a comment. The SYSROOT variable should not (directly) impact that. The install directory is configured by ECM_MKSPECS_INSTALL_DIR, which usually will point to /usr/lib/mkspecs/modules/ on Linux. For a cross-compile toolchain it will however be additionally prefixed with separate

D29096: Prefix includes and libs dir with QT_SYSROOT

kossebau added a comment. No current clue about qmake, just wondering from my little knowledge: how does having $$[QT_SYSROOT] here influence any QMAKEPATH env var set? Would pri files installed into a custom prefix still be found? REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D29096: Prefix includes and libs dir with QT_SYSROOT

ablu created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. ablu requested review of this revision. REVISION SUMMARY If this is not done a cross compilation will attempt to load headers and libs from /usr/