D8256: Add _XOPEN_SOURCE to C definitions

mpyne added a comment. Sorry, if I'd been able to check this earlier I'd have warned against pushing, this was the kind of concern I was addressing with my earlier comment about FreeBSD. I had run into a lot of those issues when trying to get KF5 to build on Alpine. Adding an

D8256: Add _XOPEN_SOURCE to C definitions

dfaure added a comment. Indeed, 22:23:51 In file included from /usr/include/sys/mount.h:36: 22:23:51 /usr/include/sys/ucred.h:84:2: error: unknown type name 'u_int'; did you mean 'uint'? 22:23:51 u_int cr_version; /* structure layout version */ 22:23:51

D8256: Add _XOPEN_SOURCE to C definitions

bcooksley added subscribers: FreeBSD, bcooksley. bcooksley added a comment. This change appears to have resulted in a severe regression of builds on FreeBSD. Any ideas? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8256 To: awilcox, alexmerry,

D8256: Add _XOPEN_SOURCE to C definitions

This revision was automatically updated to reflect the committed changes. Closed by commit R240:6684cb99bdf4: Add _XOPEN_SOURCE to C definitions (authored by awilcox, committed by dfaure). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D8256: Add _XOPEN_SOURCE to C definitions

dfaure added a comment. Ah, found it in bugzilla :-) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8256 To: awilcox, alexmerry, dfaure Cc: kde-frameworks-devel, kde-buildsystem, mpyne, dfaure, michaelh, ngraham, bruns

D8256: Add _XOPEN_SOURCE to C definitions

dfaure added a comment. Let's push this then ;) You don't seem to have a developer account? I can push this but I need your email address for the git authorship. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8256 To: awilcox, alexmerry, dfaure

D8256: Add _XOPEN_SOURCE to C definitions

awilcox added a comment. rindex was being used in kscreenlocker but that code was removed last year. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8256 To: awilcox, alexmerry, dfaure Cc: kde-frameworks-devel, kde-buildsystem, mpyne, dfaure, michaelh,

D8256: Add _XOPEN_SOURCE to C definitions

dfaure added a comment. Restricted Application edited subscribers, added: kde-buildsystem, kde-frameworks-devel; removed: Frameworks, Build System. (BTW where is rindex being used? lxr says only in ksysguard's FreeBSD and IRIX files, surely that's not the issue?) REPOSITORY R240 Extra

D8256: Add _XOPEN_SOURCE to C definitions

mpyne added a comment. As I mentioned on the KDE bug, there is a possibility that changes like this would break FreeBSD. FreeBSD operates by a model of exporting symbols by default for legacy/BSD-specific needs. However if a feature flag is set, it limits its exports to *only* that

D8256: Add _XOPEN_SOURCE to C definitions

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I did a test compile with this locally and it seems fine indeed. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8256 To: awilcox, alexmerry, dfaure

D8256: Add _XOPEN_SOURCE to C definitions

awilcox added a comment. Please do note that `_XOPEN_SOURCE` must be `600` and not `700` because some components of KDE still use `rindex` which is no longer supported in X/Open 7 . REPOSITORY R240 Extra CMake

D8256: Add _XOPEN_SOURCE to C definitions

awilcox created this revision. awilcox added a reviewer: alexmerry. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY (This was reported on the KDE bug tracker as Bug 373175