Re: Review Request 119798: Generating PkgConfig files from ECM

2014-09-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/ --- (Updated Sept. 10, 2014, 8:08 a.m.) Status -- This change has been

Re: Review Request 119798: Generating PkgConfig files from ECM

2014-09-09 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/#review66143 --- Ship it! Ship It! - Alex Merry On Sept. 7, 2014, 7:57

Re: Review Request 119798: Generating PkgConfig files from ECM

2014-09-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/ --- (Updated Sept. 7, 2014, 7:57 a.m.) Review request for Build System, KDE

Re: Review Request 119798: Generating PkgConfig files from ECM

2014-09-05 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/#review65841 --- Sorry to still be nitpicking documentation, but I view it as

Re: Review Request 119798: Generating PkgConfig files from ECM

2014-09-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/ --- (Updated Sept. 3, 2014, 10:53 a.m.) Review request for Build System, KDE

Re: Review Request 119798: Generating PkgConfig files from ECM

2014-09-02 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/#review65735 --- OK, just some documentation cleanups, then I think we're good

Re: Review Request 119798: Generating PkgConfig files from ECM

2014-09-01 Thread Aleix Pol Gonzalez
On Aug. 29, 2014, 9:13 p.m., Alex Merry wrote: modules/ECMGeneratePkgConfigFile.cmake, lines 144-147 https://git.reviewboard.kde.org/r/119798/diff/4/?file=307659#file307659line144 Hmm... I wonder what happens if you have multiple calls in the same project with different

Re: Review Request 119798: Generating PkgConfig files from ECM

2014-09-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/ --- (Updated Sept. 1, 2014, 1:53 p.m.) Review request for Build System, KDE

Re: Review Request 119798: Generating PkgConfig files from ECM

2014-08-29 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/#review65528 --- modules/ECMGeneratePkgConfigFile.cmake

Re: Review Request 119798: Generating PkgConfig files from ECM

2014-08-26 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/ --- (Updated Aug. 26, 2014, 11:51 a.m.) Review request for Build System, KDE

Re: Review Request 119798: Generating PkgConfig files from ECM

2014-08-19 Thread Alex Merry
On Aug. 15, 2014, 8:20 a.m., Alex Merry wrote: modules/ECMGeneratePkgConfigFile.cmake, line 47 https://git.reviewboard.kde.org/r/119798/diff/1/?file=305638#file305638line47 This belongs in KDEInstallDirs.cmake, not here (as CMAKE_INSTALL_PKGCONFIGDIR, ideally). Projects that