D7094: Include a module for finding qml imports as runtime dependencies

2017-08-09 Thread Harald Sitter
sitter added inline comments. INLINE COMMENTS > apol wrote in ECMFindQMLModule.cmake.in:30 > Doing find_program for now. The right fix would be to change Qt to export the > `qmlplugindump` target. You still need to do "something" if qmlplugindump isn't found. Print a `message(WARNING` and/or `

D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing.

2017-08-09 Thread Christophe Giboudeaux
cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D7198 To: dfaure, cgiboudeaux Cc: #frameworks, #build_system

D7094: Include a module for finding qml imports as runtime dependencies

2017-08-09 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 17922. apol added a comment. if no qmlplugindump REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7094?vs=17911&id=17922 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7094 AFFECTED FILES mod

D7094: Include a module for finding qml imports as runtime dependencies

2017-08-09 Thread Harald Sitter
sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Oh it's gorgeous! REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D7094 To: apol, #build_system, #frameworks, sitter Cc: dfaure, aacid

D7094: Include a module for finding qml imports as runtime dependencies

2017-08-09 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R240:e5301edf1daf: Include a module for finding qml imports as runtime dependencies (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7094?v

D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing.

2017-08-09 Thread Kevin Funk
kfunk accepted this revision. kfunk added a comment. I like the initiative, +1 REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D7198 To: dfaure, cgiboudeaux, kfunk Cc: kfunk, #frameworks, #build_system

D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing.

2017-08-09 Thread David Faure
dfaure closed this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7198 To: dfaure, cgiboudeaux, kfunk Cc: kfunk, #frameworks, #build_system

D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing.

2017-08-09 Thread Albert Astals Cid
aacid added a comment. You broke all the builds REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7198 To: dfaure, cgiboudeaux, kfunk Cc: aacid, kfunk, #frameworks, #build_system

D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing.

2017-08-09 Thread Christophe Giboudeaux
cgiboudeaux added a comment. Fixed with https://phabricator.kde.org/R240:7e7b6da8c66b7ecf1c21f330c31ffe7975259498 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7198 To: dfaure, cgiboudeaux, kfunk Cc: aacid, kfunk, #frameworks, #build_system

D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing.

2017-08-09 Thread Christophe Giboudeaux
cgiboudeaux added a comment. In https://phabricator.kde.org/D7198#134234, @cgiboudeaux wrote: > Fixed with https://phabricator.kde.org/R240:7e7b6da8c66b7ecf1c21f330c31ffe7975259498 (+ https://phabricator.kde.org/R240:ef01c93637e1840ee701673970a371c011e36a40) REPOSITORY R240 Ext

D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing.

2017-08-09 Thread David Faure
dfaure added a comment. Ooops, sorry. I had heavily tested ... a somewhat different version of the patch :( Thanks for the fixes. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7198 To: dfaure, cgiboudeaux, kfunk Cc: aacid, kfunk, #frameworks, #bui