D7253: Add build-flatpak target if there is a flatpak recipe around

2017-08-11 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY If there is a `org.kde.*.json` file in the git repository of the cmake project, we assume is a flatpak re

D7253: Add build-flatpak target if there is a flatpak recipe around

2017-08-11 Thread Elvis Angelaccio
elvisangelaccio added reviewers: apol, Frameworks. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7253 To: elvisangelaccio, apol, #frameworks Cc: #frameworks, #build_system

D7253: Add build-flatpak target if there is a flatpak recipe around

2017-08-11 Thread Aleix Pol Gonzalez
apol added a comment. Interesting feature. I'm not opposed to it, but I have the feeling that it belongs to a different layer, so this means creating a build directory to call flatpak to call cmake. :P Also the arguments one passes to cmake won't have any effect on the flatpak. Wh

D7253: Add build-flatpak target if there is a flatpak recipe around

2017-08-11 Thread Elvis Angelaccio
elvisangelaccio added a comment. Main reason is having a simple way to run flatpak-builder with the proper arguments. Otherwise you have to copy-paste the command from somewhere (which could be error-prone). One usually already has a build folder around, so the idea is you change some code

D7253: Add build-flatpak target if there is a flatpak recipe around

2017-08-11 Thread Aleix Pol Gonzalez
apol added a comment. In https://phabricator.kde.org/D7253#134653, @elvisangelaccio wrote: > Main reason is having a simple way to run flatpak-builder with the proper arguments. Otherwise you have to copy-paste the command from somewhere (which could be error-prone). > One usually alr