D10759: Use QLocale instead of QLocale::system

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. I'm guessing that QLocale::default defaults to QLocale::system? REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D10759 To: aacid, apol Cc:

D10732: Help automoc to find metadata JSON files referenced in the code

kossebau updated this revision to Diff 27868. kossebau added a comment. have each macro added only once (closer to current draft of ECM macro) REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10732?vs=27751&id=27868 BRANCH useCMAKE_AUTOM

D10733: Help automoc to find metadata JSON files referenced in the code

kossebau updated this revision to Diff 27869. kossebau added a comment. have each macro added only once (closer to current draft of ECM macro) REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10733?vs=27752&id=27869 BRANCH useCMAKE_AUTOMOC_DEPEND_FILTERS

D10777: Define __ANDROID_API__

vkrause created this revision. vkrause added a reviewer: Build System. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Frameworks. vkrause requested review of this revision. REVISION SUMMARY This is needed for NDK headers to work correc

D10759: Use QLocale instead of QLocale::system

kossebau added a reviewer: ilic. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D10759 To: aacid, apol, ilic Cc: apol, #frameworks, #build_system, michaelh

D10759: Use QLocale instead of QLocale::system

kossebau added a comment. Might be an idea indeed to switch to default language instead of system one. Can you tell at which point the system one is estimated, and based on what? Grepping QLocale::system on lxr.kde.org

D10777: Define __ANDROID_API__

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. I've never seen these so I'm surprised. Good that you figured it out though :) Can you remove the comment above? REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL ht

D10759: Use QLocale instead of QLocale::system

aacid added a comment. there's a new revision of D10757 that shouldn't need this at all. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D10759 To: aacid, apol, ilic Cc: kossebau, apol, #frameworks, #b