D11984: Android: Explicitly point at upstream documentation and deprecate duplicated concepts

2018-04-11 Thread Volker Krause
vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Builds fine here, and moving closer to the Android cmake files makes sense IMHO. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D119

D11984: Android: Explicitly point at upstream documentation and deprecate duplicated concepts

2018-04-11 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R240:4baac2ecae1f: Android: Explicitly point at upstream documentation and deprecate duplicated… (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kd

D12120: Check if the application androiddeployqt package has a main() symbol

2018-04-11 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Frameworks, Build System. Restricted Application added projects: Frameworks, Build System. apol requested review of this revision. REVISION SUMMARY Back in the KDE Edu sprint, we decided we need such a check, otherwise you get rather frustrated

D12120: Check if the application androiddeployqt package has a main() symbol

2018-04-11 Thread Albert Astals Cid
aacid added a comment. Is this going to fail on my translated nm output? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D12120 To: apol, #frameworks, #build_system Cc: aacid, michaelh, ngraham, bruns

D12120: Check if the application androiddeployqt package has a main() symbol

2018-04-11 Thread Aleix Pol Gonzalez
apol added a comment. In D12120#244538 , @aacid wrote: > Is this going to fail on my translated nm output? Well it shouldn't, we're passing `LANG=C` which is what solved it for the other command, I don't see why nm should be any different

D12120: Check if the application androiddeployqt package has a main() symbol

2018-04-11 Thread BogDan Vatra
vatra added a comment. +1 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D12120 To: apol, #frameworks, #build_system Cc: vatra, aacid, michaelh, ngraham, bruns