D18960: Add compile check to FindEGL

This revision was automatically updated to reflect the committed changes. Closed by commit R240:0b47899c1b92: Add compile check to FindEGL (authored by hausmann). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18960?vs=51512=51574 REVISION DETAIL

D18952: new find module for Canberra

sitter added a comment. Good point, I've also noticed that (all?) our finders now also create an IMPORTED target. Should we maybe add that too? If so I guess `Canberra::Canberra` would be the preferred target name? REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D18952: new find module for Canberra

sitter updated this revision to Diff 51576. sitter added a comment. document in rst syntax REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18952?vs=51491=51576 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18952 AFFECTED

D18960: Add compile check to FindEGL

hausmann added a comment. Ooops. Could you paste the error from the cmake error output? I'm curious which part of the EGL compile test fails. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18960 To: hausmann, vkrause, apol Cc: tcberner, kossebau,

D18960: Add compile check to FindEGL

kossebau added a comment. Seems this is sadly breaking something for FreeBSD though, see https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/21/console REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18960 To: hausmann,

D18960: Add compile check to FindEGL

tcberner added a comment. In D18960#411562 , @kossebau wrote: > Seems this is sadly breaking something for FreeBSD though, see > https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/21/console I'll look into

D18983: Use the python version found by cmake in build_theme.sh

heikobecker created this revision. heikobecker added a reviewer: Build System. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY Helpful if one has multiple python3 versions around. TEST PLAN builds fine