Review Request: Fix Phonon lookup when compiling KDELibs

2011-09-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102681/ --- Review request for Build System and Alexander Neundorf. Summary ---

Review Request: properly pass the NOGUI flag

2012-07-29 Thread Aleix Pol Gonzalez
uses NOGUI there. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Review Request: Make kdepim-runtime configuration less verbose

2012-08-20 Thread Aleix Pol Gonzalez
, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request: Make kdepim-runtime configuration less verbose

2012-09-03 Thread Aleix Pol Gonzalez
p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106101/ --- (Updated Aug. 20, 2012, 3:22 p.m

Review Request 109404: Give more precedence to qmake executable names that specify the version

2013-03-10 Thread Aleix Pol Gonzalez
(KDE4) - Configuring such a project returns the correct versions. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 109404: Give more precedence to qmake executable names that specify the version

2013-03-10 Thread Aleix Pol Gonzalez
the correct versions. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 109404: Give more precedence to qmake executable names that specify the version

2013-03-10 Thread Aleix Pol Gonzalez
versions. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 109404: Give more precedence to qmake executable names that specify the version

2013-03-29 Thread Aleix Pol Gonzalez
versions. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Review Request 112451: Actually install the modules in the ecm attic

2013-09-02 Thread Aleix Pol Gonzalez
missing something. Please tell me if that's the case. Diffs - CMakeLists.txt 5a22f85 attic/modules/CMakeLists.txt c832bed Diff: http://git.reviewboard.kde.org/r/112451/diff/ Testing --- Installs and seems to work. Thanks, Aleix Pol Gonzalez

Re: Review Request 112451: Actually install the modules in the ecm attic

2013-09-02 Thread Aleix Pol Gonzalez
. To reply, visit: http://git.reviewboard.kde.org/r/112451/#review39177 --- On Sept. 2, 2013, 3:09 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail

Re: Review Request 112451: Actually install the modules in the ecm attic

2013-09-03 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/112451/diff/ Testing --- Installs and seems to work. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions

2013-09-04 Thread Aleix Pol Gonzalez
-modules/FindDocBookXSL.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112451/diff/ Testing --- Installs and seems to work. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman

Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions

2013-09-04 Thread Aleix Pol Gonzalez
. Diffs (updated) - attic/modules/FindDocBookXML.cmake 26053bf attic/modules/FindDocBookXSL.cmake ab93c9e Diff: http://git.reviewboard.kde.org/r/112451/diff/ Testing --- Installs and seems to work. Thanks, Aleix Pol Gonzalez

Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions

2013-09-04 Thread Aleix Pol Gonzalez
for KF5. Diffs (updated) - attic/modules/FindDocBookXML.cmake attic/modules/FindDocBookXSL.cmake Diff: http://git.reviewboard.kde.org/r/112451/diff/ Testing --- Installs and seems to work. Thanks, Aleix Pol Gonzalez ___ Kde

Re: Review Request 112525: Properly check for QtNetwork/QSslSocket

2013-09-04 Thread Aleix Pol Gonzalez
Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions

2013-09-04 Thread Aleix Pol Gonzalez
:50 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/ --- (Updated Sept. 4, 2013, 2:50 p.m

Re: Review Request 112525: Properly check for QtNetwork/QSslSocket

2013-09-05 Thread Aleix Pol Gonzalez
/112525/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions

2013-09-12 Thread Aleix Pol Gonzalez
Diff: http://git.reviewboard.kde.org/r/112697/diff/ Testing --- Still builds. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions

2013-09-12 Thread Aleix Pol Gonzalez
. To reply, visit: http://git.reviewboard.kde.org/r/112697/#review39918 --- On Sept. 12, 2013, 5 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions

2013-09-13 Thread Aleix Pol Gonzalez
ff0feb0 tier2/kauth/src/CMakeLists.txt 31f0f9c tier2/kcrash/src/CMakeLists.txt f340acd Diff: http://git.reviewboard.kde.org/r/112697/diff/ Testing --- Still builds. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem

Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions

2013-09-13 Thread Aleix Pol Gonzalez
., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112697/ --- (Updated Sept. 13, 2013, 10:33 a.m

Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions

2013-09-13 Thread Aleix Pol Gonzalez
/CMakeLists.txt ff0feb0 tier2/kauth/src/CMakeLists.txt 31f0f9c tier2/kcrash/src/CMakeLists.txt f340acd Diff: http://git.reviewboard.kde.org/r/112697/diff/ Testing --- Still builds. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list

Review Request 112772: Create an ecm_mark_as_autotest macro

2013-09-17 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/112772/diff/ Testing --- Ported some tests in KF5, it worked. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 112772: Create an ecm_mark_as_autotest macro

2013-09-17 Thread Aleix Pol Gonzalez
, 12:35 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112772/ --- (Updated Sept. 17, 2013, 12:35

Re: Review Request 112772: Create an ecm_mark_as_autotest macro

2013-09-19 Thread Aleix Pol Gonzalez
the FRAMEWORK_NAME_UNIT_TESTS macros which are in every autotests directory: http://paste.kde.org/p11adaa09/ Could something like this be considered for ecm? If so I will add some documentation and create a review request for ecm. Aleix Pol Gonzalez wrote: Neundorf: well, the difference

Review Request 112901: Remove weird cmake indirections

2013-09-23 Thread Aleix Pol Gonzalez
/CMakeLists.txt 0cb281d staging/kemoticons/src/core/CMakeLists.txt f7fb463 staging/ktextwidgets/src/CMakeLists.txt 4787c10 Diff: http://git.reviewboard.kde.org/r/112901/diff/ Testing --- Everything still builds Thanks, Aleix Pol Gonzalez ___ Kde

Re: Review Request 112901: Remove weird cmake indirections

2013-09-24 Thread Aleix Pol Gonzalez
--- Everything still builds Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 112772: Create an ecm_mark_as_autotest macro

2013-10-03 Thread Aleix Pol Gonzalez
that at the moment is quite verbose. Diffs - modules/ECMMarkAsTest.cmake f1e53e4 Diff: http://git.reviewboard.kde.org/r/112772/diff/ Testing --- Ported some tests in KF5, it worked. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing

Review Request 113149: Make it easier to use frameworks linked by cmake macros

2013-10-07 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/113149/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 113149: Make it easier to use frameworks linked by cmake macros

2013-10-07 Thread Aleix Pol Gonzalez
/kinit/CMakeLists.txt 10c226c staging/kinit/KInitConfig.cmake PRE-CREATION tier2/kdoctools/CMakeLists.txt a74ef92 tier2/kdoctools/KDocToolsConfig.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113149/diff/ Testing --- Thanks, Aleix Pol Gonzalez

Re: Review Request 113149: Make it easier to use frameworks linked by cmake macros

2013-10-07 Thread Aleix Pol Gonzalez
/CMakeLists.txt 10c226c staging/kinit/KInitConfig.cmake PRE-CREATION tier2/kdoctools/CMakeLists.txt a74ef92 tier2/kdoctools/KDocToolsConfig.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113149/diff/ Testing --- Thanks, Aleix Pol Gonzalez

Re: Review Request 113149: Make it easier to use frameworks linked by cmake macros

2013-10-07 Thread Aleix Pol Gonzalez
/CMakeLists.txt 10c226c staging/kinit/KInitConfig.cmake PRE-CREATION tier2/kdoctools/CMakeLists.txt a74ef92 tier2/kdoctools/KDocToolsConfig.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113149/diff/ Testing --- Thanks, Aleix Pol Gonzalez

Review Request 113406: Add a macro to automatically generate forward headers

2013-10-23 Thread Aleix Pol Gonzalez
://paste.opensuse.org/90980400 Diffs - modules/ECMGenerateHeaders.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113406/diff/ Testing --- Ported KParts and still everything works. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem

Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-10-24 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/113406/diff/ Testing --- Ported KParts and still everything works. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-10-24 Thread Aleix Pol Gonzalez
--- On Oct. 24, 2013, 1:40 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406

Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-10-26 Thread Aleix Pol Gonzalez
On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote: modules/ECMGenerateHeaders.cmake, line 29 http://git.reviewboard.kde.org/r/113406/diff/2/?file=205462#file205462line29 This variable shouldn't be needed at all. Aleix Pol Gonzalez wrote: Variable? Or argument? Why? Stephen

Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-10-26 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/113406/diff/ Testing --- Ported KParts and still everything works. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-10-26 Thread Aleix Pol Gonzalez
everything works. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-10-28 Thread Aleix Pol Gonzalez
would change http://git.reviewboard.kde.org/media/uploaded/files/2013/10/29/43e2c958-9908-4249-9bb6-9395d91b5643__kf5-kparts-headers-test.patch Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org

Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-10-29 Thread Aleix Pol Gonzalez
(DIRECTORY) to install the generated files. Aleix Pol Gonzalez wrote: Why? Stephen Kelly wrote: I think it's better API. It's what all existing functions which generate headers do. Aleix Pol Gonzalez wrote: Then it's weird because we'll need to have a separate call

Re: Review Request 113805: Do not change the build types available with cmake

2013-11-11 Thread Aleix Pol Gonzalez
On Nov. 12, 2013, 12:02 a.m., Aleix Pol Gonzalez wrote: Maybe I've missed something, but I would like to have it explained somehow. Why is it bad to define such values? How will g++ calls compare? Nicolás Alvarez wrote: In normal CMake, -DCMAKE_BUILD_TYPE=Debug builds without

Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

2013-11-13 Thread Aleix Pol Gonzalez
On Nov. 12, 2013, 5:11 p.m., Aleix Pol Gonzalez wrote: CMakeLists.txt, line 18 http://git.reviewboard.kde.org/r/113506/diff/5/?file=211419#file211419line18 I don't think we want that, superbuild shouldn't be used after the splitting but the kde build script. We will need

Review Request 113887: Deprecate KDE4_* KAuth macros

2013-11-15 Thread Aleix Pol Gonzalez
/diff/ Testing --- Nothing stopped building. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 113863: Remove WINCE specific cmake code paths

2013-11-15 Thread Aleix Pol Gonzalez
. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 113887: Deprecate KDE4_* KAuth macros

2013-11-18 Thread Aleix Pol Gonzalez
/kde4support/cmake/modules/KDE4Macros.cmake 6a63e5e Diff: http://git.reviewboard.kde.org/r/113887/diff/ Testing --- Nothing stopped building. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org

Re: Review Request 113863: Remove WINCE specific cmake code paths

2013-11-18 Thread Aleix Pol Gonzalez
/CMakeLists.txt 4ef0a9b tier3/kio/src/CMakeLists.txt 3800e85 tier3/kprintutils/src/CMakeLists.txt da0b7d5 tier4/kde4support/src/CMakeLists.txt 9046c96 Diff: http://git.reviewboard.kde.org/r/113863/diff/ Testing --- still builds. Thanks, Aleix Pol Gonzalez

Re: Review Request 114450: Make the tests pass

2013-12-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114450/#review45687 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 14, 2013, 4

Re: Review Request 114502: KDE4_ENABLE_EXCEPTIONS = KDE_ENABLE_EXCEPTIONS

2013-12-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114502/#review45801 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On Dec. 16

Re: Review Request 114501: Rename KDE4_ENABLE_EXCEPTIONS to KDE_ENABLE_EXCEPTIONS

2013-12-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114501/#review45802 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 16, 2013, 5

Re: Review Request 114683: Clean up target_link_libraries for KF5Plasma

2013-12-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114683/#review46193 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 27, 2013

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

2014-01-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/#review47996 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 22, 2014

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

2014-01-22 Thread Aleix Pol Gonzalez
On Jan. 22, 2014, 12:08 p.m., Alex Merry wrote: This seems sensible to me; however, I do wonder if ECM should also provide an ecm_mark_gui_executable function as well (I'm thinking of the case where most of the tests should be non-gui, but a handful want to display widgets). Well, we

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

2014-01-22 Thread Aleix Pol Gonzalez
Pol Gonzalez wrote: Well, we can't change the default, can we? Alex Merry wrote: I don't understand what you mean. If we have a /mark as non gui/ function is because executables are /gui executables/ by default. Having an ecm_mark_gui_executable() would make this weird I'd say. (TBH

Re: Review Request 115362: Do not explicitly link against libc

2014-01-28 Thread Aleix Pol Gonzalez
really ugly to have -lc so +1 from me. - Aleix Pol Gonzalez On Jan. 28, 2014, 4:41 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115362

Re: Review Request 115477: Remove commands that just set variables to their defaults

2014-02-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115477/#review48995 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 4, 2014, 4

Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

2014-02-11 Thread Aleix Pol Gonzalez
it as a problem. This could break compilation on some projects other than KParts, will you be able to try the rest of the modules? Thanks for figuring it out! - Aleix Pol Gonzalez On Feb. 11, 2014, 10:15 p.m., David Faure wrote

Re: Review Request 115683: Install app desktop files to share/applications, not in a kde5 subdir

2014-02-11 Thread Aleix Pol Gonzalez
benefits of name-spacing the desktop files besides feeling different and special. :) - Aleix Pol Gonzalez On Feb. 11, 2014, 9:56 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 116598: Check versions for individual components of Wayland

2014-03-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116598/#review51912 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On March

Re: Review Request 116628: Avoid multiple warnings caused by CMake Policy 0026

2014-03-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116628/#review52236 --- Ship it! - Aleix Pol Gonzalez On March 6, 2014, 10:11 a.m

Re: Review Request 116650: Give unique names to the targets created by KDocToolsMacros.cmake

2014-03-10 Thread Aleix Pol Gonzalez
? Diffs - KF5DocToolsMacros.cmake 6567b67 Diff: https://git.reviewboard.kde.org/r/116650/diff/ Testing --- Now kde-runtime documentation builds. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https

Re: Review Request 116650: Give unique names to the targets created by KDocToolsMacros.cmake

2014-03-11 Thread Aleix Pol Gonzalez
any command and nothing depended on it. Am I missing something? Diffs (updated) - KF5DocToolsMacros.cmake 6567b67 Diff: https://git.reviewboard.kde.org/r/116650/diff/ Testing --- Now kde-runtime documentation builds. Thanks, Aleix Pol Gonzalez

Re: Review Request 116650: Give unique names to the targets created by KDocToolsMacros.cmake

2014-03-11 Thread Aleix Pol Gonzalez
Diff: https://git.reviewboard.kde.org/r/116650/diff/ Testing --- Now kde-runtime documentation builds. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 117490: Improve FindEGL.cmake

2014-04-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117490/#review55749 --- Ship it! Looks good to me too. +1 - Aleix Pol Gonzalez

Re: Review Request 117907: make documentation match new values in code

2014-04-30 Thread Aleix Pol Gonzalez
added variables as well... - Aleix Pol Gonzalez On April 30, 2014, 3:22 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117907

Re: Review Request 118048: Make the KF5_LIBEXEC_INSTALL_DIR default depend on LIBEXEC_INSTALL_DIR

2014-05-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118048/#review57568 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 8, 2014, 9

Re: Review Request 119067: give a warning if using invalid (typically old KDE 3) categories

2014-07-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119067/#review61406 --- Ship it! Ship It! - Aleix Pol Gonzalez On July 1, 2014, 4

Review Request 119798: Generating PkgConig files from ECM

2014-08-14 Thread Aleix Pol Gonzalez
/kde5/lib64 Cflags: -I/home/kde-devel/kde5/include/KF5/KCoreAddons Requires: Qt5Core Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 119798: Generating PkgConig files from ECM

2014-08-18 Thread Aleix Pol Gonzalez
, on my system: Name: KF5CoreAddons Version: 5.1.0 Libs: -L/home/kde-devel/kde5/lib64 -l/home/kde-devel/kde5/lib64 Cflags: -I/home/kde-devel/kde5/include/KF5/KCoreAddons Requires: Qt5Core Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde

Re: Review Request 119798: Generating PkgConig files from ECM

2014-08-19 Thread Aleix Pol Gonzalez
that don't use KDEInstallDirs can create their own variable. Also, pkconfig - pkgconfig. Aleix Pol Gonzalez wrote: I'm unsure about that, first ECM_MKSPECS_INSTALL_DIR is declared the same way (again, copypaste) then I understand that we can override the variable from

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

2014-08-25 Thread Aleix Pol Gonzalez
/CMake_Coding_Style#End_commands - Aleix Pol Gonzalez On Aug. 25, 2014, 6 p.m., Rohan Garg wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901

Re: Review Request 119798: Generating PkgConfig files from ECM

2014-08-26 Thread Aleix Pol Gonzalez
/KCoreAddons Requires: Qt5Core Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 119798: Generating PkgConfig files from ECM

2014-09-01 Thread Aleix Pol Gonzalez
. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/#review65528 --- On Aug. 26, 2014, 11:51 a.m., Aleix Pol Gonzalez wrote

Re: Review Request 119798: Generating PkgConfig files from ECM

2014-09-01 Thread Aleix Pol Gonzalez
${PRI_FILENAME} DESTINATION ${ECM_MKSPECS_INSTALL_DIR}) This is the result, on my system: Name: KF5CoreAddons Version: 5.1.0 Libs: -L/home/kde-devel/kde5/lib64 -l/home/kde-devel/kde5/lib64 Cflags: -I/home/kde-devel/kde5/include/KF5/KCoreAddons Requires: Qt5Core Thanks, Aleix Pol Gonzalez

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

2014-09-02 Thread Aleix Pol Gonzalez
Pol Gonzalez On Sept. 1, 2014, 10:24 a.m., Rohan Garg wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901

Re: Review Request 119798: Generating PkgConfig files from ECM

2014-09-03 Thread Aleix Pol Gonzalez
Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 119798: Generating PkgConfig files from ECM

2014-09-07 Thread Aleix Pol Gonzalez
${PRI_FILENAME} DESTINATION ${ECM_MKSPECS_INSTALL_DIR}) This is the result, on my system: Name: KF5CoreAddons Version: 5.1.0 Libs: -L/home/kde-devel/kde5/lib64 -l/home/kde-devel/kde5/lib64 Cflags: -I/home/kde-devel/kde5/include/KF5/KCoreAddons Requires: Qt5Core Thanks, Aleix Pol Gonzalez

Review Request 120118: Make code coverage possible in any KDE project

2014-09-09 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/120118/diff/ Testing --- Plasma Framework is already doing it, I just moved the code. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 119798: Generating PkgConfig files from ECM

2014-09-10 Thread Aleix Pol Gonzalez
Requires: Qt5Core Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 120118: Make code coverage possible in any KDE project

2014-09-10 Thread Aleix Pol Gonzalez
Framework is already doing it, I just moved the code. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 120118: Make code coverage possible in any KDE project

2014-09-11 Thread Aleix Pol Gonzalez
it locally, then too. Diffs - kde-modules/KDECompilerSettings.cmake f0d1aef modules/ECMCoverageOption.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120118/diff/ Testing --- Plasma Framework is already doing it, I just moved the code. Thanks, Aleix Pol Gonzalez

Re: Review Request 121448: Introduce ECMAddAppIcon.

2014-12-11 Thread Aleix Pol Gonzalez
reasonably easy to create ecm tests nowadays and very useful afterwards. You'll see some examples in the repository. By the way, thanks for looking into this, really needed! - Aleix Pol Gonzalez On Dec. 11, 2014, 3:40 p.m., Ralf Habacker wrote

Review Request 121545: Move the toolchain module to ECM

2014-12-15 Thread Aleix Pol Gonzalez
appreciated. Diffs - CMakeLists.txt 8356e2e toolchain/Android.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121545/diff/ Testing --- I've built KAlgebra with this, as well as some other test applications. Thanks, Aleix Pol Gonzalez

Re: Review Request 121545: Move Android toolchain module to ECM

2015-02-05 Thread Aleix Pol Gonzalez
. Diffs - CMakeLists.txt b230bb2 toolchain/Android.cmake PRE-CREATION toolchain/deployment-file.json.in PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121545/diff/ Testing --- I've built KAlgebra with this, as well as some other test applications. Thanks, Aleix Pol

Re: Review Request 121545: Move Android toolchain module to ECM

2015-01-14 Thread Aleix Pol Gonzalez
applications. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 121545: Move the toolchain module to ECM

2015-01-09 Thread Aleix Pol Gonzalez
. - Aleix Pol Gonzalez On Dec. 16, 2014, 1:51 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121545

Re: Review Request 121545: Move the toolchain module to ECM

2015-01-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121545/#review73657 --- On Dec. 16, 2014, 1:51 a.m., Aleix Pol Gonzalez wrote

Re: Review Request 121545: Move Android toolchain module to ECM

2015-01-13 Thread Aleix Pol Gonzalez
/121545/diff/ Testing --- I've built KAlgebra with this, as well as some other test applications. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

2015-04-24 Thread Aleix Pol Gonzalez
explaining that a test will be added with X name that will test whether the generated file works fine? - Aleix Pol Gonzalez On April 24, 2015, 4:53 p.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 124118: Make it possible to use KCoreAddons's desktoptojson in cross-compiled environments

2015-06-23 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/124104/ Diffs - CMakeLists.txt 552851d KF5CoreAddonsConfig.cmake.in caa1c0a autotests/CMakeLists.txt 51fcfb4 src/desktoptojson/CMakeLists.txt e6041cb Diff: https://git.reviewboard.kde.org/r/124118/diff/ Testing --- Thanks, Aleix Pol Gonzalez

Re: Review Request 124106: Improve error reporting of query_qmake macro

2015-06-23 Thread Aleix Pol Gonzalez
and the attempted call, to make sure we can react accordingly. Diffs - modules/ECMQueryQmake.cmake c880671 Diff: https://git.reviewboard.kde.org/r/124106/diff/ Testing --- I could fix the error I was finding. Thanks, Aleix Pol Gonzalez ___ Kde

Re: Review Request 124104: Make it possible to use kconfig_compiler from different sources

2015-06-24 Thread Aleix Pol Gonzalez
KF5ConfigConfig.cmake.in b4e5f56 src/kconfig_compiler/CMakeLists.txt ec4a733 Diff: https://git.reviewboard.kde.org/r/124104/diff/ Testing --- Works as expected on my debian chroot environment. Thanks, Aleix Pol Gonzalez ___ Kde

Re: Review Request 124118: Make it possible to use KCoreAddons's desktoptojson in cross-compiled environments

2015-06-18 Thread Aleix Pol Gonzalez
/CMakeLists.txt e6041cb Diff: https://git.reviewboard.kde.org/r/124118/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 124104: Make it possible to use kconfig_compiler from different sources

2015-06-20 Thread Aleix Pol Gonzalez
chroot environment. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 124104: Make it possible to use kconfig_compiler from different sources

2015-06-17 Thread Aleix Pol Gonzalez
frameworks. Diffs (updated) - CMakeLists.txt f510e3e KF5ConfigConfig.cmake.in b4e5f56 src/kconfig_compiler/CMakeLists.txt ec4a733 Diff: https://git.reviewboard.kde.org/r/124104/diff/ Testing --- Works as expected on my debian chroot environment. Thanks, Aleix Pol Gonzalez

Re: Review Request 124104: Make it possible to use kconfig_compiler from different sources

2015-06-15 Thread Aleix Pol Gonzalez
e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124104/#review81501 --- On June 15, 2015, 7:59 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e

Review Request 124104: Make it possible to use kconfig_compiler from different sources

2015-06-15 Thread Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/124104/diff/ Testing --- Works as expected on my debian chroot environment. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Review Request 124106: Improve error reporting of query_qmake macro

2015-06-15 Thread Aleix Pol Gonzalez
was finding. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 123874: Fix build with Qt = 5.4.2

2015-05-21 Thread Aleix Pol Gonzalez
... - Aleix Pol Gonzalez On May 21, 2015, 7:32 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123874

Re: Review Request 123874: Fix build with Qt = 5.4.2

2015-05-21 Thread Aleix Pol Gonzalez
On May 22, 2015, 12:57 a.m., Aleix Pol Gonzalez wrote: I'm unsure this is what you need, builds fine here... Hrvoje Senjan wrote: Do you have the mentioned commit? It's in latest 5.4.2 5.4 branches, but *not* 5.5 Ah, sorry, I have 5.5. Anyway, are you sure this is needed? Qt5

Re: Review Request 123437: FinKexiv2: Use FindPkgConfig instead of UsePkgConfig

2015-07-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123437/#review82594 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 13, 2015

  1   2   3   4   5   >