Re: Review Request 126711: ECMAddAppIcon: Use absolute path when operating on icons

2016-01-10 Thread Gleb Popov
git.reviewboard.kde.org/r/126711/#review90849 --- On Jan. 10, 2016, 11 p.m., Gleb Popov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126711/ > -

Re: Review Request 128112: New module: ecm_win_resolve_symlinks

2016-06-07 Thread Gleb Popov
-CREATION Diff: https://git.reviewboard.kde.org/r/128112/diff/ Testing --- Thanks, Gleb Popov ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 128112: New module: ecm_win_resolve_symlinks

2016-06-08 Thread Gleb Popov
automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128112/#review96294 --- On June 8, 2016, 8:08 a.m., Gleb Popov wrote: > > ---

Review Request 128112: New module: ecm_win_resolve_symlinks

2016-06-06 Thread Gleb Popov
. This macro is intended to fix that. There is some room for performance improvement, but i wanted to get the feedback early. Diffs - modules/ECMWinResolveSymlinks.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/128112/diff/ Testing --- Thanks, Gleb Popov

Review Request 126711: ECMAddAppIcon: Use absolute path when operating on icons

2016-01-10 Thread Gleb Popov
, Gleb Popov ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 126711: ECMAddAppIcon: Use absolute path when operating on icons

2016-01-13 Thread Gleb Popov
/ECMAddAppIconTest/check_files.cmake.in PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126711/diff/ Testing --- Built KDevelop on Windows, the icon is here. Thanks, Gleb Popov ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https

Re: Review Request 128112: New module: ecm_win_resolve_symlinks

2016-06-17 Thread Gleb Popov
://git.reviewboard.kde.org/r/128112/diff/ Testing --- Thanks, Gleb Popov ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 126711: ECMAddAppIcon: Use absolute path when operating on icons

2016-01-31 Thread Gleb Popov
marked as submitted. Review request for Extra Cmake Modules and Kevin Funk. Changes --- Submitted with commit dde4ba04e57502f13955002d3ea3ae702c3e8c74 by Gleb Popov to branch master. Repository: extra-cmake-modules Description --- This makes it optional to list icons

Re: Review Request 126711: ECMAddAppIcon: Use absolute path when operating on icons

2016-01-19 Thread Gleb Popov
--- Built KDevelop on Windows, the icon is here. Thanks, Gleb Popov ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 126711: ECMAddAppIcon: Use absolute path when operating on icons

2016-01-26 Thread Gleb Popov
is here. Thanks, Gleb Popov ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 128779: Teach KDECompilerSettings about clang-cl, a mode of Clang compiler that simulates MSVC.

2017-02-04 Thread Gleb Popov
/r/128779/#review102364 --- On Oct. 12, 2016, 2:57 p.m., Gleb Popov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

Re: Review Request 128779: Teach KDECompilerSettings about clang-cl, a mode of Clang compiler that simulates MSVC.

2017-02-04 Thread Gleb Popov
> On Feb. 4, 2017, 2:05 p.m., Albert Astals Cid wrote: > > Patch doesn't apply anymore > > Gleb Popov wrote: > Is there any interest in this? > > Albert Astals Cid wrote: > To be honest I don't even understand what it does from the description :D > &

Re: Review Request 128779: Teach KDECompilerSettings about clang-cl, a mode of Clang compiler that simulates MSVC.

2016-09-30 Thread Gleb Popov
28779/diff/ Testing --- Thanks, Gleb Popov

Re: Review Request 128779: Teach KDECompilerSettings about clang-cl, a mode of Clang compiler that simulates MSVC.

2016-10-08 Thread Gleb Popov
marked as submitted. Review request for Extra Cmake Modules and kdewin. Changes --- Submitted with commit 4b8e8dcc8856d8f438860783e7641d02d1c05630 by Gleb Popov to branch master. Repository: extra-cmake-modules Description --- By simply using `if(CMAKE_COMPILER_ID STREQUAL "

Re: Review Request 128779: Teach KDECompilerSettings about clang-cl, a mode of Clang compiler that simulates MSVC.

2016-10-08 Thread Gleb Popov
ler=gcc/33/console - Gleb --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128779/#review99843 --- On Oct. 8, 2016,

Re: Review Request 128112: New module: ecm_win_resolve_symlinks

2016-09-21 Thread Gleb Popov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128112/#review99356 --- Bump. - Gleb Popov On June 17, 2016, 11:32 a.m., Gleb

Review Request 128779: Teach KDECompilerSettings about clang-cl, a mode of Clang compiler that simulates MSVC.

2016-08-27 Thread Gleb Popov
ems: `-std=gnu++98` flag is still appended, but i wasn't able to figure out why. Diffs - kde-modules/KDECompilerSettings.cmake 6cecefd kde-modules/KDEFrameworkCompilerSettings.cmake e41003d Diff: https://git.reviewboard.kde.org/r/128779/diff/ Testing --- Thanks, Gleb Popov

Re: Review Request 128112: New module: ecm_win_resolve_symlinks

2016-11-05 Thread Gleb Popov
marked as submitted. Review request for Extra Cmake Modules and KDE Frameworks. Changes --- Submitted with commit 632b8868de38e2f85fb4969bcae3dd89a2a0695c by Gleb Popov to branch master. Repository: extra-cmake-modules Description --- When git is checking out repositories with UNIX

Re: Review Request 128779: Teach KDECompilerSettings about clang-cl, a mode of Clang compiler that simulates MSVC.

2016-10-28 Thread Gleb Popov
> On Oct. 8, 2016, 12:09 p.m., Ben Cooksley wrote: > > This code as it stands failed on the CI system and proceeded to break all > > Frameworks builds. > > Please re-review the code and ensure that no action is taken for GCC based > > compilers. > > Gleb Popo

Re: Review Request 128779: Teach KDECompilerSettings about clang-cl, a mode of Clang compiler that simulates MSVC.

2016-10-12 Thread Gleb Popov
ded, but i wasn't able to figure out why. Diffs (updated) - kde-modules/KDECompilerSettings.cmake dfa29f7 kde-modules/KDEFrameworkCompilerSettings.cmake 038ddc3 Diff: https://git.reviewboard.kde.org/r/128779/diff/ Testing --- Thanks, Gleb Popov

Re: Review Request 128779: Teach KDECompilerSettings about clang-cl, a mode of Clang compiler that simulates MSVC.

2016-10-12 Thread Gleb Popov
---- On Oct. 12, 2016, 2:57 p.m., Gleb Popov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128779/ > -