Re: Phonon

On Thu, Mar 10, 2011 at 11:23 PM, Ben Cooksley bcooks...@kde.org wrote: Note that if I don't get a reply, I will be reverting commit 1602df28e8b82aeeecb7cfb3fe1af52790be02d3 to Phonon in 24 hours in order to restore my ability to build Phonon. We are working on a revert, just too much a hassle

Re: Phonon

On Sat, Mar 12, 2011 at 9:11 PM, Alexander Neundorf neund...@kde.org wrote: phonon-buildsystem is only used to build the backends. Applications should *not* be using the stuff in there. If they manage to find FindPhonon.cmake from phonon-buildsystem, the application's build has a bug. Our

Re: Phonon

Hullos, On Fri, Mar 11, 2011 at 6:28 PM, Alexander Neundorf neund...@kde.org wrote: On Thursday 10 March 2011, Ben Cooksley wrote: I have found recently that I cannot build KDE Runtime. In tracing this, I ended up with an obscure error: CMake Error at

Re: Phonon

On Mon, Mar 14, 2011 at 10:47 AM, Yury G. Kudryashov ur...@ya.ru wrote: Harald Sitter wrote: On Sat, Mar 12, 2011 at 9:11 PM, Alexander Neundorf neund...@kde.org wrote: The pages here: http://www.vtk.org/Wiki/CMake/Tutorials explain how to do this. There is a branch for that (SaroEngels

Re: Phonon

On Tue, May 17, 2011 at 10:33 PM, Alexander Neundorf neund...@kde.org wrote: On Sunday 15 May 2011, Alexander Neundorf wrote: On Friday 11 March 2011, Harald Sitter wrote: On Thu, Mar 10, 2011 at 11:23 PM, Ben Cooksley bcooks...@kde.org wrote: Note that if I don't get a reply, I

Re: Phonon

On Sun, May 22, 2011 at 6:10 PM, Alexander Neundorf neund...@kde.org wrote: I would suggest to install the buildsystem files not into share/phonon- buildsystem/, but into share/phonon/buildsystem/. Then also this generated library thingy file which is currently installed directly to

Re: Phonon

On Tue, May 31, 2011 at 12:31 AM, Alexander Neundorf neund...@kde.org wrote: On Sunday 22 May 2011, Alexander Neundorf wrote: ... There will be a PhononConfig.cmake file, which will be found by find_package(), and it will contain all the information about the installed phonon, like e.g.

Re: Phonon

On Tue, May 31, 2011 at 7:58 PM, Michael Jansen k...@michael-jansen.biz wrote: On Tuesday 31 May 2011 19:34:57 Harald Sitter wrote: On Tue, May 31, 2011 at 12:31 AM, Alexander Neundorf neund...@kde.org wrote: On Sunday 22 May 2011, Alexander Neundorf wrote

Re: Phonon's failure to detect Pulseaudio

On Tue, Jun 7, 2011 at 3:31 AM, Ben Cooksley bcooks...@kde.org wrote: Hi all, Currently my system (which has Pulseaudio enabled - version 0.9.21) with current Phonon master is NOT able to find Pulseaudio. As I need Pulseaudio in order to use my Bluetooth headset, it is highly irritating for

Re: RFC: Release Management Going Forward

On Friday 10 June 2011 03:31:20 Sebastian Kügler wrote: I suggest that we also add monolithic tarballs, starting from beta 2. This way we have split and combined tarballs. And I suggest that we continue to do this for the whole 4.7 cycle. And we need to discuss this again for 4.8. Yep,

Re: Phonon: install everything inside CMAKE_INSTALL_PREFIX

On Monday 13 June 2011 14:11:38 Alexander Neundorf wrote: So, please let me know if you still see any issues or whether this is how it should be handled. Looks all good and awesome to me. Additionally it also works ;) Thanks for fixing this! -- Harald

[phonon] /: Add option to build Phonon without experimental library

Git commit e66be3f01da496c637798e44696ff0d5a4506c90 by Harald Sitter. Committed on 02/08/2011 at 15:18. Pushed by sitter into branch 'master'. Add option to build Phonon without experimental library CCMAIL: kde-buildsystem@kde.org M +2-1CMakeLists.txt M +3-2phonon

Re: PulseAudio 1.0 and kdemultimedia 4.7.1

On Fri, Sep 30, 2011 at 2:46 PM, todd rme toddrme2...@gmail.com wrote: I am trying to build kdemultimedia 4.7.1 with pulseaudio 1.0, and I am getting this message:    Could NOT find PulseAudio:  Found version #define pa_get_headers_version() (1.0), but required is at least 0.9.12 (found

Re: PulseAudio 1.0 and kdemultimedia 4.7.1

On Fri, Sep 30, 2011 at 4:02 PM, Colin Guthrie co...@guthr.ie wrote: Or is this bit of code copied around horribly? Yes it is, at least there is a version in kdelibs and one in phonon (since phonon is a dep of kdelibs we need our own finder), from looking at the code it seems that phonon's

Review Request 110319: drop bodega cmake finder and use cmake config instead

and muon's backend builds Thanks, Harald Sitter ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 110319: drop bodega cmake finder and use cmake config instead

/ Testing --- found by muon and muon's backend builds Thanks, Harald Sitter ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 110319: drop bodega cmake finder and use cmake config instead

/ Testing --- found by muon and muon's backend builds Thanks, Harald Sitter ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 110319: drop bodega cmake finder and use cmake config instead

/r/110319/diff/ Testing --- found by muon and muon's backend builds Thanks, Harald Sitter ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

frameworks build instructions wrong / won't work with kubuntu 14.04

Alohas, tldr: in ubuntu 14.04 automoc will (currently does) fall over dead with a qt5 built according to frameworks build instructions. what to do? According to Ubuntu getting cmake to pick up the correct build binaries (outside system paths) via environment variables is not a sane way to do it

Re: frameworks build instructions wrong / won't work with kubuntu 14.04

On Wed, Dec 18, 2013 at 6:09 PM, Harald Sitter sit...@kde.org wrote: tldr: in ubuntu 14.04 automoc will (currently does) fall over dead with a qt5 built according to frameworks build instructions. what to do? xnox was nice enough to look into this in detail and identified the problem as having

Re: frameworks build instructions wrong / won't work with kubuntu 14.04

On Thu, Dec 19, 2013 at 7:45 PM, Dimitri John Ledkov dimitri.led...@surgut.co.uk wrote: So I was very clueless why Harald brought up that failing to build from source in his PPA build to a such a wide audience, when it was entirely unwarranted. And also in such a hasty manner, minutes after

Re: frameworks build instructions wrong / won't work with kubuntu 14.04

On Thu, Dec 19, 2013 at 3:19 PM, Sune Vuorela nos...@vuorela.dk wrote: On 2013-12-19, Harald Sitter sit...@kde.org wrote: Should be fixed as per: http://launchpadlibrarian.net/160197164/cmake_2.8.12.1-1ubuntu2_2.8.12.1-1ubuntu3.diff.gz It looks a bit better, but it is still full of open

ECM uninstall target

alohas, I just ported phonon/five to ECM and noticed that apparently ECM does not have an include or something to introduce an uninstall target. Are there plans to introduce such a thing or am I simply blind and not seeing the already existing include? HS

Re: Review Request 119798: Generating PkgConig files from ECM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/#review64581 --- +1 - Harald Sitter On Aug. 14, 2014, 11:10 p.m., Aleix Pol

Review Request 120229: allow qmldir to follow qt_sys_path

-query Thanks, Harald Sitter ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 120229: allow qmldir to follow qt_sys_path

installs qml plugins to path returned by qmake -query Thanks, Harald Sitter ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 120229: allow qmldir to follow qt_sys_path

: https://git.reviewboard.kde.org/r/120229/diff/ Testing --- without patch: solid installs qml plugins to $LIBDIR/qml with patch: solid installs qml plugins to path returned by qmake -query Thanks, Harald Sitter ___ Kde-buildsystem mailing list

Re: Review Request 120229: allow qmldir to follow qt_sys_path

/ Testing --- without patch: solid installs qml plugins to $LIBDIR/qml with patch: solid installs qml plugins to path returned by qmake -query Thanks, Harald Sitter ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman

Re: Review Request 120229: allow qmldir to follow qt_sys_path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120229/#review66658 --- altogether busted still... - Harald Sitter On Sept. 16

Re: Review Request 120229: allow qmldir to follow qt_sys_path

On Sept. 16, 2014, 11:16 a.m., Harald Sitter wrote: altogether busted still... Nevermind, kubuntu packaging was just being weird. Patch should work as intended - Harald --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 120229: allow qmldir to follow qt_sys_path

Diff: https://git.reviewboard.kde.org/r/120229/diff/ Testing --- without patch: solid installs qml plugins to $LIBDIR/qml with patch: solid installs qml plugins to path returned by qmake -query Thanks, Harald Sitter ___ Kde-buildsystem

Re: Review Request 120655: If find_dependency() fails, so should the Config file it is in

. - Harald Sitter On Oct. 19, 2014, 6:56 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120655/ --- (Updated

qca-qt5 package name

alohas. recently the QCA maintainer and I got into a discussion [1] whether a qca-qt5 library should be a different config inside the same cmake package or an independent one (detailed discussion in the longest comment thread of the review). find_package(Qca NAMES Qca-qt5 Qca-QT5 Qca-5 Qca

Re: Review Request 121696: Add COMPATIBILITY argument to ecm_setup_version().

:) - Harald Sitter On Dec. 27, 2014, 3:33 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121696

Re: Review Request 124009: tear cmake logic for qt4 and qt5 apart

cmake with both lineups and it passes, so yay, I guess. kinda crap to test properly Thanks, Harald Sitter ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 124009: tear cmake logic for qt4 and qt5 apart

--- On June 4, 2015, 8:53 p.m., Harald Sitter wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124009/ --- (Updated June 4, 2015

Re: Review Request 124009: tear cmake logic for qt4 and qt5 apart

marked as submitted. Review request for Build System, Phonon, Martin Gräßlin, and Hrvoje Senjan. Changes --- Submitted with commit 6d7e80cd5b0361272bb801b213e4fabde9a01784 by Harald Sitter to branch master. Repository: phonon Description --- - qt4 as before - qt5 now uses ECM to set

Re: Review Request 124104: Make it possible to use kconfig_compiler from different sources

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124104/#review81545 --- Ship it! Ship It! - Harald Sitter On June 18, 2015, 1:19

Re: Review Request 123874: Fix build with Qt = 5.4.2

fix probably would be to manually add CMAKE_${lang}_COMPILE_OPTIONS_PIC and CMAKE_${lang}_COMPILE_OPTIONS_PIE to the flags manually (i.e. replicate what ::AddPositionIndependentFlags does but using both PIC and PIE). - Harald Sitter On May 22, 2015, 4:45 a.m., Hrvoje Senjan wrote

Re: Review Request 123874: Fix build with Qt = 5.4.2

mean refactoring qt5_use_modules to isolate the mapping logic for use with LINK_LIBRARIES, or making the entire compatibility stuff not be so terrible. Hardly worthwhile as Thiago suggests moving forward Qt simply cannot be built without visibility anyway. - Harald Sitter On May 25, 2015, 4

Re: Review Request 124610: do not install namelink for private library

--- On Aug. 4, 2015, 8:04 a.m., Harald Sitter wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124610/ --- (Updated Aug. 4

Review Request 124611: do not install namelink for private library

installed Thanks, Harald Sitter ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Review Request 124610: do not install namelink for private library

installed made sure there is no symlink on the system and rebuilt gwenview: gwenview builds just fine Thanks, Harald Sitter ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 124611: do not install namelink for private library

marked as submitted. Review request for Build System and KDE Frameworks. Changes --- Submitted with commit 7dd4fa9f8f19bac44b54418dffefdccae58480f9 by Harald Sitter to branch master. Repository: kglobalaccel Description --- please note that the private target is appearing

Re: Review Request 124610: do not install namelink for private library

marked as submitted. Review request for Baloo, Build System and KDE Frameworks. Changes --- Submitted with commit 9807ff7416f651a0daf289b7bd024a7bb9952f99 by Harald Sitter to branch master. Repository: baloo Description --- please note that the private target is appearing

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

have to revert this before release. [1] https://aur.archlinux.org/packages/plasma-desktop-git/ Harald Sitter wrote: I tried it this morning and it seemed to work. Now I try it again and it fails I suppose this is the point where we call for a revert hammer? :P Harald

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

have to revert this before release. [1] https://aur.archlinux.org/packages/plasma-desktop-git/ Harald Sitter wrote: I tried it this morning and it seemed to work. Now I try it again and it fails I suppose this is the point where we call for a revert hammer? :P Harald

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

have to revert this before release. [1] https://aur.archlinux.org/packages/plasma-desktop-git/ Harald Sitter wrote: I tried it this morning and it seemed to work. Now I try it again and it fails I suppose this is the point where we call for a revert hammer? :P from

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

, and Harald Sitter. Bugs: 342962 https://bugs.kde.org/show_bug.cgi?id=342962 Repository: kdeclarative Description --- The kdeclarative plugins (draganddropplugin, kcoreaddonsplugin, kio, kquickcontrolsprivateplugin, and kquickcontrolsaddonsplugin) are being built as shared

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

Frameworks, Plasma, and Harald Sitter. Bugs: 342962 https://bugs.kde.org/show_bug.cgi?id=342962 Repository: kdeclarative Description --- The kdeclarative plugins (draganddropplugin, kcoreaddonsplugin, kio, kquickcontrolsprivateplugin, and kquickcontrolsaddonsplugin

Re: Review Request 125139: Do not find XINPUT in FindXCB.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125139/#review85123 --- yes please! - Harald Sitter On Sept. 10, 2015, 2:52 p.m

Re: Review Request 125139: Do not find XINPUT in FindXCB.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125139/#review85124 --- - Harald Sitter On Sept. 10, 2015, 2:52 p.m., Martin

Re: Review Request 110319: drop bodega cmake finder and use cmake config instead

e4c69eec793ef4a7a9728241345c2d1cf9053fac Diff: https://git.reviewboard.kde.org/r/110319/diff/ Testing --- found by muon and muon's backend builds Thanks, Harald Sitter ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org

Re: Review Request 128533: Create a test that validates projects' appstream information

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128533/#review98097 --- Ship it! Ship It! - Harald Sitter On Aug. 4, 2016, 11

Re: Review Request 128533: Create a test that validates projects' appstream information

somesuch magic If you actually pick up the result of the validation and then `message(STATUS` on ==0 or `message(FATAL_ERROR`, I think usefulness will go up 300% by actually claiming a validation fail when there was a fail :) - Harald Sitter On Aug. 3, 2016, 11:21

D5143: Introduce fetch-translations build command

sitter added inline comments. INLINE COMMENTS > KDECMakeSettings.cmake:74 > # - ``APPLE_SUPPRESS_X11_WARNING`` option since 5.14.0 > > > #= Needs documentation for the l10n awesomeness. >

D5143: Introduce fetch-translations build command

sitter added a comment. In https://phabricator.kde.org/D5143#97985, @apol wrote: > In https://phabricator.kde.org/D5143#97847, @aacid wrote: > > > That creates a dependency for ki18n for frameworks that only use .ts files, no? > > > One thing we can do is remove the

D5143: Introduce fetch-translations build command

sitter added a comment. Oh! OTOH, given fetch-translations pulls it into bin_dir while normally we'd have it in src_dir this may well be awkward in implementation. e.g. https://phabricator.kde.org/D5197 effectively ought to be ki18n_install("${CMAKE_SOURCE_DIR}/po")

D5143: Introduce fetch-translations build command

sitter added a comment. The way I understand it the use case here is during development, so I am not sure the ki18n circular dep is particularly concerning. Avoiding it seems fairly difficult as find_package needs to happen at configure-time, fetch-translations at build-time, and so we only

D5143: Introduce fetch-translations build command

sitter added a comment. A couple of things I am not sure about - defaults to stable translations, I'd say it should default to trunk. e.g. playground and kdereview don't even have stable - considering one has to enable this feature in the cmakecache I think it should be made a

D5143: Introduce fetch-translations build command

sitter added a comment. needs a version bump in the docs now  beyond that LGTM INLINE COMMENTS > KDECMakeSettings.cmake:86 > +# > +# Since 5.33.0 > 5.34 now > KDECMakeSettings.cmake:323 > +COMMAND ruby "${CMAKE_BINARY_DIR}/releaseme/fetchpo.rb" --origin >

D5143: Introduce fetch-translations build command

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D5143 To: apol, #frameworks, #build_system, kfunk, ltoscano, aacid, ilic, sitter Cc: sitter

D5352: Add a test for _repository_name() a function added for fetch-translations

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D5352 To: apol, sitter, aacid Cc: #frameworks, #build_system

D5352: Add a test for _repository_name() a function added for fetch-translations

sitter added inline comments. INLINE COMMENTS > CMakeLists.txt:25 > + > +if(NOT TARGET fetch-translations AND NOT EXISTS > "${CMAKE_CURRENT_SOURCE_DIR}/../../po") > +message(FATAL_ERROR "should have a fetch-translations target") `AND NOT EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/../../po"` is

D5523: use correct variable for fetch-translations injection

sitter created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY KDE_L10N_AUTO_TRANSLATIONS is the name of the relevant option REPOSITORY R240 Extra CMake Modules BRANCH

D5523: use correct variable for fetch-translations injection

This revision was automatically updated to reflect the committed changes. Closed by commit R240:fe46a935227f: use correct variable for fetch-translations injection (authored by sitter). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D5525: adapt to fetchpo changes and use vars for target directories to dry code

This revision was automatically updated to reflect the committed changes. Closed by commit R240:77623d19b627: adapt to fetchpo changes and use vars for target directories to dry code (authored by sitter). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D5525: adapt to fetchpo changes and use vars for target directories to dry code

sitter created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY - fetchpo now expects the output dirs as named arguments - new argument for poqm directories where releaseme will

D6604: add a metainfo.yaml to make ECM a proper framework

sitter added a comment. Good point on trying it locally. So, as one could expect this adds ECM as a product F3808791: Screenshot_20170711_120142.png Unfortunately given we have no actual documentation (outside the cmake documentation)

D6604: add a metainfo.yaml to make ECM a proper framework

sitter added a comment. In https://phabricator.kde.org/D6604#124228, @ochurlaud wrote: > At the time I thought about merging it but we would have to re-document everything in doxygen , which would be completely different from what upstream cmake does. > > The ECM page is already

D6604: add a metainfo.yaml to make ECM a proper framework

sitter created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D6604 AFFECTED FILES

D6604: add a metainfo.yaml to make ECM a proper framework

sitter added a comment. related to https://phabricator.kde.org/D6603 @ochurlaud I hope this will not break api.kde, given ECM hasn't had a metainfo.yaml previously it seems to have some sort of special arrangement? REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D6604: add a metainfo.yaml to make ECM a proper framework

sitter updated this revision to Diff 16626. sitter added a comment. add a readme I've tried for like 2 hours to wire this into the existing docs build and get away with one README. Alas, no luck. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D6604: add a metainfo.yaml to make ECM a proper framework

This revision was automatically updated to reflect the committed changes. Closed by commit R240:5f6aa58b8067: add a metainfo.yaml to make ECM a proper framework (authored by sitter). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D7094: Include a module for finding qml imports as runtime dependencies

sitter added inline comments. INLINE COMMENTS > apol wrote in ECMFindQMLModule.cmake.in:30 > Doing find_program for now. The right fix would be to change Qt to export the > `qmlplugindump` target. You still need to do "something" if qmlplugindump isn't found. Print a `message(WARNING` and/or

D7094: Include a module for finding qml imports as runtime dependencies

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Oh it's gorgeous! REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D7094 To: apol, #build_system, #frameworks, sitter Cc: dfaure, aacid

D5741: Fix test when compiling from a tarball

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D5741 To: apol, #frameworks, joselema, sitter Cc: #build_system

Re: Frameworks and pkgconfig files

On Wed, Nov 29, 2017 at 9:43 AM, Christophe Giboudeaux wrote: > Hello, > > in https://bugs.kde.org/386933, the bug reporter mentions the pkgconfig file > name shall match the library one. I cannot find any such requirement. It is *suggested* to have one config per lib with

D9299: Introduce INSTALL_PREFIX_SCRIPT to easily set up prefixes

sitter requested changes to this revision. sitter added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > KDEInstallDirs.cmake:699 > +if(INSTALL_PREFIX_SCRIPT) > +file(WRITE ${CMAKE_BINARY_DIR}/prefix.sh " > +export

D9299: Introduce INSTALL_PREFIX_SCRIPT to easily set up prefixes

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. I currently can't do a testbuild, but the code looks good now. If we want to iterate on the concept further I think we should do it separately, no sense holding up this diff from

D16221: style++

This revision was automatically updated to reflect the committed changes. Closed by commit R240:72aa6e1bf19c: style++ (authored by sitter). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16221?vs=43649=43650 REVISION DETAIL

D16221: style++

sitter created this revision. sitter added a reviewer: apol. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY easier to read with spaces SCM_SILENT REPOSITORY R240

D18952: new find module for Canberra

sitter updated this revision to Diff 52042. sitter added a comment. explicitly set FOUND_VAR so it is camelcase too REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18952?vs=51976=52042 BRANCH master REVISION DETAIL

D18952: new find module for Canberra

This revision was automatically updated to reflect the committed changes. Closed by commit R240:50e8dd7b2d00: new find module for Canberra (authored by sitter). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18952?vs=52042=52043 REVISION DETAIL

D18952: new find module for Canberra

sitter marked an inline comment as done. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D18952 To: sitter, cgiboudeaux Cc: aacid, apol, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18952: new find module for Canberra

sitter updated this revision to Diff 51952. sitter added a comment. - pkgconfig is now quiet - variables are now camelcase - old variables are still set for compat - new imported target (also sets pkgconfig's cflags, which I presume is the sane thing to do) - set package description

D18952: new find module for Canberra

sitter marked 5 inline comments as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18952 To: sitter, cgiboudeaux Cc: aacid, apol, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18952: new find module for Canberra

sitter updated this revision to Diff 51976. sitter added a comment. fix bad copy paste in compat setup REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18952?vs=51952=51976 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18952

D18952: new find module for Canberra

sitter added a comment. Good point, I've also noticed that (all?) our finders now also create an IMPORTED target. Should we maybe add that too? If so I guess `Canberra::Canberra` would be the preferred target name? REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D18952: new find module for Canberra

sitter updated this revision to Diff 51576. sitter added a comment. document in rst syntax REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18952?vs=51491=51576 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18952 AFFECTED

D18952: new find module for Canberra

sitter created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY used by: - knotification - (possibly also knotifyconfig at some point) - plasma-pa

D23262: disable autouic again - it breaks builds

This revision was automatically updated to reflect the committed changes. Closed by commit R240:557e5d898bf9: disable autouic again - it breaks builds (authored by sitter). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23262?vs=64039=64042

D23262: disable autouic again - it breaks builds

sitter added a comment. https://gitlab.kitware.com/cmake/cmake/issues/19615 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23262 To: sitter, apol, nicolasfella, cullmann Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh,

D22805: set autorcc and autouic by default

This revision was automatically updated to reflect the committed changes. Closed by commit R240:60ca1a27e539: set autorcc and autouic by default (authored by sitter). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22805?vs=64033=64037 REVISION

D22805: set autorcc and autouic by default

sitter updated this revision to Diff 64033. sitter added a comment. typo-- REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22805?vs=64032=64033 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22805 AFFECTED FILES

D22805: set autorcc and autouic by default

sitter abandoned this revision. sitter added a comment. D23262 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22805 To: sitter, apol, nicolasfella Cc: cullmann, nicolasfella, cgiboudeaux, vkrause, kossebau, apol,

D22805: set autorcc and autouic by default

sitter updated this revision to Diff 64032. sitter added a comment. bump version again REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22805?vs=62838=64032 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22805 AFFECTED FILES

D23262: disable autouic again - it breaks builds

sitter created this revision. sitter added reviewers: apol, nicolasfella, cullmann. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY autouic (like automoc) assumes that

D23552: ECM: remove set_package_properties from FindCanberra

sitter added a comment. No objections from me. This was explicitly suggested during review though, so I'd like @cgiboudeaux to approve this. INLINE COMMENTS > FindCanberra.cmake:95 > > include(FeatureSummary) > Can be removed as well. REPOSITORY R240 Extra CMake Modules REVISION

D22805: set autorcc by default

sitter added a comment. Indeed, both good points. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22805 To: sitter Cc: vkrause, kossebau, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns

  1   2   >