dfaure closed this revision.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D28409
To: dfaure, kossebau, apol, cgiboudeaux
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy,
michaelh, ngraham, bruns
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28409
To: dfaure, kossebau, apol, cgiboudeaux
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2,
dfaure added inline comments.
INLINE COMMENTS
> CMakeLists.txt:146
> set(KDEInstallDirsTest.relative_or_absolute_usr_EXTRA_OPTIONS
> --build-options -DCMAKE_INSTALL_PREFIX=/usr
> -DKDE_INSTALL_USE_QT_SYS_PATHS=FALSE
This test uses /usr and passes on Windows.
It's not
apol added a comment.
Will /tmp then still work on Windows?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D28409
To: dfaure, kossebau, apol, cgiboudeaux
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy,
michaelh, ngraham,
dfaure created this revision.
dfaure added reviewers: kossebau, apol, cgiboudeaux.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
dfaure requested review of this revision.
REVISION SUMMARY
Not passing CMAKE_INSTALL_PREFIX is a
